Internal login pages: add (id|auth).atlassian.com (fix #1265)

This commit is contained in:
Ronan Jouchet 2021-07-28 23:22:02 -04:00
parent 33f293120d
commit 1a54d286d8
3 changed files with 9 additions and 7 deletions

12
API.md
View File

@ -775,17 +775,15 @@ change it but it might be unnecessary.
Current known internal login pages:
- `amazon.com/signin`
- `appleid.apple.com/auth/authorize`
- `id.atlassian.com` , `auth.atlassian.com`
- `facebook.com/login`
- `github.com/login`
- `github.com/session`
- `accounts.google.com`
- `mail.google.com/accounts/SetOSID`
- `github.com/login` , `github.com/session`
- `accounts.google.com` , `mail.google.com/accounts/SetOSID`
- `linkedin.com/uas/login`
- `login.live.com`
- `login.microsoftonline.com`
- `login.live.com` , `login.microsoftonline.com`
- `okta.com`
- `twitter.com/oauth/authenticate`
- `appleid.apple.com/auth/authorize`
Note: While .com is specified, for most of these we try to match even on non-US
based domains such as `.co.uk` as well

View File

@ -112,6 +112,8 @@ const testLoginPages = [
'https://twitter.com/oauth/authenticate',
'https://twitter.de/oauth/authenticate',
'https://appleid.apple.com/auth/authorize',
'https://id.atlassian.com',
'https://auth.atlassian.com',
];
test.each(testLoginPages)(
@ -131,6 +133,7 @@ const testNonLoginPages = [
'https://twitter.com/marcoroth_/status/1325938620906287104',
'https://appleid.apple.com/account',
'https://mail.google.com/',
'https://atlassian.com',
];
test.each(testNonLoginPages)(

View File

@ -105,6 +105,7 @@ function isInternalLoginPage(url: string): boolean {
'okta\\.[a-zA-Z\\.]*', // Okta
'twitter\\.[a-zA-Z\\.]*/oauth/authenticate', // Twitter
'appleid\\.apple\\.com/auth/authorize', // Apple
'(?:id|auth)\\.atlassian\\.[a-zA-Z]+', // Atlassian
];
// Making changes? Remember to update the tests in helpers.test.ts and in API.md
const regex = RegExp(internalLoginPagesArray.join('|'));