diff --git a/API.md b/API.md index 30bab46..90651c4 100644 --- a/API.md +++ b/API.md @@ -775,17 +775,15 @@ change it but it might be unnecessary. Current known internal login pages: - `amazon.com/signin` +- `appleid.apple.com/auth/authorize` +- `id.atlassian.com` , `auth.atlassian.com` - `facebook.com/login` -- `github.com/login` -- `github.com/session` -- `accounts.google.com` -- `mail.google.com/accounts/SetOSID` +- `github.com/login` , `github.com/session` +- `accounts.google.com` , `mail.google.com/accounts/SetOSID` - `linkedin.com/uas/login` -- `login.live.com` -- `login.microsoftonline.com` +- `login.live.com` , `login.microsoftonline.com` - `okta.com` - `twitter.com/oauth/authenticate` -- `appleid.apple.com/auth/authorize` Note: While .com is specified, for most of these we try to match even on non-US based domains such as `.co.uk` as well diff --git a/app/src/helpers/helpers.test.ts b/app/src/helpers/helpers.test.ts index 4198d96..070520b 100644 --- a/app/src/helpers/helpers.test.ts +++ b/app/src/helpers/helpers.test.ts @@ -112,6 +112,8 @@ const testLoginPages = [ 'https://twitter.com/oauth/authenticate', 'https://twitter.de/oauth/authenticate', 'https://appleid.apple.com/auth/authorize', + 'https://id.atlassian.com', + 'https://auth.atlassian.com', ]; test.each(testLoginPages)( @@ -131,6 +133,7 @@ const testNonLoginPages = [ 'https://twitter.com/marcoroth_/status/1325938620906287104', 'https://appleid.apple.com/account', 'https://mail.google.com/', + 'https://atlassian.com', ]; test.each(testNonLoginPages)( diff --git a/app/src/helpers/helpers.ts b/app/src/helpers/helpers.ts index f815585..b374e24 100644 --- a/app/src/helpers/helpers.ts +++ b/app/src/helpers/helpers.ts @@ -105,6 +105,7 @@ function isInternalLoginPage(url: string): boolean { 'okta\\.[a-zA-Z\\.]*', // Okta 'twitter\\.[a-zA-Z\\.]*/oauth/authenticate', // Twitter 'appleid\\.apple\\.com/auth/authorize', // Apple + '(?:id|auth)\\.atlassian\\.[a-zA-Z]+', // Atlassian ]; // Making changes? Remember to update the tests in helpers.test.ts and in API.md const regex = RegExp(internalLoginPagesArray.join('|'));