Commit Graph

9506 Commits

Author SHA1 Message Date
Michael Kuhn e38fcd6dea Fix button focus issues
This change introduces derived classes for ComboButton, DropDownButton
and Select that make sure that buttons do not remain focused after their
menus are closed. This allows using hotkeys after closing them.
2019-04-14 12:01:52 +02:00
Michael Kuhn 4a2a90c980 Fix focus issues with hotkeys
Since making use of keypress in addition to keydown, hotkeys did not
work in certain scenarios, including clicking on the feed tree expanders
or empty spaces of the toolbar.

This issue is caused by dijit.Tree and dijit.Toolbar implementing the
_KeyNavMixin, which explicitly stops propagation of keypress events.

This change contains two main fixes plus a smaller hotfix:
1. It overrides _onContainerKeydown and _onContainerKeypress for
   fox.FeedTree (which inherits from dijit.Tree).
2. It adds fox.Toolbar, which overrides _onContainerKeydown,
   _onContainerKeypress and focus. This fixes hotkeys being swallowed
   and the first focusable child receiving focus when clicking on an
   empty space of the toolbar.
3. It adds the same handling of keydown and keypress to the prefs hotkey
   handler as is done in the main hotkey handler.
2019-04-13 22:34:57 +02:00
fox 7e55340295 Merge branch 'master' of ltGuillaume/tt-rss into master 2019-04-12 07:32:02 +00:00
ltGuillaume 3d8c6967da Add keyboard shortcut 'g r': Go to Recently read 2019-04-12 07:29:15 +00:00
ltGuillaume 4c72d3b4fc Add keyboard shortcut 'g r': Go to Recently read 2019-04-12 07:28:45 +00:00
Andrew Dolgov 6fbf349155 add hidden _SKIP_SESSION_UA_CHECKS tunable 2019-04-11 16:15:55 +03:00
Andrew Dolgov c7ad4ad2d4 import_export: use default ts_lang if user one is unset 2019-04-11 13:38:47 +03:00
Andrew Dolgov dee1614d0a db_prefs: return null if requested key is unset 2019-04-10 13:39:55 +03:00
Andrew Dolgov e31e9ae04d db_prefs: don't report missing prefs if die_on_error is false 2019-04-10 13:39:07 +03:00
Andrew Dolgov 9e200f2cf0 schema: update version to 138 2019-04-10 13:20:16 +03:00
Andrew Dolgov d32e191ad7 import_export: set tsvector_combined using DEFAULT_SEARCH_LANGUAGE on import 2019-04-10 13:18:23 +03:00
Andrew Dolgov ed22473272 feed editor: use DEFAULT_SEARCH_LANGUAGE as a default per-feed dropdown value 2019-04-10 13:08:32 +03:00
Andrew Dolgov c936cc3a1f use DEFAULT_SEARCH_LANGUAGE to generate tsvector index if per-feed language is not specified, also use it as default value on search form for convenience 2019-04-10 13:03:26 +03:00
Andrew Dolgov 6768b3a4a3 schema: add DEFAULT_SEARCH_LANGUAGE 2019-04-10 12:47:46 +03:00
Andrew Dolgov d7282ec292 import_export: prevent form closing before doing anything; update markup 2019-04-09 07:05:33 +03:00
Andrew Dolgov cc2ac3a86c FeedTree: add feed debugger to per-feed context menu 2019-04-08 15:51:05 +03:00
Andrew Dolgov 1a484ec3f5 feedparser: remove horrible hacks for feeds with broken encoding 2019-04-01 09:02:05 +03:00
fox cb0c81729d Merge branch 'master' of Greg-T/tt-rss into master 2019-03-29 03:52:15 +00:00
Greg-T 2c2f74a104 PDO error in cleanup_tags repaired
Changes :
- add PDO::PARAM_INT to a value in a PDO query
- switch limit to limit_part to respect semantic here (cleanup by packages)
2019-03-28 15:50:13 +00:00
Andrew Dolgov 656475ec78 digest text mode excerpt: use ellipsis fit for plain text 2019-03-26 08:51:36 +03:00
Andrew Dolgov 4e1eeb0488 digest text mode: fix article excerpt source 2019-03-26 08:08:50 +03:00
Andrew Dolgov 59d0e35b7d Merge branch 'master' of git.fakecake.org:tt-rss 2019-03-22 14:56:53 +03:00
Andrew Dolgov b583ca12fb Merge branch 'weblate-integration' 2019-03-22 14:56:44 +03:00
Andrew Dolgov 671f4cee65 domdocument: remove old meta charset unicode hacks, replace with shorter xml preamble utf8 hack (on loadhtml where it makes sense)
af_readability: better (?) charset hack for non-unicode pages
2019-03-21 21:08:02 +03:00
Andrew Dolgov 3bd3324e5a update: add option to send digests 2019-03-21 07:44:39 +03:00
Andrew Dolgov 6ae0a3dd3e share: further improve og:description excerpt logic, minor layout stuff 2019-03-19 20:41:38 +03:00
Andrew Dolgov 74e8661351 share: decode entities in metadata fields so that length limits would make more sense 2019-03-19 15:53:32 +03:00
Andrew Dolgov 9f52327b34 feedlist: adjust star position 2019-03-19 08:29:43 +03:00
Andrew Dolgov 01b2f0a24f support "picture" tags in articles 2019-03-19 07:18:48 +03:00
fox e35c656b38 Merge branch 'hotkeys-keypress-bugfix' of suraia/tt-rss into master 2019-03-17 18:10:55 +00:00
Michael Kuhn bbb8a2e873 Fix missed hotkeys in googlereaderkeys plugin 2019-03-17 17:39:20 +01:00
himori kim 24c12e6114 Translated using Weblate (Korean)
Currently translated at 65.6% (484 of 738 strings)

Translation: Tiny Tiny RSS/messages
Translate-URL: https://weblate.tt-rss.org/projects/tt-rss/messages/ko/
2019-03-17 14:52:35 +00:00
Andrew Dolgov 375c4c28a0 Merge branch 'master' of git.fakecake.org:tt-rss 2019-03-16 15:35:18 +03:00
Andrew Dolgov eab568065f enable excerpt for text digest 2019-03-16 15:35:11 +03:00
Andrew Dolgov 33a2d5f8e4 update_rss_feed: set basic feed info if site_url is blank 2019-03-15 14:00:09 +03:00
Andrew Dolgov 4438f27f73 Merge branch 'master' of git.tt-rss.org:fox/tt-rss 2019-03-14 09:08:57 +03:00
Andrew Dolgov b1bb7c6001 Merge branch 'master' of git.fakecake.org:tt-rss 2019-03-14 09:08:52 +03:00
Andrew Dolgov 019f4578bc fix feed icon upload not working, rework form to use FormData/ajax 2019-03-14 09:08:44 +03:00
fox e0dabf318b Merge branch 'Add_set_basic_feed_info_to_af_comics' of rodneys_mission/tt-rss into master 2019-03-13 04:49:01 +00:00
Rodney Stromlund 7daf009a7f Add set_basic_feed_info hook to af_comics to fix GoComics title and url. 2019-03-12 12:16:24 -05:00
fox 63d7705b7f Merge branch 'hotkeys-keypress' of suraia/tt-rss into master 2019-03-11 11:05:58 +00:00
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
2019-03-11 12:01:27 +01:00
Andrew Dolgov 355723ca59 ttrss_zoom: limit maximum width to make text more readable 2019-03-11 11:53:19 +03:00
Andrew Dolgov 08183fcd27 set key length to 255 on mysql 2019-03-10 15:48:47 +03:00
Andrew Dolgov 32f9fda33d add composite key on ttrss_feeds (feed_url & owner_uid) 2019-03-10 15:45:30 +03:00
fox 95e70320a6 Merge branch 'to_combined' of suraia/tt-rss into master 2019-03-10 07:08:30 +00:00
Andrew Dolgov 241d646fba batch subscribe: stop dialog from being submitted twice 2019-03-10 09:20:46 +03:00
Michael Kuhn dd9e93384e Fix to_address being logged twice 2019-03-09 20:09:16 +01:00
Andrew Dolgov a34509c8ae Merge branch 'master' of git.fakecake.org:tt-rss 2019-03-08 10:12:06 +03:00
Andrew Dolgov 19f162dbe3 css: insensitive -> text-muted 2019-03-08 10:11:57 +03:00