keeweb
/
keeweb
mirror of https://github.com/keeweb/keeweb.git
1
0
Fork 0
Code Issues Releases Wiki Activity

grammar

This commit is contained in:
antelle 2017-12-09 23:50:05 +01:00
parent d96df170c4
commit 3f2befe3e6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -5,11 +5,11 @@ Please follow these steps:
1. work on the right branch: it must be `develop` for new features and `master` for hotfixes 1. work on the right branch: it must be `develop` for new features and `master` for hotfixes
2. make sure the feature you add is not listed in [banned features](https://github.com/keeweb/keeweb/wiki/Unsupported-Features) 2. make sure the feature you add is not listed in [banned features](https://github.com/keeweb/keeweb/wiki/Unsupported-Features)
3. check compatibility with [the project roadmap](https://github.com/keeweb/keeweb/wiki/TODO) and key features: you should not break anything 3. check compatibility with [the project roadmap](https://github.com/keeweb/keeweb/wiki/TODO) and key features: you should not break anything
4. if your feature is introducing a lot of new UI, or is changing any UX or design concept, please, open an issue to discuss it first 4. if your feature is introducing a lot of new UI or changing any UX or design concept, please open an issue to discuss it first
5. please, respect existing style in code, styles and markup (hint: install and enable [editorconfig](http://editorconfig.org/) in your editor) 5. please respect existing style in code, styles, and markup (hint: install and enable [editorconfig](http://editorconfig.org/) in your editor)
6. don't add any dependencies 6. don't add any dependencies
7. test your code: it must work in browser, Windows, OSX and Linux 7. test your code: it must work in all browsers, Windows, OSX, and Linux
8. if your code is platform-dependent, please add corresponding switches 8. if your code is platform-dependent, please add corresponding switches
9. respect each platform: don't create behaviour which breaks interface guidelines or user expectations 9. respect each platform: don't create a behaviour that breaks interface guidelines or user expectations
10. run `grunt` and make sure it's passing 10. run `grunt` and make sure it's passing
11. replace this message with actual description 11. replace this message with the actual description