emacs
/
plantuml-mode
mirror of https://github.com/skuro/plantuml-mode.git
1
0
Fork 0
Code Issues Releases Wiki Activity

feat: Perform the computation in a separate buffer before showing it 

The previous implementation first killed the preview buffer and
then run plantuml. If plantuml takes a few seconds, it is annoying
to have the buffer vanishing and appearing again a few seconds
later.

It seems smoother to perform the computation while still showing
the obsolete buffer and replace the buffer when the result is
ready.
This commit is contained in:
Samuel Loury 2023-04-04 15:36:56 +02:00
parent ea45a13707
commit 8811f09650
No known key found for this signature in database
GPG Key ID: 75D23CED7439106A
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
plantuml-mode.el
View File

@ -324,6 +324,7 @@
(setq found (search-forward ";" nil nil))))))) (setq found (search-forward ";" nil nil)))))))
(defconst plantuml-preview-buffer "*PLANTUML Preview*") (defconst plantuml-preview-buffer "*PLANTUML Preview*")
(defconst plantuml-compute-buffer "*PLANTUML compute*")
(defvar plantuml-output-type (defvar plantuml-output-type
(if (not (display-images-p)) (if (not (display-images-p))
@ -395,6 +396,9 @@ Window is selected according to PREFIX:
- 4 (when prefixing the command with C-u) -> new window - 4 (when prefixing the command with C-u) -> new window
- 16 (when prefixing the command with C-u C-u) -> new frame. - 16 (when prefixing the command with C-u C-u) -> new frame.
- else -> new buffer" - else -> new buffer"
(let ((b (get-buffer plantuml-preview-buffer)))
(when b
(kill-buffer b)))
(let ((imagep (and (display-images-p) (let ((imagep (and (display-images-p)
(plantuml-is-image-output-p)))) (plantuml-is-image-output-p))))
(cond (cond
@ -403,6 +407,7 @@ Window is selected according to PREFIX:
(t (display-buffer buf))) (t (display-buffer buf)))
(when imagep (when imagep
(with-current-buffer buf (with-current-buffer buf
(rename-buffer plantuml-preview-buffer)
(image-mode) (image-mode)
(set-buffer-multibyte t))))) (set-buffer-multibyte t)))))
@ -482,17 +487,16 @@ Put the result into buffer BUF, selecting the window according to PREFIX:
(defun plantuml-preview-string (prefix string) (defun plantuml-preview-string (prefix string)
"Preview diagram from PlantUML sources (as STRING), using prefix (as PREFIX) "Preview diagram from PlantUML sources (as STRING), using prefix (as PREFIX)
to choose where to display it." to choose where to display it."
(let ((b (get-buffer plantuml-preview-buffer))) (let ((b (get-buffer plantuml-compute-buffer)))
(when b (when b
(kill-buffer b))) (kill-buffer b)))
(let* ((imagep (and (display-images-p) (let* ((imagep (and (display-images-p)
(plantuml-is-image-output-p))) (plantuml-is-image-output-p)))
(buf (get-buffer-create plantuml-preview-buffer)) (buf (get-buffer-create plantuml-compute-buffer))
(coding-system-for-read (and imagep 'binary)) (coding-system-for-read (and imagep 'binary))
(coding-system-for-write (and imagep 'binary))) (coding-system-for-write (and imagep 'binary)))
(plantuml-exec-mode-preview-string prefix (plantuml-get-exec-mode) string buf))) (plantuml-exec-mode-preview-string prefix (plantuml-get-exec-mode) string buf)))
(defun plantuml-preview-buffer (prefix) (defun plantuml-preview-buffer (prefix)
"Preview diagram from the PlantUML sources in the current buffer. "Preview diagram from the PlantUML sources in the current buffer.
Uses prefix (as PREFIX) to choose where to display it: Uses prefix (as PREFIX) to choose where to display it: