Commit Graph

4997 Commits

Author SHA1 Message Date
Dirk-Jan C. Binnema 000c19e505 server: improve error message 2020-02-18 12:03:42 +02:00
Dirk-Jan C. Binnema 6b07819d9a mu4e/mu-server: use :descending, :no-view parameters
There was some confusion between mu4e and mu-server.
2020-02-18 12:03:42 +02:00
Dirk-Jan C. Binnema c4c56fa7f0 mu-store: auto-commit store in dtor 2020-02-17 22:29:44 +02:00
Dirk-Jan C. Binnema 0b4dee6996 mu-script: fix compiler warning 2020-02-17 21:45:21 +02:00
Dirk-Jan C. Binnema bff48cc87f
Merge pull request #1573 from tarsiiformes/cleanup
fix mu4e indentation
2020-02-17 20:54:10 +02:00
Jonas Bernoulli 6d581c4ca0 mu4e~view-define-mode: Place doc-string in correct position 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 9f26819efb mu4e: Demote a few broken commands to functions
It would was not possible to interactively invoke these functions
because their `interactive' form does not provide all the mandatory
arguments.
2020-02-17 14:28:00 +01:00
Jonas Bernoulli 30e005d574 Fix a few typos 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 7d758da0e3 Add .mailmap file
Always use the author's full name instead of either the name or nick.
2020-02-17 14:28:00 +01:00
Jonas Bernoulli 32066ae433 mu4e~contains-line-matching: Cosmetics 2020-02-17 14:28:00 +01:00
Jonas Bernoulli f66be19121 mu4e~proc-running-p: Cosmetics 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 832d32ef23 mu4e-proc.el: Remove duplicated variable declarations 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 4ce296d6b2 manual: Deal with annoying misfeature of texinfo
Texinfo is of the opinion that every hyperlink has to be prefixed
by either "see" or "in".  If neither of these words appears there,
then it inserts "see" and it cannot be told not to do that.

This turns a correct sentence like:
  > Mu4e lets you define custom actions for messages in the <Headers view>.
into:
  > Mu4e lets you define custom actions for messages in the see <Headers view>.
The best compromise is
  > Mu4e lets you define custom actions for messages in <Headers view>.
which isn't correct but at least less messed up.

Alternatively one could rephrase every sentence that contains a link
to circumvent Texinfo's speech impairment.  Or one could replace each
link with a footnote and place the actual link in the footnote.
2020-02-17 14:28:00 +01:00
Jonas Bernoulli 440ea3fe6f manual: Fix indentation in code blocks 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 5f0013d797 org-mu4e.el: Place summary on a single line
Use the previous summary as commentary instead.
2020-02-17 14:28:00 +01:00
Jonas Bernoulli 96cd0632f9 mu4e: Improve consistency of library headers 2020-02-17 14:28:00 +01:00
Jonas Bernoulli c2ef02f57c mu4e: Begin each elisp summary line with three semicolons 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 4c9be1d062 mu4e-header-info: Fix indentation 2020-02-17 14:28:00 +01:00
Jonas Bernoulli 6790c0d015 mu4e: Fix indentation 2020-02-17 14:28:00 +01:00
Jonas Bernoulli be1ba1ce68 mu4e: Enforce use of spaces for indentation
There already is a ".editorconfig" file for cross-editor
configuration, but most Emacs users don't use that, so this also has
to be configured the traditional Emacs way.  (Also I have some doubts
that cross-editor configuration is relevant for Emacs Lisp files.)
2020-02-17 14:28:00 +01:00
Jonas Bernoulli 173deff6a0 editorconfig: Don't misconfigure indentation for Emacs lisp files
1) It is fairly safe to assume that almost all edits to Emacs lisp
   files will be done using the Emacs editor, so there is no need
   to configure this in a way understood by other editors.

2) Trying to configure the intention of lisp code using editorconfig
   causes the indention to be wrong.  Here "wrong" does not mean, "it
   uses tabs when everyone knows that spaces is the true path" (or
   vice-versa), but in the sense of "in lisp indentation is subject to
   the outer expression, and it has been like that for decades, but we
   are just going to ignore that completely and pretend this is
   actually python code".

For example, if we insert a new line character between the 1 and 2
in (progn (progn 1 2) then there are only two ways to intend that
correctly.

(We use "." to represent a leading space and "<-->" to represent
leading tabs.  "<------>" for a tab when it is shown eight characters
wide or "<>" if only two.)

First correct way:

  (setq-local indent-tabs-mode t)

  (progn (progn 1
  <------>......2))

Second correct way:

  (setq-local indent-tabs-mode nil)

  (progn (progn 1
  ..............2))

With the old editorconfig configuration,

  [*.el]
  indent_style                = tab
  indent_size                 = 2
  max_line_length             = 100

we get:

  (progn (progn 1
  <><><><>.2))

This is not how `progn' is indented.  No special indentation rules are
defined for it so all arguments are supposed to be aligned.  For
`prog1' however special indentation are defined and if we replaced the
second `progn' in this example with a `prog1', then this would
actually be correct.  This just demonstrate that it is wrong to indent
everything the same for lisp; the reason that `progn' and `prog1' are
indented differently communicates different meanings to the reader.

I had faint hope that without setting `indent_size' things would work
correctly, but no,

  [*.el]
  indent_style                = tab
  max_line_length             = 100

gives us:

  (progn (progn 1
  <------>.......2))

That doesn't even make sense if we pretend to be looking at python
code.  Turns out that `indent_size' defaults to 2 even for lisp code
as can be demonstrated by additionally doing,

  (setq-local tab-width 2)

which gives us:

  (progn (progn 1
  <>.......2))

which at least makes some sense.
2020-02-17 14:27:54 +01:00
Jonas Bernoulli 5ff051e64d gitignore: update 2020-02-17 11:29:49 +01:00
Dirk-Jan C. Binnema 0dced59cb9 mu4e: set better default for mu4e-compose-reply-ignore-address
... and some small cleanup
2020-02-15 22:36:00 +02:00
Dirk-Jan C. Binnema 62cc675a51 server: explicitly flush after indexing 2020-02-15 18:26:45 +02:00
Dirk-Jan C. Binnema 10fa0727ef server: clear up move_docid
Ensure all paths free resources
2020-02-15 14:12:21 +02:00
Dirk-Jan C. Binnema beb1b3199f mu-msg-part: clean up error paths
Ensure things get freed even when an error occurs.
2020-02-15 14:10:59 +02:00
Dirk-Jan C. Binnema a4a682e578 mu: add memcheck script for valgrinding 2020-02-15 14:09:30 +02:00
Dirk-Jan C. Binnema c22eb434b7 mu: improve crypto handling 2020-02-14 00:36:54 +02:00
Dirk-Jan C. Binnema dd057b11aa mu4e: fix compose-func
Use 'extract-encrypted'
2020-02-14 00:35:52 +02:00
Dirk-Jan C. Binnema ef4fa46a1d mu4e-proc: fix a few typos in 'view' handler
Fixes #1572.
2020-02-13 00:17:03 +02:00
Dirk-Jan C. Binnema b77b536d81
Merge pull request #1444 from JulienMasson/threads-sorting
mu: add an option to ignore leader when sorting childs of a thread
2020-02-10 21:58:33 +02:00
Dirk-Jan C. Binnema 8ff7306d90 mu4e: set context before check requirements
So we won't ask about creating default maildirs
2020-02-10 18:08:34 +02:00
Dirk-Jan C. Binnema d90d2ce8ef mu/mu4e: pass muhome to server (and provide some better error info) 2020-02-10 18:07:54 +02:00
Julien Masson c4ccaf0fdb mu: sort childs of thread based on the sortfield only
Today when we query a find cmd with the `--threads` option, all the
childs of each thread are sorted according to their leader based on
the sortfield.

This patch change the way of how the childs of a thread are sorted.
The threads are still sorted according to their leader but all the
childs of each thread are now sorted based on the sortfield only.

Here is an example of what happened with the previous sorting:

Example with random kernel thread sorted by date:

[PATCH 0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init
  ┣━▶[PATCH 1/4] MAINTAINERS: Add Purism mail alias as reviewer for their devkit's panel
  ┣━▶[PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant
  ┣━▶[PATCH 3/4] dt-bindings: display/panel: jh057n0090: Document power supply properties
  ┗━▶[PATCH 4/4] drm/panel: jh057n0090: Add regulator support

If someone reply to one of these emails in the middle, this email
become the leader and the thread is displayed like this:

[PATCH 0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init
  ┣━▶[PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant
  ┃  ┗━▶ Re: [PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant
  ┣━▶[PATCH 1/4] MAINTAINERS: Add Purism mail alias as reviewer for their devkit's panel
  ┣━▶[PATCH 3/4] dt-bindings: display/panel: jh057n0090: Document power supply properties
  ┗━▶[PATCH 4/4] drm/panel: jh057n0090: Add regulator support

With this patch, we will have the following output:

[PATCH 0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init
  ┣━▶[PATCH 1/4] MAINTAINERS: Add Purism mail alias as reviewer for their devkit's panel
  ┣━▶[PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant
  ┃  ┗━▶ Re: [PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant
  ┣━▶[PATCH 3/4] dt-bindings: display/panel: jh057n0090: Document power supply properties
  ┗━▶[PATCH 4/4] drm/panel: jh057n0090: Add regulator support

The tests cases concerning threads have also been updated.

Signed-off-by: Julien Masson <massonju.eseo@gmail.com>
2020-02-10 15:42:39 +01:00
Dirk-Jan C. Binnema f50360f94e mu-store: implement Store::find_message 2020-02-10 01:00:42 +02:00
Dirk-Jan C. Binnema 24932c12b7 remove some dead code 2020-02-10 01:00:01 +02:00
Dirk-Jan C. Binnema 36b31eeb0a mu: check --maildir parameter for init
Fixes #1568.
2020-02-09 22:40:57 +02:00
Dirk-Jan C. Binnema 85df5524f3 server: fix typo 2020-02-09 18:07:30 +02:00
Dirk-Jan C. Binnema 0b1e6b623e mu4e-context: fix some compiler warnings 2020-02-09 18:07:09 +02:00
Dirk-Jan C. Binnema dd140cb98a mu4e-headers: With gnus-view, avoid server calls
We can do it directly, since we only need the path to the message.
2020-02-09 18:06:04 +02:00
Dirk-Jan C. Binnema 876f70d50d mu: update unit tests
They need to use 'mu init' as well.
2020-02-09 18:01:06 +02:00
Dirk-Jan C. Binnema 451309697d server: 'sent' does not use 'maildir' anymore
So don't require it.
2020-02-09 15:07:22 +02:00
Dirk-Jan C. Binnema 00df8ce471 mu4e: headers: Fix some compiler warnings 2020-02-09 03:53:01 +02:00
Dirk-Jan C. Binnema 0c6719eb96 NEWS.org: update documentation 2020-02-09 03:53:01 +02:00
Dirk-Jan C. Binnema 0d9d99df99 Merge pull request #1328 from pitti/fix-whitespace-deletion
mu4e: restrict deleting trailing whitespace to region
2020-02-09 00:24:32 +02:00
Dirk-Jan C. Binnema be706fdfdd Merge pull request #1567 from Chris00/master
Allow icalendar replies to automatically be signed
2020-02-09 00:18:03 +02:00
Dirk-Jan C. Binnema defebdce2f configure.ac: bump version 1.3.8 2020-02-09 00:15:49 +02:00
Dirk-Jan C. Binnema 4e5f6b4b0a mu: make command output more useful 2020-02-09 00:15:49 +02:00
Dirk-Jan C. Binnema e1e26d1da2 mu4e: update to use server maildir/database/addresses
Mkae mu4e-maildir and mu4e-personal-addresses obsolete, we get those
from the server.
2020-02-09 00:15:49 +02:00
Dirk-Jan C. Binnema dea4789e0e server: pass root-maildir, personal-addresses, dbpath to mu4e
Tell mu4e about the parameters, so users do not need to explicitly set
them.
2020-02-09 00:15:49 +02:00