Commit Graph

4631 Commits

Author SHA1 Message Date
Cheong Yiu Fung e0f7c4b05e org-mu4e: fix org-mu4e-store-and-capture for Org 9.0
As discussed in #947, links need to be redefined for Org 9. This is
fixed in
[b885dd3](b885dd308e). At
the same time, `org-mu4e-store-and-capture` is still using
`org-mu4e-store-link` only, so it doesn't work in Org 9. Fix it
by interactively calling `org-store-link` instead.
2018-09-21 11:55:58 +08:00
djcb f8a5daa666 gnus: handle more non-ascii
Fix character decoding issues for some (but not all) messages. This to
Chris00 for this work on this!
2018-09-02 16:43:06 +03:00
djcb 665e8e5436 mu4e: mention gmime-3.0 in instructions 2018-09-01 10:25:48 +03:00
djcb e8d7ae82e6 update mu manpage 2018-09-01 10:20:07 +03:00
djcb 16fa5d9a22 server: maybe mark updates with :maybe-view
Don't updates messages when it's not needed, but don't use :view, since
it confuses mu4e's handlers.
2018-08-18 11:40:16 +03:00
Eric Danan 6fd6d839d7 mu4e: fix action to show thread for single-window mode
When in single-window mode and invoking `mu4e-action-show-thread` from
the view buffer, stay in the headers buffer rather than going back to
the view buffer.
2018-08-18 10:59:17 +03:00
djcb aa70bf1920 Merge branch 'pr-1111'
Fix a bunch of conflicts, tests.
2018-08-18 10:29:40 +03:00
djcb c5a17a9699 mu: make attachment size tests a bit more lenient (for gmime-3.0)
Or we won't pass. Not sure what exactly explains the 2-byte diff.
2018-08-18 10:05:31 +03:00
djcb 84fce77d0a org-mu4e: small cleanups 2018-08-18 08:57:18 +03:00
Dirk-Jan C. Binnema 35d9c60a40
Merge pull request #1290 from ericdanan/org-mu4e
org-mu4e: move mu4e requirement inside org-mu4e-open
2018-08-18 08:54:17 +03:00
djcb 1d0b24afcf mu4e: activate mode before getting attachments/links
So the relevant hash-maps are valid (they would be nillified by changing
the mode otherwise).
2018-08-16 22:48:20 +03:00
Dirk-Jan C. Binnema 16619cb9a1
Merge pull request #1273 from peterwvj/patch-1
Add Ubuntu dependency
2018-08-15 08:16:23 +03:00
Dirk-Jan C. Binnema dbdf68040a
Merge pull request #1297 from aluaces/patch-1
mu4e: Tiny fix in documentation
2018-08-15 08:15:04 +03:00
djcb aafeb82a6e mu: decode rfc-2047-encoded mailing lists
Fixes #1292.

Note: does require rebuilding the mu database (--rebuild).
2018-08-14 22:38:27 +03:00
djcb abf02000ec mu4e: clean up mu4e~view-internal a bit 2018-08-14 22:20:32 +03:00
djcb 82e7d7c65d mu: better handle updating mail being viewed
instead of the the 'noupdate', add 'noview', so the headers still get
update but we don't render unread mail twice.
2018-08-14 21:59:41 +03:00
djcb 93c6ff1f85 mu: protect against overly long keys
We got some errors when some of the key values exceeded the Xapian
maximum; in particular the message-id.

So make all the key-methods check, and truncate the message-id if
necessary.
2018-08-14 21:57:33 +03:00
djcb a4398ac93d mu4e/mu: optimize mark-as-read
Since cd649efb6b, opening an unread message first does a proc-move,
then proc-view.

Reason is that while we get the (:update ... ) from the move, that only
contains a skeleton message; we need the full view get images etc. This
means that we render the message _twice_.

Here we change add a flag for move to _not_ send the (:update ..), so
only the (:view ...) will trigger rendering of the message.
2018-08-12 14:00:59 +03:00
djcb 6e646ea794 mu4e: add webrtc to mailing-lists 2018-08-12 14:00:59 +03:00
Alberto Luaces 8219a9e748
Tiny fix in documentation 2018-08-11 19:32:25 +02:00
djcb 58492f8217 mu4e: Better handle context-switching in speedbar
Repaint the contents when the context changes
2018-07-14 11:32:57 +03:00
Eric Danan 268b888226 org-mu4e: move mu4e requirement inside org-mu4e-open
This allows to defer loading mu4e. That is, if we simply put in our
init file:

(with-eval-after-load 'org
  (require 'org-mu4e))

then mu4e is only loaded if either we follow a mu4e link from an org
buffer or we call the autoloaded function `mu4e` to read our emails.

Storing org-mode links from mu4e buffers is unaffected by this change
since `org-mu4e-store-link` only applies from mu4e buffers.

Regarding the second, experimental part of org-mu4e.el about editing
mails with org-mode, I am not completely sure but I think it should
also be unaffected since it also seems to only apply from mu4e buffers.
2018-07-13 14:53:37 +02:00
Dirk-Jan C. Binnema 4807461dbe
Merge pull request #1151 from gilbertw1/fix-mark-headers-region
mu4e: Fix region bounds checking when marking headers in mu4e
2018-07-11 21:35:57 +03:00
Nicolas Avrutin eb9bfbb1ca Perform threading calculation on related set instead of entire result.
The current threading algorithm is applied to the entire result of a query, even
if maxnum is specified, and then the result of the threading algorithm is
truncated to maxnum. The improves threading results by returning the entire
thread even when only a single message makes it into the top maxnum results.

This commit applies the threading algorithm to the related message set of the
maxnum-truncated query result instead of to the entire query result. For a given
set of messages, the set of messages which will share threads with any of the
original messages is exactly the related message sets. Put another way, either
any messages returned by the original query but removed by the maxnum truncation
will also be returned by the related message query, or they would not have been
needed anyway because they would not be members of any visible thread.

To maintain backward compatibility and allow threading to be used without
including related messages, the related message set is found for the threading
calculation, but any messages which would not have matched the original query
are then pruned, resulting in a superset of the truncated query, but a subset of
the untruncated query.

This does not improve (or degrade) the run time of a threading calculation when
maxnum is not set, but significant improves it when maxnum is set by making it
scale (roughly) linearly in terms of maxnum. On a maildir with ~200k messages
and maxnum set to 500 (the default), the run time of a threading calculation is
lowered from ~1m to ~0.1s.

Perform threading calculation on related set instead of entire result.

The current threading algorithm is applied to the entire result of a query, even
if maxnum is specified, and then the result of the threading algorithm is
truncated to maxnum. The improves threading results by returning the entire
thread even when only a single message makes it into the top maxnum results.

This commit applies the threading algorithm to the related message set of the
maxnum-truncated query result instead of to the entire query result. For a given
set of messages, the set of messages which will share threads with any of the
original messages is exactly the related message sets. Put another way, either
any messages returned by the original query but removed by the maxnum truncation
will also be returned by the related message query, or they would not have been
needed anyway because they would not be members of any visible thread.

To maintain backward compatibility and allow threading to be used without
including related messages, the related message set is found for the threading
calculation, but any messages which would not have matched the original query
are then pruned, resulting in a superset of the truncated query, but a subset of
the untruncated query.

This does not improve (or degrade) the run time of a threading calculation when
maxnum is not set, but significant improves it when maxnum is set by making it
scale (roughly) linearly in terms of maxnum. On a maildir with ~200k messages
and maxnum set to 500 (the default), the run time of a threading calculation is
lowered from ~1m to ~0.1s.
2018-07-09 02:41:22 -04:00
djcb 4f6fd873fa mu4e: cleanup handler functions 2018-06-30 21:14:00 +03:00
djcb 5f45e014df mu4e: use defvar for handler functions
This allows for a little easier *overriding* them.
2018-06-29 21:33:43 +03:00
djcb 1cb3cbc94d mu4e: fix bbdb doc 2018-06-29 18:08:43 +03:00
Peter W. V. Tran-Jørgensen f25a4c141e
Add Ubuntu dependency
Had to install libtool. I'm on Ubuntu 18.04
2018-06-22 20:22:24 +02:00
djcb 5ccd261771 mu4e: speedbar: use the correct buffer 2018-06-14 11:19:50 +03:00
djcb d106e0e03b mu4e-view: ensure buffer is named *Article* (gnus mode)
Some of the gnus internal code depends on that.
2018-06-13 22:24:47 +03:00
djcb 9bf1670aa1 mu4e: work-around for missing contacts 2018-06-13 18:19:13 +03:00
djcb acb68f5551 mu4e: disable some keybindings for the gnus backend 2018-06-13 16:58:41 +03:00
djcb d98e78548c mu4e: re-draw speedbar when context changes
Folders may have changed.
2018-06-13 14:48:22 +03:00
djcb 0140d433a1 mu4e: update documentation 2018-06-13 13:22:47 +03:00
djcb 36ce14e705 mu4e: view/gnus: support verifying signed mails
Hook up with gnus' verification for signed mails.
2018-06-13 13:22:47 +03:00
Dirk-Jan C. Binnema 4fb5d11d9f
Merge pull request #1243 from avar/render-urls-with-space-before-number
mu4e: view: render URLs as "<url> [%d]" not "<url>[%d]"
2018-06-12 09:23:14 +03:00
Ævar Arnfjörð Bjarmason 6c8aec38be view: render URLs as "<url><zwp>[%d]" not "<url>[%d]"
When we render URLs like https://gnu.org/[1] right-clicking on them in
e.g. GNOME Terminal will also copy the "[1]" as well as the URL,
inserting zero-width-space[1] between the two avoids this.

I know about "g" (mu4e-view-go-to-url), but sometimes I want to open a
URL in a different browser, or copy it into a non-Emacs program. This
makes that easier. I think this improves the UI at a very trivial cost
to users that don't care about this use-case.

I could make this configurable, but unless someone vehemently objects
to this I don't see the point of not just making it the default.

In GNOME Terminal a ZWS is rendered simply as a space, and
copy/pasting works as expected, but in Emacs's GTK GUI there's no
space between the two.

This was initially a plain ASCII space character, but djcb preferred a
ZWP, and this works as well.

1. https://en.wikipedia.org/wiki/Zero-width_space
2018-06-11 22:10:56 +02:00
djcb 8aa6558579 guile: require guile 2.2
Drop support for guile2.0 -- mostly because it's installation is
different enough between distros that it seems a bit too much work to
keep both that and guile2.2 working.
2018-06-11 13:10:29 +03:00
djcb 99df588d41 update compiler warnings, fix them
Update the compiler warnings, and fix all the ones outside the guile/.
2018-06-11 10:49:07 +03:00
djcb dcaad0e473 guile: fix tests
Ensure we have a valid $GUILE_BINARY in the tests.
2018-06-11 10:10:49 +03:00
djcb 2d954e9647 mu: fix strncpy usage
Ensure the resulting strings are \0-terminated.
2018-06-11 09:18:27 +03:00
djcb 088064d5e1 mu4e: define the view-mode when needed
Define the view-mode (gnus or internal) just before it's needed. This
ensures that (when in gnus mode) it's really a gnus-article-mode
derivative, so more of the gnus specifics work.
2018-06-08 10:01:55 +03:00
djcb ee6e91da9b mu4e: auto decode quoted-printable, base64 (gnus)
Set things up so gnus article mode decodes base64 and quoted-printable
messages automatically.

Don't try to set up URL links.
2018-06-07 13:13:37 +03:00
djcb 67eea5fadd guile: add some more m4 for guile detection
We need a few more m4 macros for guile.m4 to work. Hope this is enough.
2018-06-05 17:49:30 +03:00
djcb d01bdfa7b4 mu4e: add decoding support for gnus' article-mode
Decode Gnu's articles as expected; thanks to Lars Ingebrigtsen for his
advice.
2018-06-05 17:42:09 +03:00
djcb cef25610e2 build: include lib-link.m4
This is provided by gnu-lib, but needed for the Guile build.
2018-05-31 21:35:27 +03:00
Dirk-Jan C. Binnema a3c1058654
Merge pull request #1242 from stsquad/patch-application-updates
mu4e: Patch application updates
2018-05-29 11:14:43 +03:00
djcb 143c0d1468 build: add dummy config.rpath
This seems to be necessary for the Guile/autotools machinery to work.
2018-05-29 10:59:20 +03:00
djcb 676589b30a perl: disable build
the perl build is not being used, and is a bit of a pain to maintain.
So, we disable it for now; and remove it at some point in the future.
2018-05-28 13:55:16 +03:00
djcb d8db74d422 build: rework guile setup
Use an update guile.m4; it seems different systems (Fedora, arch,
gentoo, ...) have guile installed under different names. Try to handle
all of those.

For this, we include the upstream guile.m4 and add support for
guile-snarf.
2018-05-28 13:22:13 +03:00