Commit Graph

269 Commits

Author SHA1 Message Date
Joseph Turner f00ca68c67 mu4e-compose: Don't nest pcase 2024-04-24 13:50:40 -04:00
Joseph Turner 4d923b6bbc mu4e-compose: fix when mu4e-sent-messages-behavior is functional
This commits fixes a regression introduced in
85bfe76336 , at which point sent mails ended up in
the "cur/" subdirectory of the root maildir when the mu4e-sent-messages-behavior
user option was set to a function.
2024-04-24 13:50:40 -04:00
Dirk-Jan C. Binnema 6349091061 mu4e-compose: don't interfere with non-mu4e completion
When enabled, attempt mu4e's auto-completion the first in line (in
completion-at-point-functions); but don't remove any other completions
the user may have set up.

Fixes #2697.
2024-04-23 11:46:00 +03:00
Dirk-Jan C. Binnema 4f72e2656d mu4e: use message-field-value
Simplify

...instead of
save-restriction/message-narrow-to-headers/message-fetch-field.
2024-04-20 11:44:22 +03:00
Dirk-Jan C. Binnema a3e1293c4c mu4e-compose: bring make mu4e--fake-pop-to-buffer
All but the default mu4e-compose-switch depend on this.
2024-04-15 08:34:32 +03:00
Dirk-Jan C. Binnema 9f476295e1 mu4e-compose: rework message-sent-hook
Grab the Fcc in the hook (when available).
2024-04-14 10:41:17 +03:00
Dirk-Jan C. Binnema d3e7b9cf05 mu4e-compose: handle no-fcc-path in sent-hook
Workaround for #2688.
2024-04-13 13:08:05 +03:00
Dirk-Jan C. Binnema faade24945 mu4e-compose: kill fcc buffer after sending
There's a buried buffer for the fcc file... not quite sure why, but
let's kill it after we've sent the message.

Fixes #2681.
2024-04-11 20:02:01 +03:00
Dirk-Jan C. Binnema 8c29ed56ce mu4e-compose: use find-file-noselect for edit
Oops! This was missing for #2644
2024-04-10 22:57:10 +03:00
Dirk-Jan C. Binnema 9a1b30b47e mu4e-compose: update message sending
We no longer need the 'sent' handling; we can do it directly in
mu4e-compose, which simplifies things.
2024-04-10 21:47:04 +03:00
Dirk-Jan C. Binnema eda8db0c3b mu4e-compose: simplify buffer creation
Seems we can avoid the advising of message-pop-to-buffer.
2024-04-10 21:47:04 +03:00
Dirk-Jan C. Binnema 1aad948293 mu4e-compose: avoid find-file
Use find-file-noselect instead.

Fixes #2644
2024-04-10 21:47:04 +03:00
Dirk-Jan C. Binnema be63bf2f80 mu4e-compose: use narrow-to-header before fetch 2024-04-05 23:47:25 +03:00
Dirk-Jan C. Binnema 2ebdf23dd0 mu4e-compose: explicitly remove Date: before update
Seems older emacsen require that or they won't update the Date, see
issue #2502.
2024-04-04 21:30:08 +03:00
Dirk-Jan C. Binnema 2e40852abc mu4e-compose: turn off message-completion-function
It interferes with mu4e's completion.
2024-04-02 07:39:28 +03:00
Dirk-Jan C. Binnema 5bd0750bce mu4e-compose: split out mu4e-complete-contact
Add a separate public function mu4e-complete-contact which can be used
anywhere (with completion-at-point-functions); and use
mu4e-compose-complete-contact-field in mu4e composition buffers.

Document this as well.
2024-04-02 07:24:56 +03:00
Dirk-Jan C. Binnema ecca83528c mu4e-compose: rework mu4e-compose-goto-(bottom|top)
For backward compat.
2024-03-15 20:33:23 +02:00
Dirk-Jan C. Binnema 4564db845a mu4e-compose: avoid byte-compile warnings on older emacsen 2024-03-15 19:48:25 +02:00
Dirk-Jan C. Binnema 2929a82246 mu4e-helpers: add mu4e-keymap-set, fix warnings
keymap-set only appeared in Emacs 29, so add a stand-in for now.

Fix some flymake warnings.
2024-03-14 13:41:56 +02:00
Dirk-Jan C. Binnema 6d9cf64286 mu4e-compose: copy message-reply-headers to fake buffer
We need copy the buffer-local value from _another_ buffer

HT: Martin R. Albrecht.
2024-03-13 07:34:19 +02:00
Dirk-Jan C. Binnema 0e05ab8c1d mu4e-compose: only use keymap-set when available
Was added with emacs 29.
2024-03-12 20:46:34 +02:00
Dirk-Jan C. Binnema c45bdca83b mu4e-compose: restore mu4e-compose-goto-(bottom|top)
Bring back from 1.10.
2024-03-12 12:29:37 +02:00
Dirk-Jan C. Binnema d9390159bb mu4e-compose: bring back mu4e-compose-context-switch
This is the version from 1.10.x that does not change the draft folder.
2024-03-04 16:59:01 +02:00
Dirk-Jan C. Binnema 2423c38d98 mu4e-compose: bring back mu4e-compose-attach-captured-message
It went missing after the compose refactoring.

Fixes #2654.
2024-03-04 16:59:01 +02:00
Dirk-Jan C. Binnema 4cac4a415c
Merge pull request #2657 from rrudakov/fix/2656-cite-reply-position
Respect `message-cite-reply-position` customization
2024-03-04 16:58:36 +02:00
Roman Rudakov f779e30dda
[#2656] Respect `message-cite-reply-position` customization 2024-03-04 15:15:50 +01:00
Roman Rudakov 8c8abe5a23
Fix typo 2024-03-04 11:09:56 +01:00
Dirk-Jan C. Binnema e28c2487d3 mu4e-compose: return new buffer from mu4e--compose-setup
I.e, and this applies to all mu4e-compose-* composition functions as
well.

Fixes #2653.
2024-03-03 09:44:30 +02:00
Dirk-Jan C. Binnema 20878c8725 mu4e-compose: tweak buffer handler, add display-buffer
Add 'display-buffer as an option for mu4e-compose-switch, which lets you
use the display-buffer function for display.

Remove the mu4e-message-kill-buffer, simply use message-kill-buffer.
2024-03-02 23:23:52 +02:00
Dirk-Jan C. Binnema 91eb777946 mu4e-compose: try to avoid buffer/frame mishaps
... when closing a message. Should hopefully be a bit less bad than
before.
2024-02-18 18:02:54 +02:00
Dirk-Jan C. Binnema cbd6353058 mu4e-compose: don't attempt deleting frames for now
This needs some more work, so don't try to delete frames for now, which
is better than the alternative.
2023-12-15 12:46:44 +02:00
Dirk-Jan C. Binnema 65e7e7f42d mu4e-compose: be less eager deleting frames
We were deleting frames if it was not the last one; however, emacs can
have a bunch of hidden frames (for tooltips?) that we should not
consider.
2023-12-14 21:38:15 +02:00
Dirk-Jan C. Binnema 526d49f70c mu4e-compose: attempt to delete frame after done with composition
Attempt to delete the frame when
a) it's not the last frame, and
b) there's only a single window on the frame

Fixes #2577
2023-12-04 19:25:55 +02:00
Dirk-Jan C. Binnema 730bd13ea2 mu4e-compose: ensure we switch to composition buffer
When we're done with the setup.

Fixes #2605.
2023-12-02 17:45:51 +02:00
Dirk-Jan C. Binnema d488ab2641 mu4e-compose: combine mu4e-compose-new and mu4e-compose-mail
No need for duplication.
2023-12-02 17:45:51 +02:00
Dirk-Jan C. Binnema 4ea450c29f mu4e: update documentation 2023-12-01 19:11:56 +02:00
Dirk-Jan C. Binnema 149ec143ba mu4e-compose: remove crs from message when decoding
This fixes e.g. forwarding for some mesasges that contain CRs.
2023-12-01 19:11:56 +02:00
Dirk-Jan C. Binnema 18efe9a955 mu4e-compose: improve mu4e-message-kill-buffer
Try to go back to the buffer we were in before. HT: @thierryvolpiatto

Fixes #2600.
2023-11-30 22:16:04 +02:00
Dirk-Jan C. Binnema f3606c0352 mu4e-compose: rework message handling
A number of change in message composition:

Clean up some of the handling function, in particular, only include
headers in mu4e--decoded-message when that is all that's needed.

When forwarding messages, make sure message-reply-headers is filled with
the values for the to-be-forwarded message so the references etc. get
filled correctly.

Fixes #2603
2023-11-30 22:14:36 +02:00
Nicholas Vollmer 4ab0ae5565 mu4e-compose-reply: account for nil REPLY-TYPE in assertion
Previous assertion would fail when REPLY-TYPE is nil, but nil is a valid value
for the argument.

See: https://github.com/djcb/mu/issues/2601
2023-11-22 16:10:08 -05:00
Dirk-Jan C. Binnema 087d06c5d3 mu4e-compose: implement mu4e-compose-supersede
Hook up `message-supersede` which you can /supersede/ your own messages;
that is, send the message as kind-of reply to the same recipients. This
only works if you were the sender.

This should help for #2584.
2023-11-22 21:41:02 +02:00
Dirk-Jan C. Binnema 1936d4eec3 mu4e-compose: ensure message-mail-user-agent is nil
Unbreak some user setups

Fixes #2596.
2023-11-15 15:52:58 +02:00
Christophe Troestler 8d8a5a9844 mu4e-compose-mail: fix the number of parameters of the closure 2023-11-12 21:09:24 +01:00
Dirk-Jan C. Binnema a720c9cb1c mu4e-compose: split citing / header extraction
We use a body from mu4e-view-message-text for citing, and
mu4e--decoded-message for header extraction.

There's room for some refactoring.
2023-11-10 16:47:34 +02:00
Dirk-Jan C. Binnema 171fe9a018 mu4e-compose: add missing arg to mu4e-compose-new lambda 2023-11-08 18:18:47 +02:00
Dirk-Jan C. Binnema 30a78d3cb9 mu4e-compose: use raw message for "forward"
Not the decoded one.
2023-11-08 15:33:47 +02:00
Christophe Troestler 0941b37fcc Fix mu4e-compose-mail 2023-11-08 10:00:16 +01:00
Dirk-Jan C. Binnema ea7c05c183 mu4e-compose: implement mu4e--decoded-message
Instead of mu4e-view-message-text, use a more targeted approach that
does just enough to get a decoded message with all the headers, which we
can use for replying.
2023-11-07 16:40:09 +02:00
Dirk-Jan C. Binnema 556396bb85 mu4e-compose: explicitly generate-headers
Ongoing troubles with this, and apparently some differences between
Emacs versions (?).

Explicitly generated the needed headers.
2023-11-05 16:47:08 +02:00
Dirk-Jan C. Binnema a551aaa694 mu4e-compose: rework header insertion
Clean up the composition pipeline a bit, and set
message-generate-headers-first explicitly.

Hide headers later.
2023-11-04 23:38:02 +02:00