Commit Graph

355 Commits

Author SHA1 Message Date
Dirk-Jan C. Binnema b1b11eb0cb
Merge pull request #2395 from bjcohen/bjcohen/fix-split-view-single-window-nil
mu4e-view: don't delete window on view msg in single-window mode
2023-01-04 00:26:50 +02:00
Ben Cohen bade0d52fb mu4e-view: don't delete window on view msg in single-window mode 2023-01-02 16:29:36 -05:00
Dirk-Jan C. Binnema b7b97212ce mu4e: move search functionality to mu4e-search
Move out of mu4e-headers; rename variables and callers.
2023-01-01 15:01:08 +02:00
Dirk-Jan C. Binnema 155d7be1d4 mu4e-view: "detach" headers view when quitting in single-window mode
Otherwise the headers view seems to get confused (thinking it is still
showing a message).
2022-12-28 20:59:20 +02:00
Dirk-Jan C. Binnema fe88890419 mu4e-view: update mu4e-view-fields
Remove obsolete fields; update docstring.
2022-12-24 15:28:46 +02:00
Dirk-Jan C. Binnema 1799c69451 mu4e-view: rename mu4e~view -> mu4e--view
Our long-running migration from mu4e~ -> mu4e-- takes another step.
2022-12-24 10:02:21 +02:00
Dirk-Jan C. Binnema 3568e6784a mu4e~view-in-headers-context: don't display buffer
Displaying the buffer doesn't look very nice in single-window mode.
2022-12-19 23:24:40 +02:00
Dirk-Jan C. Binnema fcda5dcc5f mu4e-view: Re-add mu4e-view-quit
Add special handling for single-window/other for view buffer quitting

Fixes #2386.
2022-12-19 23:00:49 +02:00
Dirk-Jan C. Binnema 34815a1961 mu4e: use mu4e-view-rendered-hook
Instead of the older mu4e-after-view-message-hook; update version where
it go obsolete.
2022-12-15 11:52:50 +02:00
Dirk-Jan C. Binnema 83ed407dbc mu4e-view: use kill-buffer-and-window
...for the last remaining mu4e~view-quit-buffer.

Fixes issue #2381
2022-12-15 11:47:12 +02:00
Dirk-Jan C. Binnema 56d8f4cd25 mu4e: rename mu4e-after-view-message-hook into mu4e-view-rendered-hook
For consistency.
2022-12-15 00:05:26 +02:00
Dirk-Jan C. Binnema 00d3e9208d mu4e-view: whitespace fixes 2022-12-15 00:05:11 +02:00
Tassilo Horn cbeed9ef28 bug-reference: Add clarifying comment / checked-headers as variable 2022-12-14 18:34:24 +01:00
Dirk-Jan C. Binnema fdbf912e06 mu4e-view: use kill-buffer-and-window for quitting
That restores the classic mu4e style. I.e.,

With default settings, e.g.

    case 1: - (1)go to inbox -> (2)see headers -> (3)open message ->
    window splits -> (4)read message -> (5)'q' . Window closes and we're
    back to (2). All good!

The more complicated step is

    case 2: (4) read message -> (5) reply to message -> (6) done
    replying -> back to (4) but for some reason when pressing 'q' now,
    the window is not closed, but replaced by the headers window (so we
    have 2 now. [ I think it should behave just like in case 1 ]

This fixes that.
2022-12-13 23:50:38 +02:00
Dirk-Jan C. Binnema 9ae567f5f5 mu4e-view: whitespace cleanup 2022-12-13 23:49:57 +02:00
Dirk-Jan C. Binnema 85f60647b9 mu4e-view: bind 'P' to mu4e-headers-toggle-property
And remove the obsolete older mu4e-headers-toggle-*.
2022-12-11 13:54:57 +02:00
Dirk-Jan C. Binnema ff9fc73e5a mu4e-view: whitespace/newline fixes 2022-12-11 13:31:13 +02:00
Mickey Petersen 8ac172cd08 Resize headers window after displaying a message 2022-12-03 17:13:20 +00:00
Mickey Petersen d43c0030e3 Ensure the linked headers buffer state is not lost 2022-12-03 17:13:20 +00:00
Mickey Petersen 32aefe508f Correct documentation 2022-12-03 17:13:20 +00:00
Mickey Petersen 37e8328975 mu4e-loading-mode is now a minor mode 2022-12-03 17:13:20 +00:00
Mickey Petersen 514b921813 Render with current buffer set to the view 2022-12-01 07:34:22 +00:00
Mickey Petersen 3b44ad9514 Ensure the windows belonging to the now-defunct view buffer are destroyed 2022-11-30 15:33:41 +00:00
Mickey Petersen d6c67a401d Check for detached view in the navigation context macro 2022-11-30 15:33:07 +00:00
Mickey Petersen 69a17bfcb9 Multiple buffer support and standardised window and buffer handling 2022-11-29 11:33:07 +00:00
Aleksei Atavin 0f097e00c6
mu4e: temporary reset browse-url-handlers in view in xwidget action
If `browse-url-handlers` is set `mu4e-action-view-in-xwidget` function
tries to open url in the handler first instead of xwidget. This is
happening because `browse-url` first checks `browse-url-handlers` and
`browse-url-browser-function` after.

Signed-off-by: Aleksei Atavin <axeoman@gmail.com>
2022-10-28 22:52:16 +03:00
Dirk-Jan C. Binnema 7f0497638c
Merge pull request #2329 from seanfarley/smf/save-excursion-html
mu4e-view: use `save-excursion' around toggling html
2022-09-08 07:04:04 +03:00
Sean Farley 243b862776 mu4e-view: use `save-excursion' around toggling html
Previously, the cursor would be moved to the first html attachment which
would break using mu4e keybindings (e.g. delete). With this change, the
cursor isn't moved at all, presumably the expected behavior.
2022-09-03 17:01:41 -05:00
Dirk-Jan C. Binnema 68753f9e84 mu4e: move all obsolete aliases to mu4e-obsolete
Unclutter the rest of the code a bit.
2022-08-20 14:24:24 +03:00
Dirk-Jan C. Binnema 46476fc001 mu4e: add mu4e-copy-thing-at-point
Copy the thing (url or email) at point, similar to the feature in the
pre-gnus view. Bind to 'c' in the message-view.
2022-07-13 23:35:16 +03:00
Dirk-Jan C. Binnema 7b83605019 mu4e-view: fix naming of temp files 2022-06-07 23:06:33 +03:00
Dirk-Jan C. Binnema 59022e066d mu4e: revamp emacs bookmark support
The support for emacs in bookmarks in mu4e-contrib has been broken for a while;
we removed it an now re-implement it as part of mu4e-proper.

Fixes: issue #2255.
2022-05-29 12:31:39 +03:00
Dirk-Jan C. Binnema a1f0c5e9eb mu4e: fix emacs-29 bytecompiler warnings
Wrong single quotes.
2022-05-28 00:51:08 +03:00
Dirk-Jan C. Binnema aea2f58c77 mu4e: add command mu4e-sexp-at-point
Add command ~mu4e-sexp-at-point~ for showing/hiding the s-expression for the
message-at-point. Useful for development / debugging. Bound to ~,~ in headers and
view mode.
2022-05-14 20:45:33 +03:00
Tassilo Horn 34fe094561 Simplify mu4e-view-mode-map creation and fix `-` binding
`mu4e-view-mode-map` was initialized from a sparse keymap and eventually passed
to `suppress-keymap` in order to remove bindings to `self-insert-command` which
obviously make no sense in read-only buffers.  However, `suppress-keymap` also
remaps all digits and the minus sign to make prefix args, i.e., pressing 8
would be equal to `C-u 8` and `-` got bound to `negative-argument` instead of
`mu4e-view-mark-for-unflag` as defined.

While `suppress-keymap` has a `NODIGITS` arg to suppress the rebinding of
digits and minus sign (which would also mean that pressing a digit would try
inserting that digit and lead to an error), I chose the more straight-forward
solution and start from an empty rather than a sparse keymap and added the
`digit-argument` bindings for 0..9 explicitly.
2022-05-11 21:08:47 +02:00
Dirk-Jan C. Binnema 48311ea18d mu/mu4e: tweak :list vs :mailing list 2022-05-07 20:48:21 +03:00
Tassilo Horn 0baa735f18 Allow a function as mu4e-view-open-program 2022-04-29 14:03:05 +02:00
Dirk-Jan C. Binnema 20568cba70 mu4e-view: open tmp files read-only
When using the "open-in-emacs" handler, open the temp file as read-only. It's a
temp file, so editing isn't very useful.
2022-01-24 19:00:19 +02:00
Dirk-Jan C. Binnema a4707afe12 mu4e: cleanups and flycheck fixes
- Remove some unused faces
- Fix some flycheck warnings
- Replace some `cl-` functions with `pcase` and `seq`
2022-01-23 14:27:00 +02:00
Dirk-Jan C. Binnema e5ead56b2a mu4e-view: fix flycheck warnings
Let's make things clean.
2022-01-15 12:00:27 +02:00
Dirk-Jan C. Binnema 904214ba17 mu4e-view: double-check message file exists
So we can warn user early.
2022-01-15 10:20:32 +02:00
Dirk-Jan C. Binnema b072b4a57e mu4e-view: Add defcustom mu4e-view-open-program
When xdg-open is not enough.
2022-01-12 22:32:21 +02:00
Dirk-Jan C. Binnema 324b6f5022 mu4e-view: experiment xwidget support
Add experimental support for displaying html messages in an xwidget; this
doesn't work for all messages.
2022-01-10 22:07:06 +02:00
Dirk-Jan C. Binnema 42d5cde612 mu4e-view: catch epg error
Give a bit more user-feedback when e.g. EPG fails to decrypt a message.
2022-01-09 14:08:24 +02:00
Dirk-Jan C. Binnema bbf55256e5 mu4e-view: add massage toggle for text filling
For some mis-rendered messages, it can be useful to toggle filling, so add this
as an massage ('M') option.
2021-12-25 11:01:33 +02:00
Dirk-Jan C. Binnema 8dcdd0a815 mu4e-view: add toggle to show all mime-parts
Add a toggle to show (links for) all top-level MIME-parts, so you can e.g.
perform actions on 'inline' images.
2021-12-19 23:15:42 +02:00
Dirk-Jan C. Binnema 4a0490acbf
Merge pull request #2152 from progfolio/fix/osbolete-fn
mu4e-search-edit: Fix obsolete alias; update documentation
2021-10-13 14:47:48 +03:00
Dirk-Jan C. Binnema 5db8fdc49d mu4e: Do not defvar abbrev tables
I'm not quite sure why it was done in the first place, and it seems to have
unwanted side-effects. So let's turn it off and see if anything breaks.

Fixes: #2146.
2021-10-06 08:11:30 +03:00
Nicholas Vollmer baae737674 mu4e-search-edit: Fix obsolete alias; update documentation
Replace obsolete variable alias with obsolete function alias for mu4e-headers-search-edit.
Update docstring for mu4e-view-search-edit to reference the new function.
2021-10-03 10:33:49 -04:00
Thierry Volpiatto a6207d6d08
Reset `gnus-article-buffer` in mu4e-view
This is needed when gnus is used along mu4e for other purpose like
reading News, in this case gnus rename `gnus-article-buffer` and we
end up with an unrelated buffer-name in mu4e.
2021-09-30 16:56:46 +02:00