Commit Graph

215 Commits

Author SHA1 Message Date
Dirk-Jan C. Binnema 9f39d78a71 mu4e-compose: use decoded message for replying
Or From: etc. would use some undecoded version with some
=?iso-8859-1?Q?.... blobs.
2023-11-01 19:46:47 +02:00
Dirk-Jan C. Binnema b1587607e1 mu4e: obsolete some compose vars, update NEWS.org
We can re-use the existing implementations.
2023-10-31 19:45:17 +02:00
Dirk-Jan C. Binnema a696902c34 mu4e-compose: allow updating keymap for minor mode 2023-10-30 22:55:42 +02:00
Dirk-Jan C. Binnema eee73f8199 mu4e: better handle alternative address
In compose / contacts
2023-10-29 17:16:05 +02:00
Dirk-Jan C. Binnema 00191a3ec7 mu4e: improve mu4e-compose-dont-reply-to-self handling
Use mu4e-personal-or-alternative-address to decide on whether an address
belongs to "this user". Update docs.
2023-10-29 17:15:35 +02:00
Dirk-Jan C. Binnema 61c8067491 mu4e-compose: add in-reply-to when needed
Was missing.
2023-10-26 18:34:07 +03:00
Dirk-Jan C. Binnema 85bfe76336 mu4e-compose: overhaul message composer
This is a new composer sub-system, which more closely follows
Gnus/message; in particular, we let gnus take care of creating draft
messages.

This reduces code size and allows us to re-use some of the more advanced
features.

There are a number of user-visible changes:

- `mu4e-compose-resend' directly uses `message-resend', so there is no
  more editing phase (which used to be a bit broken with re-encoding
  MIME messages.
2023-10-25 22:05:06 +03:00
Dirk-Jan C. Binnema 8fc13ab8f3 mu4e: Shorten descriptions a bit 2023-09-20 22:31:19 +03:00
Thierry Volpiatto 67c8ff75a7 Fix missing or incorrect descriptions in file headers
Try to make useful descriptions and use conventional --- to separate filename
from description.
2023-09-20 22:04:48 +03:00
Dirk-Jan C. Binnema c9b64a0114 mu4e-compose: jit-start mu4e in mu4e-compose
Just in case it wasn't running yet.

Fixes #2526
2023-07-28 19:35:39 +03:00
Dirk-Jan C. Binnema 3b93863f15 mu4e: use mu4e-determine-attachment-dir
Make the old internal mu4e~get-attachment-dir a public function,
improve documentation. Update callers.
2023-07-16 13:19:35 +03:00
Dirk-Jan C. Binnema 551bc46b47 mu4e: improve emacs menu-bar items
Fixes issue #2406.
2023-01-09 22:13:24 +02:00
Dirk-Jan C. Binnema 1e018ee1fc mu4e: remove keybindings from mu4e-context-minor-mode
They interfered with the major modes (in particular the undefine hack
needed in mu4e-compose).

Fixes #2402.
2023-01-07 17:13:36 +02:00
Dirk-Jan C. Binnema 441c450004 mu4e-compose: whitespace fixes 2023-01-07 17:13:36 +02:00
Dirk-Jan C. Binnema 926083458d
Merge pull request #2380 from mickeynp/bugfix/re-add-missing-argument
Re-add missing argument as `define-mail-user-agent' expects it
2022-12-16 18:57:04 +02:00
Mickey Petersen cb364bc0c5 Attempt to delete the window after composing a message 2022-12-15 07:41:23 +00:00
Mickey Petersen af35314231 Rename to _switch-action 2022-12-15 07:38:46 +00:00
Mickey Petersen c3d962545d Re-add missing argument as `define-mail-user-agent' expects it 2022-12-14 20:00:42 +00:00
Mickey Petersen 42add64683 Appease the byte compiler and clean up the code 2022-12-06 09:46:39 +00:00
Mickey Petersen ef2c989e08 Clean up 2022-11-29 11:50:59 +00:00
Mickey Petersen 69a17bfcb9 Multiple buffer support and standardised window and buffer handling 2022-11-29 11:33:07 +00:00
Protesilaos Stavrou 8c42c43fd7
mu4e-compose: remove remap for unused face
The mu4e-cited-1-face does not exist any more, per commit
a4707afe12.
2022-08-27 05:51:16 +03:00
Protesilaos Stavrou 339d841415
mu4e-compose: simplify mu4e~compose-remap-faces 2022-08-27 05:29:56 +03:00
Dirk-Jan C. Binnema 18bf2d995d mu4e: Add mu4e-header-field-face, avoid mu-header-key-face cycle
By default, mu4e-header-key-face inherits from message-header-name; this
leads to warnings when we later remap the latter to the former in
mu4e-compose.el.

We don't want to change the definition of mu4e-header-key-face (it's
used widely in mu4e); so we add a new face mu4e-header-field-face
for *just* mu4e-compose and which does not inherit.

Fixes #2321.
2022-08-20 13:29:04 +03:00
Dirk-Jan C. Binnema 99eb3bb674 mu4e-compose: handle message-cite-reply-position later
Can't really repro the problem. Perhaps I don't have hidden heders?
Anyway, can't hurt to move it after that.

Fixes #2283.
2022-07-01 08:31:00 +03:00
Dirk-Jan C. Binnema ff8e0455dc mu4e-compose/compose-mail: add brackets for in-reply-to
Seems in some contexts we get them _without_ brackets in other-headers; so let's
fix that up.

Fixes #2273.
2022-06-14 23:48:43 +03:00
Dirk-Jan C. Binnema a1f0c5e9eb mu4e: fix emacs-29 bytecompiler warnings
Wrong single quotes.
2022-05-28 00:51:08 +03:00
Dirk-Jan C. Binnema db86e7b5ee mu4e: contacts: use mu4e--contacts-set
We use to have mu4e--contacts-hash, with name mapping to rank; that was
needlessly complicated since most completion engine sort alphabetically, making
the rank totally irrelevant (in practice, it doesn't matter much from the
end-user pov).

Anyway, simplify that part, maintain a set of contacts without any rank (which
what the server delivers now).

Also update the _default_ mu4e-contact-process-function to filter out anything
with 'reply' since it's not very useful for autocompletion.
2022-05-09 22:25:28 +03:00
Dirk-Jan C. Binnema 45aec819f6 mu4e: updates for core changes
Deal with (name . email) --> (:name "boo" :email "boo@example.com")
Add support for the new "changed" field.
2022-05-05 01:40:17 +03:00
Dirk-Jan C. Binnema a4707afe12 mu4e: cleanups and flycheck fixes
- Remove some unused faces
- Fix some flycheck warnings
- Replace some `cl-` functions with `pcase` and `seq`
2022-01-23 14:27:00 +02:00
Dirk-Jan C. Binnema dd3efb0b8b mu4e: update mu4e-compose-context-switch
Update mu4e-compose-context-switch:
1) attempt to update the message signature as well
2) remove the (no longer working) code to try to move the underlying file (which
   was a bit too fragile) (see issue: #2140)
2021-11-10 22:32:28 +02:00
Dirk-Jan C. Binnema 67b16acbb2 mu4e: support message-user-organization
Automatically include Organziation: if set and update when changing the context.

Fixes: issue #2112.
2021-11-07 12:50:16 +02:00
Dirk-Jan C. Binnema 90a748aba1 mu4e-compose: make undo work across compose saves
Hide the header-separator change from the user-visible undo.
2021-11-07 11:47:29 +02:00
Dirk-Jan C. Binnema 0303f5d931 mu4e: compose/draft: remove some mostly obsolete things
Avoid some compiler warnings.
2021-10-22 08:33:51 +03:00
Dirk-Jan C. Binnema 4dc15334a6 mu4e-compose: fix some overly long lines 2021-09-30 15:41:38 +03:00
Dirk-Jan C. Binnema 3a39eff1df mu4e-(actions|control|org|update).el: tidy up
Fix flycheck warnings, and use '--' instead of '~' for private
variables/functions.
2021-08-31 08:46:27 +03:00
Dirk-Jan C. Binnema a6514fd683 mu4e-server: rename from mu4e-proc
Rename mu4e-proc.el into mu4e-server.el

Rename mu4e~proc... into mu4e--server...

Update users, too.
2021-08-29 21:40:42 +03:00
Dirk-Jan C. Binnema 9157d9102d mu4e-utils: refactor into mu4e-helpers, separate files
Usurp more of the utils code than can be re-used without further dependencies in
helpers.

Split off specific parts in their own file.

After the helper/utils changes, update the rest of mu4e to take the changes into
account.
2021-08-29 21:40:42 +03:00
Dirk-Jan C. Binnema 035977a89a mu4e-context: make it a minor-mode
Add mu4e-context-minor-mode, for re-use in other parts of mu4e.

Update those parts + documentation.
2021-08-29 20:30:29 +03:00
Dirk-Jan C. Binnema b62f70f9d0 mu4e-compose: regenerate Date: when user removes it
However, we do not update the date if user does not do so.
2021-08-19 10:56:56 +03:00
Salman Mohammadi 539a946aa4
mu4e/*: fix license notice at the start of source files
At the start of mu4e/* files, the license has been wrongly attributed
to GNU Emacs instead of mu4e.

Fixes https://github.com/djcb/mu/issues/2019
2021-05-29 23:45:10 +02:00
Christophe Troestler b2b8f562f7 mu4e/compose: attach buffers & files setting any property 2021-04-05 22:35:58 +02:00
Stephen J. Eglen 5d859d005f Respect switch-function in compose-mail.
Emacs has several standard keybindings

C-x m   compose-mail
C-x 4 m compose-mail-other-window
C-x 5 m compose-mail-other-frame

This patch fixes the creation of new mail buffers to respect the
latter two keybindings, C-x 4 m and C-x 5 m.

Note that there is already the variable mu4e-compose-in-new-frame
which if true opens in a new frame.  That will still work for C-x m
and C-x 5 m, but if the user runs C-x 4 m, it switches to other-window
as it assumes the keybinding takes precedence.  This behaviour can be
changed within mu4e~draft-open-file.
2021-04-03 22:23:21 +01:00
Dirk-Jan C. Binnema 811ae26574 Merge branch 'draft-context' 2021-03-17 11:36:12 +02:00
Al Haji-Ali b094da8cd4 mu4e: Added mu4e-compose-context-switch for draft messages
Allow updating the context for the current draft message.
2021-03-17 11:35:09 +02:00
Dirk-Jan C. Binnema d12d85e187 mu4e: work-around for format-flowed corner-case
Fixes: #1938
(fixes, eh, works around it)
2021-03-11 19:41:53 +02:00
Dirk-Jan C. Binnema 8d1175f511 mu4e: avoid some compiler warnings
(require) necessary things etc.

warnings for using "obsolete" code are still there since things should
work on emacs 25.3
2021-03-11 10:17:00 +02:00
Dirk-Jan C. Binnema 9cab1ae751 mu4e-compose: restrict to headers in before-save-hook-fn
Follow up to issue #1846.
2020-12-05 11:42:54 +02:00
Dirk-Jan C. Binnema 4eed85187f mu4e-compose: Don't auto-update Message-Id/Date
Fixes #1846
2020-12-02 08:51:35 +02:00
Thierry Volpiatto c62dbb250c
Avoid looping through buffer-list when not needed 2020-11-16 08:59:45 +01:00