1
0
mirror of https://github.com/djcb/mu.git synced 2024-07-01 08:11:06 +02:00
Commit Graph

51 Commits

Author SHA1 Message Date
djcb
c6dd538975 mu-msg-part.c: some cosmetic changes 2014-10-19 11:38:49 +03:00
Foivos S. Zakkak
8f8bc52023 Revert "Do not handle signature parts after verification"
This reverts commit 6e9b9ad2d0.

Unfortunately the reverted commit breaks the Signature field for
encrypted and, at the same time, signed messages.

TODO: details button in the Signatures field does not work for such
cases because the signature is encrypted.

Conflicts:
	lib/mu-msg-part.c
2014-10-19 03:39:32 +03:00
Foivos S. Zakkak
2d843ca887 Add Decryption field
Add a decryption field of the form

Decryption: 2 part(s) decrypted 1 part(s) failed

Meaning that 2 encrypted mime parts where successfully decrypted and 1
part failed.  Note that the number 2 refers to the number of
successfully decrypted mime parts and not the number of successfully
decrypted encryptes multiparts, i.e., if an encrypted multipart
contains 4 parts and decryption is successful the field will be

Decryption: 4 part(s) decrypted

TODO: Add details button listing the names and indexes of the
decrypted (or not) mime-parts
2014-10-19 03:27:58 +03:00
Dirk-Jan C. Binnema
ae75060b6a Merge pull request #498 from zakkak/skip_signatures
Do not handle signature parts after verification
2014-10-18 13:16:44 +03:00
Foivos S. Zakkak
6e9b9ad2d0 Do not handle signature parts after verification
Since signatures are not listed as attachments there is no reason to
handle them after the verification.
2014-10-18 12:44:33 +03:00
Foivos S. Zakkak
a79cd23cd1 Improve decrypt failure handling
On failure to decrypt, list the encrypted part as an attachment
2014-10-18 12:33:20 +03:00
Foivos S. Zakkak
c40522b632 Fix #494. Start indexing from 1 instead of 0 2014-10-17 15:53:32 +03:00
Foivos S. Zakkak
a6a58b65f1 Remove left over argument from merge 2014-10-13 13:27:47 +03:00
Foivos S. Zakkak
6f50298667 Fix encrypted multiparts and attachments indexing
Pull request #483 does not handle encrypted multiparts properly.  It
used to just verify the signature and not process the parts of the
multipart.  This commit resolves this issue.

Additionally it did not index attachments properly and in the case of a
multipart directly containing more than one multiparts resulted on non
unique indexing of attachments/parts.  This commit resolves this issue
as well.
2014-10-12 22:43:58 +03:00
Foivos S. Zakkak
51037be7fb Fix #186 Part 3
This patch fixes the attachment extraction (open, save, temp) when using
`mu4e`.  `mu4e` used to not notify the mu-server about the
mu4e-decryption-policy.  As a result mu-server did not decrypt the
attachments for extract, open, or temp.
2014-10-10 18:34:57 +03:00
Foivos S. Zakkak
29e53d2eba Fix gpg decryption (#186)
After a multipart/encrypted part gets decrypted the result is usually a
`multipart/mixed` part (see enigmail).

Before this commit mime multiparts where handled only by
`g_mime_message_foreach`.  As a result the decrypted mime multiparts
where not processed.

This patch handles mime multiparts explicitly by removing the
`g_mime_message_foreach` invocations.  This might come at the cost of
reduced maintainability, in the case of radical gmime changes.  However,
gmime is pretty stable and that scenario is highly unlikely.

TODO: After decryption make any attachments available
2014-10-10 07:48:24 +03:00
djcb
b7324d5af6 * cleanup: drop gmime-2.4 support 2013-07-21 14:44:44 +03:00
djcb
55acd92bd9 * mu: fix some valgrind reports 2013-04-18 00:12:37 +03:00
djcb
8c0b7eb92a * mu-msg-part: don't free wrapper, we don't own it 2013-04-17 00:07:05 +03:00
djcb
855e81db99 * update copyright years 2013-03-30 11:32:07 +02:00
djcb
ab431a4a69 * lib: don't be too picky considering what's an attachment 2012-09-27 17:31:49 +03:00
djcb
506f26a342 * mu4e: unbreak attachments in forwarded messages 2012-09-25 15:20:26 +03:00
djcb
18096f326a * mu4e: allow message attachment to be viewed with mu4e (WIP) 2012-09-21 12:35:53 +03:00
djcb
cc59c83756 * lib: mu-msg-part: improve handling of b0rked messages, s/HAVE_CRYPTO/BUILD_CRYPTO/ 2012-09-17 12:43:53 +03:00
djcb
cd506d6d79 * add missing ifdef BUILD_CRYPTO block, so things build without crypto, too 2012-09-17 10:07:26 +03:00
djcb
b4219bd06b * minor 2012-09-16 18:00:51 +03:00
djcb
cb810010e1 * mu-msg-part: some refactoring, warn user about gmime pw bug 2012-09-14 12:17:40 +03:00
djcb
6a4b094ac9 * some refactoring for line35 2012-09-14 10:06:14 +03:00
djcb
61ade73332 * lib: add support for asking user for password from console 2012-09-13 22:57:04 +03:00
djcb
ac1d1b2ed8 * cosmetics 2012-09-13 21:12:12 +03:00
djcb
0445d87ab9 * lib/mu-msg-part.c: enable decryption (WIP) 2012-09-12 12:12:24 +03:00
djcb
9d6ef76f5f * crypto: improve signature checking code 2012-09-01 20:03:48 +03:00
djcb
14661a6d7b * restore mu-verify (WIP) 2012-08-30 20:26:35 +03:00
djcb
adc23614a1 * enable signature verification (WIP) 2012-08-30 12:53:52 +03:00
djcb
dcda69e459 * lib: don't check for bogus error 2012-08-23 00:00:28 +03:00
djcb
8e6903cb61 * mu-msg-part: don't use g_mime_part_iter_*: it's gmime 2.6 only 2012-08-11 11:54:08 +03:00
djcb
51fe7fcae8 * lib: refactor attachment checking 2012-08-09 11:45:04 +03:00
djcb
86bf7b7165 * lib: cleanup mu_msg_get_body_(html|text) (WIP) 2012-08-09 09:38:22 +03:00
djcb
c3391b3929 * lib: cleanups: remove mu-msg-cache (WIP) 2012-08-08 19:13:59 +03:00
djcb
d7dabca0b6 * lib: fixes for make line35/make cc10 2012-08-07 12:02:44 +03:00
djcb
a91fa644d5 * lib: correctly handle embedded text parts 2012-08-07 11:43:54 +03:00
djcb
b71a27b7c0 * mu4e/mu-msg-part: better detection of body / attachments 2012-08-02 15:48:03 +03:00
djcb
11b60b7ca0 * mu-msg-part: small fix (initialize fname) 2012-08-01 23:22:50 +03:00
djcb
536665d126 * further refactoring/cleanup of MuMsgPart 2012-08-01 17:02:11 +03:00
djcb
6a7562422f * MuMsgPart refactoring / cleanups 2012-08-01 10:45:03 +03:00
djcb
8432156765 * crypto: implement automagic decryption when so requested
(mainly by adding some smartness to various part_foreach functions, adding
  mu_msg_(get|set)_auto_decrypt to mark a message for auto-decryption)
2012-07-27 18:04:17 +03:00
djcb
8f6cf28f2d * mu-msg-part: better detection of message body 2012-07-24 23:38:37 +03:00
djcb
c7eaaf9475 * mu-msg-part: clean up mime-part parsing 2012-07-24 22:12:22 +03:00
djcb
5a92c8b58a * crypto: decryption support (WIP) 2012-07-22 19:39:17 +03:00
djcb
c240e6c17f * fixes for 'make line35' (small function refactoring) 2012-07-20 11:54:37 +03:00
djcb
acfabfdf4b * refactor: MU_MSG_PART_OPTION -> MU_MSG_OPTION and related changes 2012-07-18 16:22:10 +03:00
djcb
807c9de625 * crypto: better handling of crypto errors 2012-07-18 10:30:23 +03:00
djcb
c7cf0c6655 * crypto: hook up crypto support with mu-msg-part and friends 2012-07-17 19:16:42 +03:00
djcb
d4abc249c2 * refactor mu_msg_(un)load_msg_file from various versions 2012-07-16 12:55:54 +03:00
djcb
a2bceff17c * cosmetic 2012-07-16 09:23:48 +03:00