Commit Graph

403 Commits

Author SHA1 Message Date
Dirk-Jan C. Binnema 4f72e2656d mu4e: use message-field-value
Simplify

...instead of
save-restriction/message-narrow-to-headers/message-fetch-field.
2024-04-20 11:44:22 +03:00
Adam Porter 6a12137506 mu4e--view-render-buffer: Disable Gnus bookmark-make-record-function
The function 'gnus-summary-bookmark-make-record' does not work properly with the
faux "appeasement" summary buffer, causing undesired changes in the window
configuration when the message rendering buffer's bookmark function is
called (which some packages, like Activities, Burly, and Dogears do routinely).

See <https://github.com/alphapapa/activities.el/issues/55>.

Reported-by: Daniel Goldin <https://github.com/danielgoldin>
2024-04-10 21:47:04 +03:00
Dirk-Jan C. Binnema ac08a35c5b mu4e-view: re-appease gnus
Otherwise some saving of MIME-parts does not work properly.
2024-04-10 21:47:04 +03:00
Dirk-Jan C. Binnema 9557ba43a0 mu4e-view: explicitly scroll after rendering
This seems necessary in some cases; for some reason _this week_ that came
up a few time, although the code is old. Could repro with a bare emacs.

Fixes #2683.
2024-04-05 20:04:24 +03:00
Dirk-Jan C. Binnema 7771a56026 mu4e: fix some warnings on older emacsen 2024-04-04 21:30:08 +03:00
Dirk-Jan C. Binnema 7688a2b548 mu4e-view: appease gnus no longer
Seems it's not necessary anymore.
2024-04-04 21:30:08 +03:00
Dirk-Jan C. Binnema 8afe3e11a2 mu4e-view: use <mouse-2> for links
Only <mouse-2>, to be consistent with eww.
2024-03-01 23:24:37 +02:00
Dirk-Jan C. Binnema f7ba00ec08 mu4e-view: update docstring for header customization 2024-02-24 13:47:55 +02:00
Dirk-Jan C. Binnema dd51f5aa12 mu4e-view: handle links with new composer 2023-12-22 21:25:12 +02:00
Dirk-Jan C. Binnema fa0248a361 mu4e-view: unfold threads when working in headers-context
It's a bit hard otherwise to keep headers/article in sync.

Fixes #2498.
2023-11-22 21:41:02 +02:00
Dirk-Jan C. Binnema 3a506846f9 mu4e-view: do not bind message-alternative-emails recursively
Fixes #2597.
2023-11-16 19:03:13 +02:00
Dirk-Jan C. Binnema 08ebe87f81 mu4e-view: fix typo
a rogue ' snuck in.
2023-11-13 10:42:04 +02:00
Dirk-Jan C. Binnema e71640fdfa mu4e-view: tidy-up mu4e-view-message-text 2023-11-12 23:29:51 +02:00
Dirk-Jan C. Binnema c76c410256 mu4e: always include message-id in mu4e-view-message-text
Regardless of mu4e-view-headers; and ensure the message-id is in
<brackets>.
2023-11-05 17:52:14 +02:00
Dirk-Jan C. Binnema dfe28f033a mu4e-view: do full render in mu4e-view-message-text
Otherwise decoding does not work correctly.
2023-11-04 23:38:02 +02:00
Dirk-Jan C. Binnema c3bc50bd02 mu4e-view: assign gnus-article-buffer in mu4e-view-mode
Some external programs (such as bbdb) seems to depend on that.
2023-11-04 11:16:24 +02:00
Dirk-Jan C. Binnema 541c818a9f mu4e-compose: include references / in-reply-to
For replies and forwarded messages.
2023-11-02 22:21:10 +02:00
Dirk-Jan C. Binnema eee73f8199 mu4e: better handle alternative address
In compose / contacts
2023-10-29 17:16:05 +02:00
Dirk-Jan C. Binnema ea78fab0ef mu4e-view: remove ^M from raw message
They can cause rendering issues later.
2023-10-29 17:15:35 +02:00
Dirk-Jan C. Binnema 13d068f183 mu4e: update headers/view for new composer 2023-10-25 22:05:06 +03:00
Dirk-Jan C. Binnema 4d11abd1ca mu4e-view: ignore decoding errors
We can't do much about them; still attempt to show the message.

Fixes #2561.
2023-10-05 08:44:11 +03:00
Dirk-Jan C. Binnema 8fc13ab8f3 mu4e: Shorten descriptions a bit 2023-09-20 22:31:19 +03:00
Thierry Volpiatto 67c8ff75a7 Fix missing or incorrect descriptions in file headers
Try to make useful descriptions and use conventional --- to separate filename
from description.
2023-09-20 22:04:48 +03:00
Dirk-Jan C. Binnema c4a141975e mu4e-view: remove 'describe bindings' override
Not sure where it was there in the first place

Fixes #2541.
2023-08-24 23:28:59 +03:00
Dirk-Jan C. Binnema 535ab6e010 mu4e-view: avoid getting gnus markers in m-v-message-text
We don't need that here (when replying to email).
2023-07-18 18:31:48 +03:00
Dirk-Jan C. Binnema 56cea76b8d mu4e-view: don't set gnus-article-emulate-mime by default
This triggers excessive CPU-load in some corner-case messages.

Make it a 'massage' option instead.

Fixes #2515.
2023-07-17 21:53:42 +03:00
Dirk-Jan C. Binnema c263e4c4d7 mu4e-view: fix mu4e-view-refresh
It's didn't quite work in the post-mu4e-window world
2023-07-17 21:53:42 +03:00
Dirk-Jan C. Binnema 993f16522a mu4e: split off mime-handling from mu4e-view & improve
Split off the MIME-handling from mu4e-view.el into its own
mu4e-mime-parts.el

Improve the implementation, updating completions with annotations.
Support "Pick all" for completing attachments and MIME-types.

Both attachment/inline disposition MIME-type with a file name are
considered "attachment" now.

Allow MIME-part actions to target multiple MIME-parts.
2023-07-17 21:53:42 +03:00
Dirk-Jan C. Binnema 73f0691662 mu4e-view: restore point in single-window headers buffer
In single-window mode, after quitting the view, explicitly restore the
point in the headers view to the last viewed message (just like in split
view mode).
2023-06-25 11:07:45 +03:00
Dirk-Jan C. Binnema 713bb4e9e1 mu4e: run mu4e-view-rendered-hook non-read-only
Non-read-only is likely the expected behavior.

Fixes #2500.
2023-06-09 00:30:01 +03:00
Dirk-Jan C. Binnema 0ed7dc2102 mu4e: don't error out in mu4e-view-quit
Fixes #2487.
2023-05-10 23:49:10 +03:00
Dirk-Jan C. Binnema fbb68b80ee mu4e: add actions for archive-url in view/headers 2023-05-10 18:52:15 +03:00
Ruijie Yu 3018ceeb86 Add actions to browse online archive for a mailing list message
* mu4e/mu4e-headers.el (defcustom mu4e-header-actions): Convert
from defvar.  Add action for browsing online archive.
* mu4e/mu4e-view.el (defcustom mu4e-view-actions): Change use of
`seq-filter' to `delq'.  Add action for browsing online archive.
2023-05-05 23:10:21 +08:00
Dirk-Jan C. Binnema e2947f181d mu4e: add thread support to message-view
No keybindings yet, since TAB etc. conflict.
2023-04-24 21:52:25 +03:00
Dirk-Jan C. Binnema f2a193b4fd
Merge pull request #2449 from seanfarley/detach-rename
[ux bug] mu4e: create random name for newly detached views
2023-04-05 23:20:00 +03:00
Ruijie Yu e5b33c29d1 Fix defcustom type definitions
So that the type definitions reflects the docstrings more closely.  In additon,
fixed warnings from flymake about docstring.

* mu4e/mu4e-draft.el
mu4e-compose-keep-self-cc: should be a comma

* mu4e/mu4e-folders.el
mu4e-maildir-shortcuts: recognize new (plist) format

* mu4e/mu4e-helpers.el
mu4e-debug: removed unnecessary double space in docstring

* mu4e/mu4e-query-items.el
mu4e-query-rewrite-function: prepend "\\=" before column 0 "(" in docstring

* mu4e/mu4e-search.el
mu4e-search-sort-field mu4e-search-sort-direction: used radio in types

* mu4e/mu4e-server.el
mu4e-mu-binary: "mu" executable must exist

* mu4e/mu4e-view.el
mu4e-view-fields: fixed type
mu4e-view-actions: for function refs, prefer "#'" rather than "'"
2023-04-01 15:59:16 +08:00
Sean Farley ba6c164ac0 mu4e: create random name for newly detached views
Without creating some kind of a temporary name (which could then be
trivially renamed by the user as the current instructions say) a new
user trying to learn how to detach a view will run into this error when
switching to a new message after detaching:

[mu4e] Detached view buffer from *mu4e-headers*
funcall-interactively: No buffer named *mu4e-article*<2>

It seems like a good default and less friction to create a random name
automatically when detaching.
2023-03-31 09:49:26 -07:00
Dirk-Jan C. Binnema 001eb114cb mu4e-view: support gnus message-id links
When clicking the button, find the message in mu4e.

Fixes #2441
2023-03-25 10:35:27 +02:00
Sean Allred 7f2225ccfc Don't die if the headers buffer isn't in a window
If the headers buffer isn't in a live window (e.g., mu4e-split-view
is 'single-window), get-buffer-window will return nil. In turn,
with-selected-window will die if fed a nil window, so default to using the
current window in this case.

This fixes a regression from c23dad7058 that
prevented using n/p from a view buffer.
2023-03-15 02:20:16 -05:00
Dirk-Jan C. Binnema 360cf62ba6 mu4e-view: better error message when we cannot switch text/html
"This is a pseudo article" isn't very helpful.
2023-02-17 16:03:34 +02:00
Dirk-Jan C. Binnema 92ac6de09c mu4e: support jumping to previous/next thread
in headers view, message view with '{' and '}.
Also update documentation.

Fixes #1523
2023-02-12 12:58:05 +02:00
Leo Gaskin d4cb318bc1 Only add bug-reference setup function after the feature was loaded
This is done so that we do not override the default defvar value of
bug-reference-auto-setup-functions but instead add our own hook to it.
2023-02-03 13:32:34 +01:00
Dirk-Jan C. Binnema c23dad7058 mu4e-view: use with-selected-window in mv--in-headers-context
Fixed #1394
2023-01-18 20:32:34 +02:00
Dirk-Jan C. Binnema 72a9ee9d4b mu4e-view: fix misplaced bracket
Fixes #2416.
2023-01-16 22:20:33 +02:00
Dirk-Jan C. Binnema a8d2476f08 mu4e-view: select window when operating in headers context
Fixes #2398
2023-01-14 20:02:05 +02:00
Dirk-Jan C. Binnema b11293147f mu4e: move mu4e~headers-jump-to-maildir to search
... to mu4e-search-maildir.

Where we can, we move appropriate code from the overpopulated
mu4e-headers.el to mu4e-search, and update users.
2023-01-09 22:43:39 +02:00
Dirk-Jan C. Binnema 551bc46b47 mu4e: improve emacs menu-bar items
Fixes issue #2406.
2023-01-09 22:13:24 +02:00
Dirk-Jan C. Binnema 1e018ee1fc mu4e: remove keybindings from mu4e-context-minor-mode
They interfered with the major modes (in particular the undefine hack
needed in mu4e-compose).

Fixes #2402.
2023-01-07 17:13:36 +02:00
Dirk-Jan C. Binnema b1b11eb0cb
Merge pull request #2395 from bjcohen/bjcohen/fix-split-view-single-window-nil
mu4e-view: don't delete window on view msg in single-window mode
2023-01-04 00:26:50 +02:00
Ben Cohen bade0d52fb mu4e-view: don't delete window on view msg in single-window mode 2023-01-02 16:29:36 -05:00