2022-06-08 23:00:59 +02:00
|
|
|
|
/*
|
|
|
|
|
** Copyright (C) 2022 Dirk-Jan C. Binnema <djcb@djcbsoftware.nl>
|
|
|
|
|
**
|
|
|
|
|
** This program is free software; you can redistribute it and/or modify it
|
|
|
|
|
** under the terms of the GNU General Public License as published by the
|
|
|
|
|
** Free Software Foundation; either version 3, or (at your option) any
|
|
|
|
|
** later version.
|
|
|
|
|
**
|
|
|
|
|
** This program is distributed in the hope that it will be useful,
|
|
|
|
|
** but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
** GNU General Public License for more details.
|
|
|
|
|
**
|
|
|
|
|
** You should have received a copy of the GNU General Public License
|
|
|
|
|
** along with this program; if not, write to the Free Software Foundation,
|
|
|
|
|
** Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
|
**
|
|
|
|
|
*/
|
|
|
|
|
|
2022-08-10 07:20:58 +02:00
|
|
|
|
|
2022-10-30 10:28:42 +01:00
|
|
|
|
#include "utils/mu-result.hh"
|
2022-06-08 23:00:59 +02:00
|
|
|
|
#include <array>
|
|
|
|
|
#include <thread>
|
|
|
|
|
#include <string>
|
|
|
|
|
#include <string_view>
|
|
|
|
|
#include <fstream>
|
|
|
|
|
#include <unordered_map>
|
|
|
|
|
|
|
|
|
|
#include <mu-store.hh>
|
2022-10-30 10:28:42 +01:00
|
|
|
|
#include <mu-maildir.hh>
|
2022-06-08 23:00:59 +02:00
|
|
|
|
#include <utils/mu-utils.hh>
|
2022-08-10 07:20:58 +02:00
|
|
|
|
#include <utils/mu-test-utils.hh>
|
2022-06-08 23:00:59 +02:00
|
|
|
|
#include <message/mu-message.hh>
|
|
|
|
|
|
|
|
|
|
using namespace Mu;
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/// map of some (unique) path-tail to the message-text
|
|
|
|
|
using TestMap = std::unordered_map<std::string, std::string>;
|
|
|
|
|
|
|
|
|
|
static Store
|
|
|
|
|
make_test_store(const std::string& test_path, const TestMap& test_map,
|
|
|
|
|
const StringVec &personal_addresses)
|
|
|
|
|
{
|
2023-07-06 20:33:01 +02:00
|
|
|
|
std::string maildir = test_path + "/Maildir/";
|
|
|
|
|
// note the trailing '/'
|
|
|
|
|
g_test_bug("2513");
|
2022-06-08 23:00:59 +02:00
|
|
|
|
|
|
|
|
|
/* write messages to disk */
|
|
|
|
|
for (auto&& item: test_map) {
|
|
|
|
|
|
|
|
|
|
const auto msgpath = maildir + "/" + item.first;
|
|
|
|
|
|
|
|
|
|
/* create the directory for the message */
|
|
|
|
|
auto dir = to_string_gchar(g_path_get_dirname(msgpath.c_str()));
|
|
|
|
|
if (g_test_verbose())
|
|
|
|
|
g_message("create message dir %s", dir.c_str());
|
|
|
|
|
|
|
|
|
|
g_assert_cmpuint(g_mkdir_with_parents(dir.c_str(), 0700), ==, 0);
|
|
|
|
|
|
|
|
|
|
/* write the file */
|
|
|
|
|
std::ofstream stream(msgpath);
|
|
|
|
|
stream.write(item.second.data(), item.second.size());
|
|
|
|
|
g_assert_true(stream.good());
|
|
|
|
|
stream.close();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* make the store */
|
2023-07-01 17:20:51 +02:00
|
|
|
|
MemDb mdb;
|
|
|
|
|
Config conf{mdb};
|
|
|
|
|
conf.set<Config::Id::PersonalAddresses>(personal_addresses);
|
|
|
|
|
|
|
|
|
|
auto store = Store::make_new(test_path, maildir, conf);
|
2022-06-08 23:00:59 +02:00
|
|
|
|
assert_valid_result(store);
|
|
|
|
|
|
|
|
|
|
/* index the messages */
|
|
|
|
|
auto res = store->indexer().start({});
|
|
|
|
|
g_assert_true(res);
|
|
|
|
|
while(store->indexer().is_running()) {
|
|
|
|
|
using namespace std::chrono_literals;
|
|
|
|
|
std::this_thread::sleep_for(100ms);
|
|
|
|
|
}
|
2022-10-26 21:35:34 +02:00
|
|
|
|
|
|
|
|
|
if (test_map.size() > 0)
|
|
|
|
|
g_assert_false(store->empty());
|
|
|
|
|
|
2022-06-08 23:00:59 +02:00
|
|
|
|
g_assert_cmpuint(store->size(),==,test_map.size());
|
|
|
|
|
|
|
|
|
|
/* and we have a fully-ready store */
|
|
|
|
|
return std::move(store.value());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
test_simple()
|
|
|
|
|
{
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
|
|
|
|
|
// "sqlite-msg" "Simple mailing list message.
|
|
|
|
|
{
|
|
|
|
|
"basic/cur/sqlite-msg:2,S",
|
|
|
|
|
R"(Return-Path: <sqlite-dev-bounces@sqlite.org>
|
|
|
|
|
X-Original-To: xxxx@localhost
|
|
|
|
|
Delivered-To: xxxx@localhost
|
|
|
|
|
Received: from mindcrime (localhost [127.0.0.1])
|
|
|
|
|
by mail.xxxxsoftware.nl (Postfix) with ESMTP id 32F276963F
|
|
|
|
|
for <xxxx@localhost>; Mon, 4 Aug 2008 21:49:34 +0300 (EEST)
|
|
|
|
|
Message-Id: <83B5AF40-DBFA-4578-A043-04C80276E195@sqlabs.net>
|
|
|
|
|
From: "Foo Example" <foo@example.com>
|
|
|
|
|
To: sqlite-dev@sqlite.org
|
|
|
|
|
Cc: "Bank of America" <bank@example.com>
|
2022-07-14 07:09:08 +02:00
|
|
|
|
Bcc: Aku Ankka <donald.duck@duckstad.nl>
|
2022-06-08 23:00:59 +02:00
|
|
|
|
Mime-Version: 1.0 (Apple Message framework v926)
|
|
|
|
|
Date: Mon, 4 Aug 2008 11:40:49 +0200
|
|
|
|
|
X-Mailer: Apple Mail (2.926)
|
|
|
|
|
Subject: [sqlite-dev] VM optimization inside sqlite3VdbeExec
|
|
|
|
|
Precedence: list
|
|
|
|
|
Reply-To: sqlite-dev@sqlite.org
|
|
|
|
|
List-Id: <sqlite-dev.sqlite.org>
|
|
|
|
|
Content-Type: text/plain; charset="us-ascii"
|
|
|
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
|
Sender: sqlite-dev-bounces@sqlite.org
|
|
|
|
|
|
|
|
|
|
Inside sqlite3VdbeExec there is a very big switch statement.
|
|
|
|
|
In order to increase performance with few modifications to the
|
|
|
|
|
original code, why not use this technique ?
|
|
|
|
|
http://docs.freebsd.org/info/gcc/gcc.info.Labels_as_Values.html
|
|
|
|
|
|
|
|
|
|
With a properly defined "instructions" array, instead of the switch
|
|
|
|
|
statement you can use something like:
|
|
|
|
|
goto * instructions[pOp->opcode];
|
2022-06-14 22:43:58 +02:00
|
|
|
|
|
|
|
|
|
I said: "Aujourd'hui!"
|
2022-06-08 23:00:59 +02:00
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
|
|
|
|
|
// matches
|
|
|
|
|
for (auto&& expr: {
|
|
|
|
|
"Inside",
|
|
|
|
|
"from:foo@example.com",
|
|
|
|
|
"from:Foo",
|
|
|
|
|
"from:\"Foo Example\"",
|
|
|
|
|
"from:/Foo.*Example/",
|
|
|
|
|
"recip:\"Bank Of America\"",
|
2022-07-14 07:09:08 +02:00
|
|
|
|
"cc:bank@example.com",
|
|
|
|
|
"cc:bank",
|
|
|
|
|
"cc:america",
|
|
|
|
|
"bcc:donald.duck@duckstad.nl",
|
|
|
|
|
"bcc:donald.duck",
|
|
|
|
|
"bcc:duckstad.nl",
|
|
|
|
|
"bcc:aku",
|
|
|
|
|
"bcc:ankka",
|
|
|
|
|
"bcc:\"aku ankka\"",
|
2022-06-08 23:00:59 +02:00
|
|
|
|
"date:2008-08-01..2008-09-01",
|
|
|
|
|
"prio:low",
|
|
|
|
|
"to:sqlite-dev@sqlite.org",
|
2022-06-14 22:43:58 +02:00
|
|
|
|
"list:sqlite-dev.sqlite.org",
|
|
|
|
|
"aujourd'hui",
|
|
|
|
|
}) {
|
2022-06-08 23:00:59 +02:00
|
|
|
|
|
|
|
|
|
if (g_test_verbose())
|
|
|
|
|
g_message("query: '%s'", expr);
|
|
|
|
|
auto qr = store.run_query(expr);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
auto qr = store.run_query("statement");
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
|
|
|
|
|
assert_equal(qr->begin().subject().value_or(""),
|
|
|
|
|
"[sqlite-dev] VM optimization inside sqlite3VdbeExec");
|
|
|
|
|
g_assert_true(qr->begin().references().empty());
|
|
|
|
|
//g_assert_cmpuint(qr->begin().date().value_or(0), ==, 123454);
|
|
|
|
|
}
|
|
|
|
|
|
2022-06-26 20:55:14 +02:00
|
|
|
|
static void
|
|
|
|
|
test_spam_address_components()
|
|
|
|
|
{
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
|
|
|
|
|
// "sqlite-msg" "Simple mailing list message.
|
|
|
|
|
{
|
|
|
|
|
"spam/cur/spam-msg:2,S",
|
|
|
|
|
R"(Message-Id: <abcde@foo.bar>
|
|
|
|
|
From: "Foo Example" <bar@example.com>
|
|
|
|
|
To: example@example.com
|
|
|
|
|
Subject: ***SPAM*** this is a test
|
|
|
|
|
|
|
|
|
|
Boo!
|
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
|
|
|
|
|
g_test_bug("2278");
|
|
|
|
|
g_test_bug("2281");
|
|
|
|
|
|
|
|
|
|
// matches both
|
|
|
|
|
for (auto&& expr: {
|
|
|
|
|
"SPAM",
|
|
|
|
|
"spam",
|
|
|
|
|
"/.*SPAM.*/",
|
|
|
|
|
"subject:SPAM",
|
|
|
|
|
"from:bar@example.com",
|
|
|
|
|
"subject:\\*\\*\\*SPAM\\*\\*\\*",
|
|
|
|
|
"bar",
|
|
|
|
|
"example.com"
|
|
|
|
|
}) {
|
|
|
|
|
|
|
|
|
|
if (g_test_verbose())
|
|
|
|
|
g_message("query: '%s'", expr);
|
|
|
|
|
auto qr = store.run_query(expr);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
}
|
|
|
|
|
}
|
2022-06-08 23:00:59 +02:00
|
|
|
|
|
2022-08-07 11:01:18 +02:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
test_dups_related()
|
|
|
|
|
{
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
/* parent */
|
|
|
|
|
{
|
|
|
|
|
"inbox/cur/msg1:2,S",
|
|
|
|
|
R"(Message-Id: <abcde@foo.bar>
|
|
|
|
|
From: "Foo Example" <bar@example.com>
|
|
|
|
|
Date: Sat, 06 Aug 2022 11:01:54 -0700
|
|
|
|
|
To: example@example.com
|
|
|
|
|
Subject: test1
|
|
|
|
|
|
|
|
|
|
Parent
|
|
|
|
|
)"},
|
|
|
|
|
/* child (dup vv) */
|
|
|
|
|
{
|
|
|
|
|
"boo/cur/msg2:1,S",
|
|
|
|
|
R"(Message-Id: <edcba@foo.bar>
|
|
|
|
|
In-Reply-To: <abcde@foo.bar>
|
|
|
|
|
From: "Foo Example" <bar@example.com>
|
|
|
|
|
Date: Sat, 06 Aug 2022 13:01:54 -0700
|
|
|
|
|
To: example@example.com
|
|
|
|
|
Subject: Re: test1
|
|
|
|
|
|
|
|
|
|
Child
|
|
|
|
|
)"},
|
|
|
|
|
/* child (dup ^^) */
|
|
|
|
|
{
|
|
|
|
|
"inbox/cur/msg2:1,S",
|
|
|
|
|
R"(Message-Id: <edcba@foo.bar>
|
|
|
|
|
In-Reply-To: <abcde@foo.bar>
|
|
|
|
|
From: "Foo Example" <bar@example.com>
|
|
|
|
|
Date: Sat, 06 Aug 2022 14:01:54 -0700
|
|
|
|
|
To: example@example.com
|
|
|
|
|
Subject: Re: test1
|
|
|
|
|
|
|
|
|
|
Child
|
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
{
|
|
|
|
|
// direct matches
|
|
|
|
|
auto qr = store.run_query("test1", Field::Id::Date,
|
|
|
|
|
QueryFlags::None);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 3);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// skip duplicate messages; which one is skipped is arbitrary.
|
|
|
|
|
auto qr = store.run_query("test1", Field::Id::Date,
|
|
|
|
|
QueryFlags::SkipDuplicates);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 2);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// no related
|
|
|
|
|
auto qr = store.run_query("Parent", Field::Id::Date);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// find related messages
|
|
|
|
|
auto qr = store.run_query("Parent", Field::Id::Date,
|
|
|
|
|
QueryFlags::IncludeRelated);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 3);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// find related messages, skip dups. the leader message
|
|
|
|
|
// should _not_ be skipped.
|
|
|
|
|
auto qr = store.run_query("test1 AND maildir:/inbox",
|
|
|
|
|
Field::Id::Date,
|
|
|
|
|
QueryFlags::IncludeRelated|
|
|
|
|
|
QueryFlags::SkipDuplicates);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 2);
|
|
|
|
|
|
|
|
|
|
// ie the /boo is to be skipped, since it's not in the leader
|
|
|
|
|
// set.
|
|
|
|
|
for (auto&& m: *qr)
|
|
|
|
|
assert_equal(m.message()->maildir(), "/inbox");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// find related messages, find parent from child.
|
|
|
|
|
auto qr = store.run_query("Child and maildir:/inbox",
|
|
|
|
|
Field::Id::Date,
|
|
|
|
|
QueryFlags::IncludeRelated);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 3);
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// find related messages, find parent from child.
|
|
|
|
|
// leader message wins
|
|
|
|
|
auto qr = store.run_query("Child and maildir:/inbox",
|
|
|
|
|
Field::Id::Date,
|
|
|
|
|
QueryFlags::IncludeRelated|
|
|
|
|
|
QueryFlags::SkipDuplicates|
|
|
|
|
|
QueryFlags::Descending);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 2);
|
|
|
|
|
|
|
|
|
|
// ie the /boo is to be skipped, since it's not in the leader
|
|
|
|
|
// set.
|
|
|
|
|
for (auto&& m: *qr)
|
|
|
|
|
assert_equal(m.message()->maildir(), "/inbox");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-08-11 22:06:12 +02:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
test_related_missing_root()
|
|
|
|
|
{
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
{
|
|
|
|
|
"inbox/cur/msg1:2,S",
|
|
|
|
|
R"(Content-Type: text/plain; charset=utf-8
|
|
|
|
|
References: <EZrZOnVCsYfFcX3Ls0VFoRnJdCGV4GM5YtO739l-iOB2ADNH7cIJWb0DaO5Of3BWDUEKq18Rz3a7rNoI96bNwQ==@protonmail.internalid>
|
|
|
|
|
To: "Joerg Roedel" <joro@8bytes.org>, "Suman Anna" <s-anna@ti.com>
|
|
|
|
|
Reply-To: "Dan Carpenter" <dan.carpenter@oracle.com>
|
|
|
|
|
From: "Dan Carpenter" <dan.carpenter@oracle.com>
|
|
|
|
|
Subject: [PATCH] iommu/omap: fix buffer overflow in debugfs
|
|
|
|
|
Date: Thu, 4 Aug 2022 17:32:39 +0300
|
|
|
|
|
Message-Id: <YuvYh1JbE3v+abd5@kili>
|
|
|
|
|
List-Id: <kernel-janitors.vger.kernel.org>
|
|
|
|
|
Precedence: bulk
|
|
|
|
|
|
|
|
|
|
There are two issues here:
|
|
|
|
|
)"},
|
|
|
|
|
{
|
|
|
|
|
"inbox/cur/msg2:2,S",
|
|
|
|
|
R"(Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
Content-Type: text/plain; charset=utf-8
|
|
|
|
|
References: <YuvYh1JbE3v+abd5@kili>
|
|
|
|
|
<9pEUi_xoxa7NskF7EK_qfrlgjXzGsyw9K7cMfYbo-KI6fnyVMKTpc8E2Fu94V8xedd7cMpn0LlBrr9klBMflpw==@protonmail.internalid>
|
|
|
|
|
Reply-To: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
|
|
|
|
|
From: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
|
|
|
|
|
Subject: Re: [PATCH] iommu/omap: fix buffer overflow in debugfs
|
|
|
|
|
List-Id: <kernel-janitors.vger.kernel.org>
|
|
|
|
|
Message-Id: <YuvzKJM66k+ZPD9c@pendragon.ideasonboard.com>
|
|
|
|
|
Precedence: bulk
|
|
|
|
|
In-Reply-To: <YuvYh1JbE3v+abd5@kili>
|
|
|
|
|
|
|
|
|
|
Hi Dan,
|
|
|
|
|
|
|
|
|
|
Thank you for the patch.
|
|
|
|
|
)"},
|
|
|
|
|
{
|
|
|
|
|
"inbox/cur/msg3:2,S",
|
|
|
|
|
R"(Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
Content-Type: text/plain; charset=utf-8
|
|
|
|
|
References: <YuvYh1JbE3v+abd5@kili>
|
|
|
|
|
<G6TStg8J52Q-uSMTR7wRQdPeloxpZMiEQT_F8_JIDYM25eEPeHGgrNKO0fuO78MiQgD9Mz4BDtsZlZgmPKFe4Q==@protonmail.internalid>
|
|
|
|
|
To: "Dan Carpenter" <dan.carpenter@oracle.com>, "Joerg Roedel"
|
|
|
|
|
<joro@8bytes.org>, "Suman Anna" <s-anna@ti.com>
|
|
|
|
|
Reply-To: "Robin Murphy" <robin.murphy@arm.com>
|
|
|
|
|
From: "Robin Murphy" <robin.murphy@arm.com>
|
|
|
|
|
Subject: Re: [PATCH] iommu/omap: fix buffer overflow in debugfs
|
|
|
|
|
List-Id: <kernel-janitors.vger.kernel.org>
|
|
|
|
|
Message-Id: <90a760c4-6e88-07b4-1f20-8b10414e49aa@arm.com>
|
|
|
|
|
Precedence: bulk
|
|
|
|
|
In-Reply-To: <YuvYh1JbE3v+abd5@kili>
|
|
|
|
|
Date: Thu, 4 Aug 2022 17:31:39 +0100
|
|
|
|
|
|
|
|
|
|
On 04/08/2022 3:32 pm, Dan Carpenter wrote:
|
|
|
|
|
> There are two issues here:
|
|
|
|
|
)"},
|
|
|
|
|
{
|
|
|
|
|
"inbox/new/msg4",
|
|
|
|
|
R"(Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
Content-Type: text/plain; charset=utf-8
|
|
|
|
|
References: <YuvYh1JbE3v+abd5@kili>
|
|
|
|
|
<90a760c4-6e88-07b4-1f20-8b10414e49aa@arm.com>
|
|
|
|
|
<T4CDWjUrgtI5n4mh1JEdW6RLYzqbPE9-yDrhEVwDM22WX-198fBwcnLd-4_xR1gvsVSHQps9fp_pZevTF0ZmaA==@protonmail.internalid>
|
|
|
|
|
To: "Robin Murphy" <robin.murphy@arm.com>
|
|
|
|
|
Reply-To: "Dan Carpenter" <dan.carpenter@oracle.com>
|
|
|
|
|
From: "Dan Carpenter" <dan.carpenter@oracle.com>
|
|
|
|
|
Subject: Re: [PATCH] iommu/omap: fix buffer overflow in debugfs
|
|
|
|
|
List-Id: <kernel-janitors.vger.kernel.org>
|
|
|
|
|
Date: Fri, 5 Aug 2022 09:37:02 +0300
|
|
|
|
|
In-Reply-To: <90a760c4-6e88-07b4-1f20-8b10414e49aa@arm.com>
|
|
|
|
|
Precedence: bulk
|
|
|
|
|
Message-Id: <20220805063702.GH3438@kadam>
|
|
|
|
|
|
|
|
|
|
On Thu, Aug 04, 2022 at 05:31:39PM +0100, Robin Murphy wrote:
|
|
|
|
|
> On 04/08/2022 3:32 pm, Dan Carpenter wrote:
|
|
|
|
|
> > There are two issues here:
|
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("fix buffer overflow in debugfs",
|
|
|
|
|
Field::Id::Date, QueryFlags::IncludeRelated);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 4);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("fix buffer overflow in debugfs and flag:unread",
|
|
|
|
|
Field::Id::Date, QueryFlags::None);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
assert_equal(qr->begin().message_id().value_or(""), "20220805063702.GH3438@kadam");
|
|
|
|
|
assert_equal(qr->begin().thread_id().value_or(""), "YuvYh1JbE3v+abd5@kili");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
/* this one failed earlier, because the 'protonmail' id is the
|
|
|
|
|
* first reference, which means it does _not_ have the same
|
|
|
|
|
* thread-id as the rest; however, we filter these
|
|
|
|
|
* fake-message-ids now.*/
|
|
|
|
|
g_test_bug("2312");
|
|
|
|
|
|
|
|
|
|
auto qr = store.run_query("fix buffer overflow in debugfs and flag:unread",
|
|
|
|
|
Field::Id::Date, QueryFlags::IncludeRelated);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 4);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2022-09-19 17:27:03 +02:00
|
|
|
|
static void
|
|
|
|
|
test_body_matricula()
|
|
|
|
|
{
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
{
|
|
|
|
|
"basic/cur/matricula-msg:2,S",
|
|
|
|
|
R"(From: XXX <XX@XX.com>
|
|
|
|
|
Subject:
|
|
|
|
|
=?iso-8859-1?Q?EF_-_Pago_matr=EDcula_de_la_matr=EDcula_de_inscripci=F3n_a?=
|
|
|
|
|
Date: Thu, 4 Aug 2022 14:29:41 +0000
|
|
|
|
|
Message-ID:
|
|
|
|
|
<VE1PR03MB5471882920DE08CFE44D97A0FE9F9@VE1PR03MB5471.eurprd03.prod.outlook.com>
|
|
|
|
|
Accept-Language: es-AR, es-ES, en-US
|
|
|
|
|
Content-Language: es-AR
|
|
|
|
|
X-MS-Has-Attach: yes
|
|
|
|
|
Content-Type: multipart/mixed;
|
|
|
|
|
boundary="_004_VE1PR03MB5471882920DE08CFE44D97A0FE9F9VE1PR03MB5471eurp_"
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
X-OriginatorOrg: ef.com
|
|
|
|
|
X-MS-Exchange-CrossTenant-AuthAs: Internal
|
|
|
|
|
X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5471.eurprd03.prod.outlook.com
|
|
|
|
|
|
|
|
|
|
--_004_VE1PR03MB5471882920DE08CFE44D97A0FE9F9VE1PR03MB5471eurp_
|
|
|
|
|
Content-Type: multipart/alternative;
|
|
|
|
|
boundary="_000_VE1PR03MB5471882920DE08CFE44D97A0FE9F9VE1PR03MB5471eurp_"
|
|
|
|
|
|
|
|
|
|
--_000_VE1PR03MB5471882920DE08CFE44D97A0FE9F9VE1PR03MB5471eurp_
|
|
|
|
|
Content-Type: text/plain; charset="iso-8859-1"
|
|
|
|
|
Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
|
|
|
|
|
Buenas tardes Familia,
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Espero que est=E9n muy bien.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Ya cargamos en sistema su pre inscripci=F3n para el curso
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Quedamos atentos ante cualquier consulta que surja.
|
|
|
|
|
|
|
|
|
|
Saludos,
|
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
|
|
|
|
|
/* i.e., non-utf8 text parts were not converted */
|
|
|
|
|
g_test_bug("2333");
|
|
|
|
|
|
|
|
|
|
// matches
|
|
|
|
|
for (auto&& expr: {
|
|
|
|
|
"subject:matrícula",
|
|
|
|
|
"subject:matricula",
|
|
|
|
|
"body:atentos",
|
|
|
|
|
"body:inscripción"
|
|
|
|
|
}) {
|
|
|
|
|
|
|
|
|
|
if (g_test_verbose())
|
|
|
|
|
g_message("query: '%s'", expr);
|
|
|
|
|
auto qr = store.run_query(expr);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_false(qr->empty());
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
}
|
|
|
|
|
}
|
2022-08-11 22:06:12 +02:00
|
|
|
|
|
2022-10-26 21:35:34 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
2022-10-30 10:28:42 +01:00
|
|
|
|
test_duplicate_refresh_real(bool rename)
|
2022-10-26 21:35:34 +02:00
|
|
|
|
{
|
|
|
|
|
g_test_bug("2327");
|
|
|
|
|
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
"inbox/new/msg",
|
|
|
|
|
{ R"(Message-Id: <abcde@foo.bar>
|
|
|
|
|
From: "Foo Example" <bar@example.com>
|
|
|
|
|
Date: Wed, 26 Oct 2022 11:01:54 -0700
|
|
|
|
|
To: example@example.com
|
|
|
|
|
Subject: Rainy night in Helsinki
|
|
|
|
|
|
|
|
|
|
Boo!
|
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
|
2022-10-30 10:28:42 +01:00
|
|
|
|
/* create maildir with message */
|
2022-10-26 21:35:34 +02:00
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
2023-07-01 17:20:51 +02:00
|
|
|
|
g_debug("%s", store.root_maildir().c_str());
|
2022-10-30 10:28:42 +01:00
|
|
|
|
/* ensure we have a proper maildir, with new/, cur/ */
|
2023-07-01 17:20:51 +02:00
|
|
|
|
auto mres = maildir_mkdir(store.root_maildir() + "/inbox");
|
2022-10-30 10:28:42 +01:00
|
|
|
|
assert_valid_result(mres);
|
2022-10-26 21:35:34 +02:00
|
|
|
|
g_assert_cmpuint(store.size(), ==, 1U);
|
|
|
|
|
|
2022-10-30 10:28:42 +01:00
|
|
|
|
/*
|
|
|
|
|
* find the one msg with a query
|
|
|
|
|
*/
|
|
|
|
|
auto qr = store.run_query("Helsinki", Field::Id::Date, QueryFlags::None);
|
|
|
|
|
g_assert_true(!!qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
const auto old_path = qr->begin().path().value();
|
|
|
|
|
const auto old_docid = qr->begin().doc_id();
|
|
|
|
|
assert_equal(qr->begin().message()->path(), old_path);
|
|
|
|
|
g_assert_true(::access(old_path.c_str(), F_OK) == 0);
|
|
|
|
|
|
2022-10-30 14:46:49 +01:00
|
|
|
|
|
2022-10-30 10:28:42 +01:00
|
|
|
|
/*
|
|
|
|
|
* mark as read, i.e. move to cur/; ensure it really moved.
|
|
|
|
|
*/
|
2022-12-03 15:45:10 +01:00
|
|
|
|
auto move_opts{rename ? Store::MoveOptions::ChangeName : Store::MoveOptions::None};
|
|
|
|
|
auto moved_msgs = store.move_message(old_docid, Nothing, Flags::Seen, move_opts);
|
|
|
|
|
assert_valid_result(moved_msgs);
|
|
|
|
|
g_assert_true(moved_msgs->size() == 1);
|
|
|
|
|
const auto& moved_msg{moved_msgs->at(0).second};
|
|
|
|
|
const auto new_path = moved_msg.path();
|
2022-10-30 10:28:42 +01:00
|
|
|
|
if (!rename)
|
2023-07-01 17:20:51 +02:00
|
|
|
|
assert_equal(new_path, store.root_maildir() + "/inbox/cur/msg:2,S");
|
2022-10-30 10:28:42 +01:00
|
|
|
|
g_assert_cmpuint(store.size(), ==, 1);
|
|
|
|
|
g_assert_false(::access(old_path.c_str(), F_OK) == 0);
|
|
|
|
|
g_assert_true(::access(new_path.c_str(), F_OK) == 0);
|
|
|
|
|
|
2022-11-07 17:35:25 +01:00
|
|
|
|
/* also ensure that the cached sexp for the message has been updated;
|
2022-10-30 10:28:42 +01:00
|
|
|
|
* that's what mu4e uses */
|
2022-12-03 15:45:10 +01:00
|
|
|
|
const auto moved_sexp{moved_msg.sexp()};
|
2022-11-07 17:35:25 +01:00
|
|
|
|
//std::cerr << "@@ " << *moved_msg << '\n';
|
|
|
|
|
g_assert_true(moved_sexp.plistp());
|
2023-06-26 23:53:23 +02:00
|
|
|
|
g_assert_true(!!moved_sexp.get_prop(":path"));
|
|
|
|
|
assert_equal(moved_sexp.get_prop(":path").value().string(), new_path);
|
2022-10-30 10:28:42 +01:00
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* find new message with query, ensure it's really that new one.
|
|
|
|
|
*/
|
|
|
|
|
auto qr2 = store.run_query("Helsinki", Field::Id::Date, QueryFlags::None);
|
|
|
|
|
g_assert_true(!!qr2);
|
|
|
|
|
g_assert_cmpuint(qr2->size(), ==, 1);
|
|
|
|
|
assert_equal(qr2->begin().path().value(), new_path);
|
2022-10-26 21:35:34 +02:00
|
|
|
|
|
|
|
|
|
/* index the messages */
|
|
|
|
|
auto res = store.indexer().start({});
|
|
|
|
|
g_assert_true(res);
|
|
|
|
|
while(store.indexer().is_running()) {
|
|
|
|
|
using namespace std::chrono_literals;
|
|
|
|
|
std::this_thread::sleep_for(100ms);
|
|
|
|
|
}
|
|
|
|
|
g_assert_cmpuint(store.size(), ==, 1);
|
2022-10-30 10:28:42 +01:00
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* ensure query still has the right results
|
|
|
|
|
*/
|
|
|
|
|
auto qr3 = store.run_query("Helsinki", Field::Id::Date, QueryFlags::None);
|
|
|
|
|
g_assert_true(!!qr3);
|
|
|
|
|
g_assert_cmpuint(qr3->size(), ==, 1);
|
|
|
|
|
const auto path3{qr3->begin().path().value()};
|
|
|
|
|
assert_equal(path3, new_path);
|
|
|
|
|
assert_equal(qr3->begin().message()->path(), new_path);
|
|
|
|
|
g_assert_true(::access(path3.c_str(), F_OK) == 0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
test_duplicate_refresh()
|
|
|
|
|
{
|
|
|
|
|
test_duplicate_refresh_real(false/*no rename*/);
|
2022-10-26 21:35:34 +02:00
|
|
|
|
}
|
|
|
|
|
|
2022-10-30 10:28:42 +01:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
test_duplicate_refresh_rename()
|
|
|
|
|
{
|
|
|
|
|
test_duplicate_refresh_real(true/*rename*/);
|
|
|
|
|
}
|
|
|
|
|
|
2022-11-20 08:28:05 +01:00
|
|
|
|
static void
|
|
|
|
|
test_term_split()
|
|
|
|
|
{
|
|
|
|
|
g_test_bug("2365");
|
|
|
|
|
|
|
|
|
|
// Note the fancy quote in "foo’s bar"
|
|
|
|
|
const TestMap test_msgs = {{
|
|
|
|
|
"inbox/new/msg",
|
|
|
|
|
{ R"(Message-Id: <abcde@foo.bar>
|
|
|
|
|
From: "Foo Example" <bar@example.com>
|
|
|
|
|
Date: Wed, 26 Oct 2022 11:01:54 -0700
|
|
|
|
|
To: example@example.com
|
|
|
|
|
Subject: foo’s bar
|
|
|
|
|
|
|
|
|
|
Boo!
|
|
|
|
|
)"},
|
|
|
|
|
}};
|
|
|
|
|
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
/* true: match; false: no match */
|
|
|
|
|
const auto cases = std::array<std::pair<const char*, bool>, 6>{{
|
|
|
|
|
{"subject:foo's", true},
|
|
|
|
|
{"subject:foo*", true},
|
|
|
|
|
{"subject:/foo/", true},
|
|
|
|
|
{"subject:/foo’s/", true}, /* <-- breaks before PR #2365 */
|
|
|
|
|
{"subject:/foo.*bar/", true}, /* <-- breaks before PR #2365 */
|
|
|
|
|
{"subject:/foo’s bar/", false}, /* <-- no matching yet */
|
|
|
|
|
}};
|
|
|
|
|
|
|
|
|
|
for (auto&& test: cases) {
|
|
|
|
|
g_debug("query: %s", test.first);
|
|
|
|
|
auto qr = store.run_query(test.first);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
if (test.second)
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
else
|
|
|
|
|
g_assert_true(qr->empty());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-12-08 18:31:07 +01:00
|
|
|
|
static void
|
|
|
|
|
test_related_dup_threaded()
|
|
|
|
|
{
|
|
|
|
|
// test message sent to self, and copy of received msg.
|
|
|
|
|
|
|
|
|
|
const auto test_msg = R"(From: "Edward Mallory" <ed@leviathan.gb>
|
|
|
|
|
To: "Laurence Oliphant <oli@hotmail.com>
|
|
|
|
|
Subject: Boo
|
|
|
|
|
Date: Wed, 07 Dec 2022 18:38:06 +0200
|
|
|
|
|
Message-ID: <875yentbhg.fsf@djcbsoftware.nl>
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
Content-Type: text/plain
|
|
|
|
|
|
|
|
|
|
Boo!
|
|
|
|
|
)";
|
|
|
|
|
const TestMap test_msgs = {
|
|
|
|
|
{"sent/cur/msg1", test_msg },
|
|
|
|
|
{"inbox/cur/msg1", test_msg },
|
|
|
|
|
{"inbox/cur/msg2", test_msg }};
|
|
|
|
|
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
|
|
|
|
|
g_assert_cmpuint(store.size(), ==, 3);
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// normal query should give 2
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("maildir:/inbox", Field::Id::Date,
|
|
|
|
|
QueryFlags::None);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 2);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// a related query should give 3
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("maildir:/inbox", Field::Id::Date,
|
|
|
|
|
QueryFlags::IncludeRelated);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 3);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// a related/threading query should give 3.
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("maildir:/inbox", Field::Id::Date,
|
|
|
|
|
QueryFlags::IncludeRelated | QueryFlags::Threading);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 3);
|
|
|
|
|
}
|
2023-01-31 22:12:05 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
test_html()
|
|
|
|
|
{
|
|
|
|
|
// test message sent to self, and copy of received msg.
|
|
|
|
|
|
|
|
|
|
const auto test_msg = R"(From: Test <test@example.com>
|
|
|
|
|
To: abc@example.com
|
|
|
|
|
Date: Mon, 23 May 2011 10:53:45 +0200
|
|
|
|
|
Subject: vla
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
Content-Type: multipart/alternative;
|
|
|
|
|
boundary="_=aspNetEmail=_5ed4592191214c7a99bd7f6a3a0f077d"
|
|
|
|
|
Message-ID: <10374608.109906.11909.20115aabbccdd.MSGID@mailinglijst.nl>
|
|
|
|
|
|
|
|
|
|
--_=aspNetEmail=_5ed4592191214c7a99bd7f6a3a0f077d
|
|
|
|
|
Content-Type: text/plain; charset="iso-8859-15"
|
|
|
|
|
Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
|
|
|
|
|
text
|
|
|
|
|
|
|
|
|
|
--_=aspNetEmail=_5ed4592191214c7a99bd7f6a3a0f077d
|
|
|
|
|
Content-Type: text/html; charset="iso-8859-15"
|
|
|
|
|
Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
|
|
|
|
|
html
|
|
|
|
|
|
|
|
|
|
--_=aspNetEmail=_5ed4592191214c7a99bd7f6a3a0f077d--
|
|
|
|
|
)";
|
|
|
|
|
const TestMap test_msgs = {{"inbox/cur/msg1", test_msg }};
|
|
|
|
|
|
|
|
|
|
TempDir tdir;
|
|
|
|
|
auto store{make_test_store(tdir.path(), test_msgs, {})};
|
|
|
|
|
g_assert_cmpuint(store.size(), ==, 1);
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("body:text", Field::Id::Date,
|
|
|
|
|
QueryFlags::None);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
auto qr = store.run_query("body:html", Field::Id::Date,
|
|
|
|
|
QueryFlags::None);
|
|
|
|
|
assert_valid_result(qr);
|
|
|
|
|
g_assert_cmpuint(qr->size(), ==, 1);
|
|
|
|
|
}
|
2022-12-08 18:31:07 +01:00
|
|
|
|
|
|
|
|
|
}
|
2022-10-30 10:28:42 +01:00
|
|
|
|
|
2023-01-31 22:12:05 +01:00
|
|
|
|
|
2022-06-08 23:00:59 +02:00
|
|
|
|
int
|
|
|
|
|
main(int argc, char* argv[])
|
|
|
|
|
{
|
2022-08-10 07:20:58 +02:00
|
|
|
|
mu_test_init(&argc, &argv);
|
2022-06-08 23:00:59 +02:00
|
|
|
|
|
2022-08-10 07:20:58 +02:00
|
|
|
|
g_test_add_func("/store/query/simple", test_simple);
|
2022-06-26 20:55:14 +02:00
|
|
|
|
g_test_add_func("/store/query/spam-address-components",
|
|
|
|
|
test_spam_address_components);
|
2022-08-07 11:01:18 +02:00
|
|
|
|
g_test_add_func("/store/query/dups-related",
|
|
|
|
|
test_dups_related);
|
2022-08-11 22:06:12 +02:00
|
|
|
|
g_test_add_func("/store/query/related-missing-root",
|
|
|
|
|
test_related_missing_root);
|
2022-09-19 17:27:03 +02:00
|
|
|
|
g_test_add_func("/store/query/body-matricula",
|
|
|
|
|
test_body_matricula);
|
2022-10-26 21:35:34 +02:00
|
|
|
|
g_test_add_func("/store/query/duplicate-refresh",
|
|
|
|
|
test_duplicate_refresh);
|
2022-10-30 10:28:42 +01:00
|
|
|
|
g_test_add_func("/store/query/duplicate-refresh-rename",
|
|
|
|
|
test_duplicate_refresh_rename);
|
2022-11-20 08:28:05 +01:00
|
|
|
|
g_test_add_func("/store/query/term-split",
|
|
|
|
|
test_term_split);
|
2022-12-08 18:31:07 +01:00
|
|
|
|
g_test_add_func("/store/query/related-dup-threaded",
|
|
|
|
|
test_related_dup_threaded);
|
2023-01-31 22:12:05 +01:00
|
|
|
|
g_test_add_func("/store/query/html", test_html);
|
2022-08-07 11:01:18 +02:00
|
|
|
|
|
2022-06-08 23:00:59 +02:00
|
|
|
|
return g_test_run();
|
|
|
|
|
}
|