mirror of
https://github.com/jiahaog/Nativefier
synced 2024-06-25 07:37:41 +02:00
74a7d3375d
See discussion at https://github.com/nativefier/nativefier/pull/1124#issuecomment-794751514 : > @TheCleric I was about to merge this, then reconsidered one little thing (yes I wrote "little", I'm not reconsidering this whole thing 😅). > > I'm re-considering having the extra flag. I'm not so sure this will harm a lot of use cases. I'd like to 1. merge this PR, 2. immediately follow up with a small commit removing the flag & adjusting api.md, 3. release with the change well-documented / asking for feedback if this is problematic to anyone. (I'm not asking you any extra work, and like leaving an in-tree commit trace of considering the flag). If people complain with a valid reason, we'll restore the flag with a quick revert, else we're happy with one less flag and a reasonably-handled breaking change. > > Thoughts / objections? Answered by: > That seems reasonable to me. > > [discussion on an extra structured way to pass flags] |
||
|---|---|---|
| .. | ||
| helpers.test.ts | ||
| helpers.ts | ||
| inferFlash.ts | ||