mirror of
https://github.com/jiahaog/Nativefier
synced 2024-06-27 07:45:03 +02:00
5e526fb000
The current check for `count` means the value to reset/remove the badge (`''`) is treated as `false` and therefore the badge does not get removed. This PR changes the check for `undefined` instead which resolves the issue. Related issue: https://github.com/nativefier/nativefier/issues/1251 Testing performed: - I ran `npm t` as per the docs. All tests passed. - I created a new app build for Twitter (`https://twitter.com`) and Messenger (`https://messenger.com`) to verify the correct behaviour. Both were showed the issue as resolved. Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> |
||
|---|---|---|
| .. | ||
| inject | ||
| src | ||
| .eslintrc.js | ||
| .npmrc | ||
| nativefier.json | ||
| package.json | ||
| tsconfig.json | ||
| webpack.config.js | ||