Commit Graph

7 Commits

Author SHA1 Message Date
Ronan Jouchet 6fb3b92eb8
Upgrade dependencies and default to latest Electron 1.7.9 (PR #483)
* Update deps except eslint
* Update eslint and lint:fix (WIP, needs manual fixing for remaining 44 problems)
* Manually fix remaining eslint errors
* Document deprecation of `version-string` as of electron-packager 9.0.0
* Upgrade to Electron 1.7.9 (chrome-58, node-7.9.0, v8-5.8)
* npm: Disable generation of package-lock.json and gitignore it
  --Trying this, package-lock is a pain in PRs. May not be a good idea
  (obviously we lose deps pinning), will revert if necessary.--
* npm tasks: add dev-up-win for Windows developers,
  and e2e for end-to-end tests. Update docs.
* Move normalizeUrl test to a jest unit test, makes no sense to be in the mocha e2e tests
* Switch from babel-preset-es2015 to babel-preset-env,
  with target.node=4.0. Seem like it's today's most convenient
  way to support the latest ES and let babel transpile to what
  makes sense for our currently minimal node version
2017-11-14 08:05:01 -05:00
Jia Hao Goh 8f78dd03af Update eslint and use Airbnb style
- Add `npm run lint:fix` command
- Cleanup inferIcon.js logic slightly
2017-04-29 22:52:12 +08:00
Jia Hao a8072d2234 Hopefully fix icon retrieval bugs
Icon ext from page-icon contains `.` before ext now, e.g. `.png`
2016-03-14 12:28:14 +08:00
Jia Hao e1f2e662e9 Add check for correct icon format 2016-03-12 15:17:03 +08:00
Jia Hao 4c708fac26 Try to use assets store for icons before infer
Also promisified inferIcon
2016-03-11 12:40:08 +08:00
Jia Hao b7aada7967 Fix bug in setting icon on windows for windows 2016-03-10 12:46:09 +08:00
Jia Hao ce8e762ac9 Put files in separate directories 2016-01-29 14:09:36 +08:00