various
/
Nativefier
mirror of https://github.com/jiahaog/Nativefier
1
0
Fork 0
Code Issues Releases Wiki Activity
1,078 Commits 2 Branches 159 Tags 17 MiB
Commit Graph

40 Commits

Author SHA1 Message Date
Adam Weeden 24115bb3bd
Fix regressions in opening windows/tabs, update browser versions (#1284) 
* Update electron to 13.4.0 + update browser versions

* Fix injectCSS preventing new windows from opening

* Fix some window/tab opening weirdness/bugs

* Fix unit tests

* Switch to using onResponseStarted to avoid the issues with callbacks in the future

* Clear up comments on onResponseStarted
 2021-09-24 22:03:03 -04:00
Ronan Jouchet 0fbe7d39cb Build: re-introduce a package-lock.json file 
They were used a long time ago, then I scrapped them for simplicity to
new contributors. I'm re-considering this and re-introducing one, for
two (maybe three) reasons:

1. Reading on supply chain attacks
2. Build broken because of a dep change (see previous commit broken
   because of a change in yargs @ 17.1.0)
(3.) Performance
 2021-09-20 11:25:43 -04:00
Ronan Jouchet d0849ce794 generate-changelog: integrate running "npm out" for a reminder of outdated dependencies 2021-06-28 22:56:53 -04:00
Adam Weeden b74c0bf959
Make app strict TypeScript + linting (and add a shared project) (#1231) 
* Convert app to strict typing + shared library

* Fix new code post-merge

* Remove extraneous lint ignores

* Apply suggestions from code review

Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>

* Fix prettier complaint

* Dedupe eslint files

* Fix some refs after merge

* Fix clean:full command

Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
 2021-06-26 09:59:28 -04:00
Adam Weeden a491e34966
Fix `--tray start-in-tray` (fix #1225) (#1235) 2021-06-22 01:22:46 -04:00
Adam Weeden 113d8448c1
Fix CSS injection (#1227) 
This fixes https://github.com/nativefier/nativefier/pull/1222#issuecomment-860913698 , where:

1. When it works (e.g. initial page load), CSS is slower to inject (you can see pages without injected CSS)
2. CSS isn't injected when navigating to a page

On both Windows & Linux, a `git revert 9a6c6f870d && npm run build` fixes the issue.

--

I'm still not 100% sure what went wrong, but I suspect that the new version of Electron may not be firing onHeadersReceived for the actual navigation events, and only its child requests. To counteract it, I'm now injecting at the navigation event as well. I was able to reproduce the issue and this does seem to fix it. Please let me know if it does for you as well..

Also I noticed some funkiness in your logs where we're trying to inject on font files. So I realized the method is probably not nearly as important as the content-type, so I've switched blacklist methods to blacklist content-types.
 2021-06-15 09:02:57 -04:00
Ronan Jouchet 4badf3dc70 manual-test: fix shellcheck nits, make tests structure more distinct 2021-06-07 17:27:23 -04:00
Adam Weeden 826625f4a4
Fix HTTP basic auth (fix #1219) (#1220) 
Should resolve #1219, as well adds a manual test for basic auth as suggested.

Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
 2021-06-07 17:09:24 -04:00
Ronan Jouchet 45db4e7ec6 README: whoopsie, bad rename of animation 2021-05-21 18:17:59 -04:00
Ronan Jouchet cc02b87de7
Get rid of "docs" folder (#1194) 
It contains a weird mix of stuff and hides valuable files from view at the root of the repo. Better to have:
- Docs at the root
- Rest of the github/release-related hodgepodge (screenshots, scripts) in hidden folder .github
 2021-05-21 18:16:59 -04:00
Adam Weeden b3c202fd33
Bump minimum required version: node>=12.9, npm>=6.9 (#1192) 
* Move minimum supported version: node=12, npm=6.9

* Add missing bits and documentation for future bumping

Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
 2021-05-15 13:32:54 -04:00
Adam Weeden ec0ea4bd67
README: add troubleshooting section for common issues (#1169) 
Per #1112, I'm adding some common troubleshooting steps to the README. As well, this adds a checkbox requesting users to check this section before submitting a ticket, which will hopefully lead to more self-help.
 2021-04-29 20:02:43 -04:00
Ronan Jouchet 9f561c0091 CI: run less node versions, oldest supported / latest is enough 2021-04-23 21:52:03 -04:00
Ronan Jouchet 09accbd28a CI: run in node 16, stop node 15 2021-04-23 21:47:54 -04:00
Ronan Jouchet 292ac39328 CI: avoid npm funding messages 2021-02-26 22:19:45 -05:00
Ronan Jouchet e03e07e4bd Speed up CI by avoiding repeated npm install & build already done with "prepare" hook 2021-02-26 22:15:56 -05:00
Jia Hao 6316d23762 Move to nativefier organization 2021-01-30 04:49:52 +00:00
Jia Hao 59accaba8d Migrate from Travis CI to GitHub Actions 2020-11-22 02:28:14 +00:00
Ronan Jouchet 5d9a7ae4bc nit 2020-07-22 21:08:07 -04:00
Ronan Jouchet 6f50ac6f4f A little less aggressive 2020-07-22 21:07:22 -04:00
Ronan Jouchet 3bf3f2c0a8 One more 2020-07-22 21:04:58 -04:00
Ronan Jouchet bed84e5735 One more nit 2020-07-22 20:57:48 -04:00
Ronan Jouchet c87204cce7 Typo 2020-07-22 20:56:58 -04:00
Ronan Jouchet 7c84785e33 typo 2020-07-22 20:56:29 -04:00
Ronan Jouchet f8e0e9d6cb Detail question.md 2020-07-22 20:56:14 -04:00
Ronan Jouchet b631ee23d6 Nit 2020-07-22 20:54:27 -04:00
Ronan Jouchet 6b73b4e8f8 Improve issue templates 2020-07-22 20:53:46 -04:00
Ronan Jouchet 99ceec59c8 Forbid creating template-less issues 2020-07-22 20:37:04 -04:00
Ronan Jouchet 9f11976b3c Bugreport issue template: add checkmark for latest version 2020-03-19 18:09:37 -04:00
Ronan Jouchet 3c4b743c67 Improve bugreport issue template 2020-03-19 12:30:08 -04:00
Ronan Jouchet f115beed0d Issue templates: nits 2020-03-10 09:19:02 -04:00
Ronan Jouchet 9b50ebf3ca Issue templates / bugreport: nit 2020-03-10 09:17:05 -04:00
Ronan Jouchet a4c373db80 Issue templates: comment header, enrich featurerequest 2020-03-10 09:15:53 -04:00
Ronan Jouchet e57dc16cd3
Update bug_report.md 2020-03-10 09:12:46 -04:00
Ronan Jouchet dc46b16247
Update feature_request.md 2020-03-10 09:11:18 -04:00
Ronan Jouchet 92ef0a4f08
Delete ISSUE_TEMPLATE.md 2020-03-10 09:07:39 -04:00
Jia Hao ba37e5ccd0
Add modern github issue templates: bug, feature request (#901) 
Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
 2020-03-10 09:06:34 -04:00
Ronan Jouchet 2b061e497f ISSUE_TEMPLATE: Add common questions (#415) 2017-07-18 11:24:41 -04:00
Jia Hao Goh 8f78dd03af Update eslint and use Airbnb style 
- Add `npm run lint:fix` command
- Cleanup inferIcon.js logic slightly
 2017-04-29 22:52:12 +08:00
Jia Hao 9510014dd6 Put github files in `.github` 2016-02-23 21:18:58 +08:00