Commit Graph

36 Commits

Author SHA1 Message Date
Ronan Jouchet 19561e9ad6 Make eslint happy 2018-07-21 09:16:02 -04:00
Ronan Jouchet bbef14ccc6 Bump default Electron to 2.0.5, upgrade deps 2018-07-21 08:58:53 -04:00
Goh Jia Hao 0b47999c3e Fix lint error 2018-06-10 11:07:06 -07:00
Goh Jia Hao bd89f90a3d Remove workaround for slashes in page title
This was reported in #22 and has been fixed upstream in electron-userland/electron-packager#308
2018-06-10 11:00:22 -07:00
Goh Jia Hao 49272d1a89 Add test for inferTitle 2018-06-10 11:00:16 -07:00
David Kramer fe6fd9d2a1 Fix `prettier` lint error (#625) 2018-05-27 17:18:33 -04:00
Goh Jia Hao 16aae0a937 Refactor tests to use async/await 2018-05-24 22:46:49 -07:00
Goh Jia Hao 95fc46d38d Integrate prettier 2018-05-24 00:02:44 -07:00
Goh Jia Hao 949dcfadd8 Migrate Mocha tests to Jest 2018-05-23 23:44:03 -07:00
Goh Jia Hao bb67448328 Fix infer icon url #529 2018-03-29 19:38:04 -07:00
David Ollerhead e1909bf5c8 Support Mac App Store (--mas) builds (PR #532) 2018-02-02 08:06:29 -05:00
Ronan Jouchet 6fb3b92eb8
Upgrade dependencies and default to latest Electron 1.7.9 (PR #483)
* Update deps except eslint
* Update eslint and lint:fix (WIP, needs manual fixing for remaining 44 problems)
* Manually fix remaining eslint errors
* Document deprecation of `version-string` as of electron-packager 9.0.0
* Upgrade to Electron 1.7.9 (chrome-58, node-7.9.0, v8-5.8)
* npm: Disable generation of package-lock.json and gitignore it
  --Trying this, package-lock is a pain in PRs. May not be a good idea
  (obviously we lose deps pinning), will revert if necessary.--
* npm tasks: add dev-up-win for Windows developers,
  and e2e for end-to-end tests. Update docs.
* Move normalizeUrl test to a jest unit test, makes no sense to be in the mocha e2e tests
* Switch from babel-preset-es2015 to babel-preset-env,
  with target.node=4.0. Seem like it's today's most convenient
  way to support the latest ES and let babel transpile to what
  makes sense for our currently minimal node version
2017-11-14 08:05:01 -05:00
Jia Hao Goh 1505933826 Promisfy and parallelise config, add unit tests
Instead of optionsMain exporting an async function, this commit changes
it to return a promise instead. We split all the needed async
helpers for this config builder into smaller promises, in `src/options/*`. Another side
effect of this is that we perform all our async config inferring in
parallel, which speeds up the nativefier CLI.

Add proper unit tests as well for all of these promises. Switch to
Jest for these unit tests, and we are temporarily running both Jest and
mocha together in `npm test`. To refactor all the Mocha code to use Jest in
a future commit.
2017-05-07 15:49:15 +08:00
Matt Harris 10eaa53b26 Add ARM build support (#360) 2017-05-06 15:11:51 -04:00
Jia Hao Goh 8f78dd03af Update eslint and use Airbnb style
- Add `npm run lint:fix` command
- Cleanup inferIcon.js logic slightly
2017-04-29 22:52:12 +08:00
Jia Hao Goh b467ac7a51 Promisify inferTitle module
Also remove the request dependency, use Axios instead
2017-04-21 00:24:48 +08:00
Ronan Jouchet be4b9a7436 Fix #327 - Update dependencies (except eslint), default to Electron 1.6.6 (#341) 2017-04-18 17:30:54 -04:00
Goh Jia Hao 1865e97e1a Remove accidentally introduced spacing 2016-05-27 00:15:48 +08:00
Goh Jia Hao 0c588b7219 Allow gitcloud matching of icons for multiple words 2016-05-27 00:10:23 +08:00
Goh Jia Hao 960f3362c9 Update eslint to v2.0.0 2016-05-26 23:05:44 +08:00
Goh Jia Hao 5833347ad8 Fix parsing of title including more than the title tag
- Fixes #195
2016-05-26 18:16:02 +08:00
Jia Hao e7390b9e33 Implement setting of verbose log level 2016-03-25 20:50:52 +08:00
Jia Hao 94c9fdb424 Contain fallback user agent within inferUserAgent 2016-03-25 20:10:45 +08:00
Jia Hao 9a9a63c15a Use axios instead of request 2016-03-25 19:58:03 +08:00
Jia Hao d890078e6e Should throw error on invalid platform 2016-03-25 19:29:13 +08:00
sa 4b6716efef Infer user agent from Electron's online version list 2016-03-19 21:14:41 -04:00
Jia Hao a8072d2234 Hopefully fix icon retrieval bugs
Icon ext from page-icon contains `.` before ext now, e.g. `.png`
2016-03-14 12:28:14 +08:00
Jia Hao e1f2e662e9 Add check for correct icon format 2016-03-12 15:17:03 +08:00
Jia Hao 4c708fac26 Try to use assets store for icons before infer
Also promisified inferIcon
2016-03-11 12:40:08 +08:00
Jia Hao d04cf0ad3a Properly fail if icon is not found by pageicon 2016-03-10 15:52:02 +08:00
Jia Hao c3374618d9 Prefer correct extension for page icon 2016-03-09 14:50:25 +08:00
Jia Hao 3f6f632d51 Fix inferred file name extension 2016-03-08 23:57:19 +08:00
Jia Hao 9a8c18d0a4 Cleanup 2016-03-08 20:55:52 +08:00
Jia Hao c8d6cef815 Remove dependency on bestIcon api
Use page-icon instead
2016-03-08 20:29:04 +08:00
Jia Hao 0d27dd6ae0 Split buildApp to separate files 2016-01-29 14:26:35 +08:00
Jia Hao 51acbaaa9c Cleanup options.js, rename `--app-name` to `--name` 2016-01-29 11:37:54 +08:00