From 8fa394a1c0a88e7bc6ea6ac409687816737a6b7a Mon Sep 17 00:00:00 2001 From: Ronan Jouchet Date: Sat, 13 Jun 2020 10:46:27 -0400 Subject: [PATCH] [BREAKING CHANGE] Require Node.js >= 10 - Several deps started requiring it - CI started breaking on Node 8 - Node 8 is end-of-life, no longer maintained - Even latest Debian stable and Ubuntu LTS ship Node 10: https://packages.debian.org/search?suite=stable&keywords=nodejs https://packages.ubuntu.com/search?searchon=names&suite=all§ion=all&keywords=nodejs So, requiring Node 10 and npm 6 going with it. --- .travis.yml | 10 +++++----- package.json | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index 992a585..b04b28c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,15 +4,15 @@ os: - osx - windows node_js: -- '13' -- '12' # Changing this? Remind to keep linter+deploy conditions below aligned -- '8' +- '14' # Changing this? Remind to keep linter+deploy conditions below aligned +- '12' +- '10' install: - npm run dev-up - npm run build script: # Only run linter once, for faster CI. Remind to keep linter+deploy conditions below aligned -- if [ "$TRAVIS_OS_NAME" = "linux" ] && [ "$TRAVIS_NODE_VERSION" = "12" ]; then npm run lint; fi +- if [ "$TRAVIS_OS_NAME" = "linux" ] && [ "$TRAVIS_NODE_VERSION" = "14" ]; then npm run lint; fi - npm test # https://docs.travis-ci.com/user/deployment deploy: @@ -24,5 +24,5 @@ deploy: on: tags: true repo: jiahaog/nativefier - node_js: '12' # Remind to keep linter+deploy conditions above aligned + node_js: '14' # Remind to keep linter+deploy conditions above aligned condition: '$TRAVIS_OS_NAME = linux' diff --git a/package.json b/package.json index 97fbabb..6b71cdf 100644 --- a/package.json +++ b/package.json @@ -5,8 +5,8 @@ "license": "MIT", "author": "Goh Jia Hao", "engines": { - "node": ">= 8.10.0", - "npm": ">= 5.6.0" + "node": ">= 10.0.0", + "npm": ">= 6.0.0" }, "keywords": [ "desktop", @@ -84,7 +84,7 @@ "jest": "26.x", "prettier": "2.x", "rimraf": "3.x", - "ts-loader": "6.x", + "ts-loader": "7.x", "typescript": "3.x", "webpack": "4.x", "webpack-cli": "3.x"