From 74bc2d41880eef89b34c56ab44643f4ad51522dc Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Mon, 18 Apr 2022 23:46:31 +0100 Subject: [PATCH] Auto-internal URLs: add VMWare Workspace ONE + SecurID (PR #1391, fix #1390) Update internal URLs to include VMware's Workspace ONE and SecurID. --- API.md | 2 ++ app/src/helpers/helpers.test.ts | 2 ++ app/src/helpers/helpers.ts | 2 ++ 3 files changed, 6 insertions(+) diff --git a/API.md b/API.md index 3e292d4..799814f 100644 --- a/API.md +++ b/API.md @@ -795,6 +795,8 @@ Current known internal login pages: - `login.live.com` , `login.microsoftonline.com` - `okta.com` - `twitter.com/oauth/authenticate` +- `workspaceair.com` +- `securid.com` Note: While .com is specified, for most of these we try to match even on non-US based domains such as `.co.uk` as well diff --git a/app/src/helpers/helpers.test.ts b/app/src/helpers/helpers.test.ts index 454729f..4ae396e 100644 --- a/app/src/helpers/helpers.test.ts +++ b/app/src/helpers/helpers.test.ts @@ -200,6 +200,8 @@ const testLoginPages = [ 'https://appleid.apple.com/auth/authorize', 'https://id.atlassian.com', 'https://auth.atlassian.com', + 'https://vmware.workspaceair.com', + 'https://vmware.auth.securid.com', ]; test.each(testLoginPages)( diff --git a/app/src/helpers/helpers.ts b/app/src/helpers/helpers.ts index d36e31d..82272a5 100644 --- a/app/src/helpers/helpers.ts +++ b/app/src/helpers/helpers.ts @@ -106,6 +106,8 @@ function isInternalLoginPage(url: string): boolean { 'twitter\\.[a-zA-Z\\.]*/oauth/authenticate', // Twitter 'appleid\\.apple\\.com/auth/authorize', // Apple '(?:id|auth)\\.atlassian\\.[a-zA-Z]+', // Atlassian + '.*\\.workspaceair\\.com', // VMWare Workspace One SSO + '.*\\.securid\\.com', // SecurID for VMWare Workspace One SSO ]; // Making changes? Remember to update the tests in helpers.test.ts and in API.md const regex = RegExp(internalLoginPagesArray.join('|'));