From 60035a8e74e3794bac16fb5945780b9be514b164 Mon Sep 17 00:00:00 2001 From: Ronan Jouchet Date: Wed, 20 Apr 2022 22:06:46 -0400 Subject: [PATCH] Bump max tested version of Node for CI/Publish from 17 to 18 Released yesterday: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V18.md#18.0.0 --- .github/workflows/ci.yml | 4 ++-- .github/workflows/publish.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 048fcc6..3766db7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: matrix: node-version: # Align the top Node version here with: 1. linter conditions later below, 2. publish.yml. - - '17' + - '18' # Bumping the minimum required Node version? You must bump: # 1. package.json -> engines.node # 2. package.json -> devDependencies.@types/node @@ -43,7 +43,7 @@ jobs: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 run: npm ci --no-fund # Only run linter once, for faster CI. Align the versions of Node here with above and publish.yml. - - if: matrix.platform == 'ubuntu-latest' && matrix.node-version == '17' + - if: matrix.platform == 'ubuntu-latest' && matrix.node-version == '18' run: npm run lint - run: npm run test -- --testPathIgnorePatterns ".*playwright.*" - if: matrix.platform != 'ubuntu-latest' # Doesn't work on non-GUI ubuntu diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 81a2088..c3cd9dd 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/setup-node@v1 with: # Align the version of Node here with ci.yml. - node-version: '17.x' + node-version: '18.x' registry-url: 'https://registry.npmjs.org' # Will also (through `prepare` hook): 1. install ./app, and 2. build - run: npm ci --no-fund