various
/
Nativefier
mirror of https://github.com/jiahaog/Nativefier
1
0
Fork 0
Code Issues Releases Wiki Activity
Nativefier/src/options/fields/icon.js

15 lines
366 B
JavaScript
Raw Normal View History

Promisfy and parallelise config, add unit tests Instead of optionsMain exporting an async function, this commit changes it to return a promise instead. We split all the needed async helpers for this config builder into smaller promises, in `src/options/*`. Another side effect of this is that we perform all our async config inferring in parallel, which speeds up the nativefier CLI. Add proper unit tests as well for all of these promises. Switch to Jest for these unit tests, and we are temporarily running both Jest and mocha together in `npm test`. To refactor all the Mocha code to use Jest in a future commit.
2017-05-07 09:49:15 +02:00
import log from 'loglevel';
Make eslint happy
2018-07-21 15:16:02 +02:00
import { inferIcon } from '../../infer';
Promisfy and parallelise config, add unit tests Instead of optionsMain exporting an async function, this commit changes it to return a promise instead. We split all the needed async helpers for this config builder into smaller promises, in `src/options/*`. Another side effect of this is that we perform all our async config inferring in parallel, which speeds up the nativefier CLI. Add proper unit tests as well for all of these promises. Switch to Jest for these unit tests, and we are temporarily running both Jest and mocha together in `npm test`. To refactor all the Mocha code to use Jest in a future commit.
2017-05-07 09:49:15 +02:00
Integrate prettier
2018-05-24 09:02:44 +02:00
export default function({ icon, targetUrl, platform }) {
Promisfy and parallelise config, add unit tests Instead of optionsMain exporting an async function, this commit changes it to return a promise instead. We split all the needed async helpers for this config builder into smaller promises, in `src/options/*`. Another side effect of this is that we perform all our async config inferring in parallel, which speeds up the nativefier CLI. Add proper unit tests as well for all of these promises. Switch to Jest for these unit tests, and we are temporarily running both Jest and mocha together in `npm test`. To refactor all the Mocha code to use Jest in a future commit.
2017-05-07 09:49:15 +02:00
// Icon is the path to the icon
if (icon) {
Fix bug resolving promises When a explicit argument is passed for `--icon` or `--user-agent`, the promise chain will fail because we do not return a resolved promise.
2017-05-19 14:50:09 +02:00
return Promise.resolve(icon);
Promisfy and parallelise config, add unit tests Instead of optionsMain exporting an async function, this commit changes it to return a promise instead. We split all the needed async helpers for this config builder into smaller promises, in `src/options/*`. Another side effect of this is that we perform all our async config inferring in parallel, which speeds up the nativefier CLI. Add proper unit tests as well for all of these promises. Switch to Jest for these unit tests, and we are temporarily running both Jest and mocha together in `npm test`. To refactor all the Mocha code to use Jest in a future commit.
2017-05-07 09:49:15 +02:00
}
Integrate prettier
2018-05-24 09:02:44 +02:00
return inferIcon(targetUrl, platform).catch((error) => {
log.warn('Cannot automatically retrieve the app icon:', error);
return null;
});
Promisfy and parallelise config, add unit tests Instead of optionsMain exporting an async function, this commit changes it to return a promise instead. We split all the needed async helpers for this config builder into smaller promises, in `src/options/*`. Another side effect of this is that we perform all our async config inferring in parallel, which speeds up the nativefier CLI. Add proper unit tests as well for all of these promises. Switch to Jest for these unit tests, and we are temporarily running both Jest and mocha together in `npm test`. To refactor all the Mocha code to use Jest in a future commit.
2017-05-07 09:49:15 +02:00
}