better formatting in health check

docs/health-check.md

@@ -26,3 +26,11 @@ This probably means you are running OSX, which ships with *bash 3*. In order to
 ## tmux version is too old
 
 You can install latest *tmux* from source, check https://github.com/tmux/tmux
+
+## How to skip the check
+
+If can't skip this check by adding the following in your .tmux.conf file:
+
+```
+set -g @fingers-skip-health-check '1'
+```

scripts/health-check.sh

@@ -2,7 +2,6 @@
 
 CURRENT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 source $CURRENT_DIR/utils.sh
-source $CURRENT_DIR/debug.sh
 
 REQUIRED_BASH_MAJOR=4
 REQUIRED_TMUX_MAJOR=2
@@ -10,6 +9,7 @@ RECOMMENDED_TMUX_MINOR=3
 HELP_LINK="https://github.com/Morantron/tmux-fingers/blob/master/docs/health-check.md"
 
 health_tmp=$(fingers_tmp)
+log_messages=()
 
 function is_tmux_ready() {
   local num_windows=$(tmux list-windows | wc -l)
@@ -31,22 +31,88 @@ function program_exists() {
   fi
 }
 
-function log_health() {
-  echo "$1" >> "$health_tmp"
+function log_message() {
+  log_messages+=("$1")
+}
+
+function repeat_char() {
+  local char="$1"
+  local n_times="$2"
+  local i=0
+  local output=""
+
+  while [[ $i -lt "$n_times" ]]; do
+    output="$output$char"
+    i=$((i + 1))
+  done
+
+  echo "$output"
+}
+
+function right_pad() {
+  local str="$1"
+  local char="$2"
+  local max_length="$3"
+  local padding=$(($max_length - ${#str}))
+
+  if [[ padding -lt 0 ]]; then
+    padding=0
+  fi
+
+  echo "$str$(repeat_char "$char" "$padding")"
+}
+
+function dump_log() {
+  log_messages=("tmux-fingers health-check:" "" "${log_messages[@]}")
+
+  # pad messages
+  local i=0
+  for message in "${log_messages[@]}" ; do
+    log_messages[$i]=" $message "
+    i=$((i + 1))
+  done
+
+  # calculate max_length
+  local lengths=""
+  for message in "${log_messages[@]}" ; do
+    lengths="$lengths\n${#message}"
+  done
+  local max_length=$(echo -e "$lengths" | sort -r | head -n 1)
+
+  local horizontal_border="+$(repeat_char "-" $((max_length)))+"
+
+  # wrap messages within pipe chars
+  i=0
+  for message in "${log_messages[@]}" ; do
+    log_messages[$i]="|$(right_pad "$message" " " $((max_length)))|"
+    i=$((i + 1))
+  done
+
+  log_messages=($horizontal_border "${log_messages[@]}" $horizontal_border)
+
+  for message in "${log_messages[@]}" ; do
+    echo -e "$message" >> "$health_tmp"
+  done
 }
 
 function perform_health_check() {
   local healthy=1
 
+  FINGERS_SKIP_HEALTH_CHECK=$(tmux show-option -gqv @fingers-skip-health-check)
+
+  if [[ $FINGERS_SKIP_HEALTH_CHECK -eq 1 ]]; then
+    return
+  fi
+
   if [[ $(program_exists "gawk") = "0" ]]; then
-    log_health "* 'gawk' not found"
+    log_message "* 'gawk' not found"
     healthy=0
   fi
 
   BASH_MAJOR=$(echo "$BASH_VERSION" | grep -Eo "^[0-9]")
 
   if [[ "$BASH_MAJOR" -lt "$REQUIRED_BASH_MAJOR" ]]; then
-    log_health "* Bash version \"$BASH_VERSION\" is too old."
+    log_message "  * Bash version \"$BASH_VERSION\" is too old."
     healthy=0
   fi
 
@@ -55,12 +121,12 @@ function perform_health_check() {
   TMUX_MINOR=$(echo "$TMUX_VERSION" | cut -f2 -d. | grep -Eo "[0-9]")
 
   if [[ $TMUX_MAJOR -lt $REQUIRED_TMUX_MAJOR ]]; then
-    log_health "* tmux version \"$TMUX_VERSION\" is too old."
+    log_message "  * tmux version \"$TMUX_VERSION\" is too old."
     healthy=0
   fi
 
   if [[ $TMUX_MAJOR -eq $REQUIRED_TMUX_MAJOR ]] && [[ $TMUX_MINOR -lt $RECOMMENDED_TMUX_MINOR ]]; then
-    echo "* WARNING: tmux 2.2+ is recommended"
+    echo "  * WARNING: tmux 2.2+ is recommended"
   fi
 
   if [[ $healthy -eq 0 ]]; then
@@ -68,9 +134,18 @@ function perform_health_check() {
       : # waiting for-tmux
     done
 
-    log_health "For more info check $HELP_LINK"
-    log_health "To skip this check add \"set -g @fingers-skip-health-check 1\" to your tmux conf"
-    tmux run "echo -e \"tmux-fingers health-check:\"; cat $health_tmp"
+    log_message ""
+    log_message "For a better tmux-fingers experience, please install the required versions."
+    log_message ""
+    log_message "For more info check:"
+    log_message "  $HELP_LINK"
+    log_message ""
+    log_message "To skip this check add \"set -g @fingers-skip-health-check '1'\" to your tmux conf"
+    log_message ""
+
+    dump_log
+
+    tmux run "cat $health_tmp"
   fi
 
   rm -rf "$health_tmp"