move tweet button to a plugin, implement basic support for article action button plugins

This commit is contained in:
Andrew Dolgov 2011-12-20 23:57:27 +04:00
parent 73621c5605
commit f9ac31d671
6 changed files with 43 additions and 59 deletions

View File

@ -704,11 +704,15 @@ class Feeds extends Protected_Handler {
onclick=\"emailArticle($id)\" onclick=\"emailArticle($id)\"
alt='Zoom' title='".__('Forward by email')."'>"; alt='Zoom' title='".__('Forward by email')."'>";
if (ENABLE_TWEET_BUTTON) { $button_plugins = explode(",", ARTICLE_BUTTON_PLUGINS);
$reply['content'] .= "<img src=\"".theme_image($this->link, 'images/art-tweet.png')."\"
class='tagsPic' style=\"cursor : pointer\" foreach ($button_plugins as $p) {
onclick=\"tweetArticle($id)\" $pclass = "${p}_button";
alt='Zoom' title='".__('Share on Twitter')."'>";
if (class_exists($pclass)) {
$plugin = new $pclass($link);
$rv['content'] .= $plugin->render($id);
}
} }
$reply['content'] .= "<img src=\"".theme_image($this->link, 'images/art-share.png')."\" $reply['content'] .= "<img src=\"".theme_image($this->link, 'images/art-share.png')."\"

View File

@ -753,21 +753,16 @@ class RPC extends Protected_Handler {
return; return;
} }
function getTweetInfo() { function buttonPlugin() {
$id = db_escape_string($_REQUEST['id']); $pclass = basename($_REQUEST['plugin']) . "_button";
$method = $_REQUEST['plugin_method'];
$result = db_query($this->link, "SELECT title, link if (class_exists($pclass)) {
FROM ttrss_entries, ttrss_user_entries $plugin = new $pclass($this->link);
WHERE id = '$id' AND ref_id = id AND owner_uid = " .$_SESSION['uid']); if (method_exists($plugin, $method)) {
return $plugin->$method();
if (db_num_rows($result) != 0) { }
$title = truncate_string(strip_tags(db_fetch_result($result, 0, 'title')),
100, '...');
$article_link = db_fetch_result($result, 0, 'link');
} }
print json_encode(array("title" => $title, "link" => $article_link,
"id" => $id));
} }
function setNote() { function setNote() {

View File

@ -175,9 +175,6 @@
// *** Twitter integration settings *** // *** Twitter integration settings ***
// ************************************ // ************************************
define('ENABLE_TWEET_BUTTON', false);
// Enable 'tweet this' button for articles
define('CONSUMER_KEY', ''); define('CONSUMER_KEY', '');
define('CONSUMER_SECRET', ''); define('CONSUMER_SECRET', '');
// Your OAuth instance authentication information for Twitter, visit // Your OAuth instance authentication information for Twitter, visit
@ -202,7 +199,12 @@
define('FEEDBACK_URL', ''); define('FEEDBACK_URL', '');
// Displays an URL for users to provide feedback or comments regarding // Displays an URL for users to provide feedback or comments regarding
// this instance of tt-rss. Can lead to a forum, contact email, etc. // this instance of tt-rss. Can lead to a forum, contact email, etc.
define('ARTICLE_BUTTON_PLUGINS', 'tweet');
// Comma-separated list of additional article action button plugins
// to enable, like tweet button, etc.
// The following plugins are available: tweet
define('CONFIG_VERSION', 24); define('CONFIG_VERSION', 24);
// Expected config version. Please update this option in config.php // Expected config version. Please update this option in config.php
// if necessary (after migrating all new options from this file). // if necessary (after migrating all new options from this file).

View File

@ -3289,11 +3289,15 @@
onclick=\"emailArticle($id)\" onclick=\"emailArticle($id)\"
alt='Zoom' title='".__('Forward by email')."'>"; alt='Zoom' title='".__('Forward by email')."'>";
if (ENABLE_TWEET_BUTTON) { $button_plugins = explode(",", ARTICLE_BUTTON_PLUGINS);
$rv['content'] .= "<img src=\"".theme_image($link, 'images/art-tweet.png')."\"
class='tagsPic' style=\"cursor : pointer\" foreach ($button_plugins as $p) {
onclick=\"tweetArticle($id)\" $pclass = "${p}_button";
alt='Zoom' title='".__('Share on Twitter')."'>";
if (class_exists($pclass)) {
$plugin = new $pclass($link);
$rv['content'] .= $plugin->render($id);
}
} }
$rv['content'] .= "<img src=\"".theme_image($link, 'images/art-share.png')."\" $rv['content'] .= "<img src=\"".theme_image($link, 'images/art-share.png')."\"

View File

@ -5,7 +5,7 @@
exit; exit;
} }
set_include_path(get_include_path() . PATH_SEPARATOR . set_include_path(get_include_path() . PATH_SEPARATOR .
dirname(__FILE__) ."/include"); dirname(__FILE__) ."/include");
require_once "functions.php"; require_once "functions.php";
@ -40,6 +40,16 @@
<?php print_theme_includes($link) ?> <?php print_theme_includes($link) ?>
<?php print_user_stylesheet($link) ?> <?php print_user_stylesheet($link) ?>
<script type="text/javascript">
<?php foreach (explode(",", ARTICLE_BUTTON_PLUGINS) as $p) {
$jsf = "js/${p}_button.js";
if (file_exists($jsf)) {
include $jsf;
print "</script>";
}
} ?>
</script>
<link rel="shortcut icon" type="image/png" href="images/favicon.png"/> <link rel="shortcut icon" type="image/png" href="images/favicon.png"/>
<script type="text/javascript" src="lib/prototype.js"></script> <script type="text/javascript" src="lib/prototype.js"></script>

View File

@ -1994,37 +1994,6 @@ function initHeadlinesMenu() {
} }
} }
function tweetArticle(id) {
try {
var query = "?op=rpc&method=getTweetInfo&id=" + param_escape(id);
console.log(query);
var d = new Date();
var ts = d.getTime();
var w = window.open('backend.php?op=backend&method=loading', 'ttrss_tweet',
"status=0,toolbar=0,location=0,width=500,height=400,scrollbars=1,menubar=0");
new Ajax.Request("backend.php", {
parameters: query,
onComplete: function(transport) {
var ti = JSON.parse(transport.responseText);
var share_url = "http://twitter.com/share?_=" + ts +
"&text=" + param_escape(ti.title) +
"&url=" + param_escape(ti.link);
w.location.href = share_url;
} });
} catch (e) {
exception_error("tweetArticle", e);
}
}
function editArticleNote(id) { function editArticleNote(id) {
try { try {