From e31e9ae04d7d3dd9e7a4633badba60d8229eee85 Mon Sep 17 00:00:00 2001
From: Andrew Dolgov <noreply@fakecake.org>
Date: Wed, 10 Apr 2019 13:39:07 +0300
Subject: [PATCH] db_prefs: don't report missing prefs if die_on_error is false

---
 classes/db/prefs.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/db/prefs.php b/classes/db/prefs.php
index 1fddd27c5..188076134 100644
--- a/classes/db/prefs.php
+++ b/classes/db/prefs.php
@@ -90,8 +90,8 @@ class Db_Prefs {
 
 			return $this->convert($value, $type_name);
 
-		} else {
-			user_error("Fatal error, unknown preferences key: $pref_name (owner: $user_id)", $die_on_error ? E_USER_ERROR : E_USER_WARNING);
+		} else if ($die_on_error) {
+			user_error("Fatal error, unknown preferences key: $pref_name (owner: $user_id)", E_USER_ERROR);
 			return null;
 		}
 	}