af_comics: Use a fixed time of day when generating fake feed for GoComics. Without this the timestamp is always updated to be the time the feed is fetched, which causes the comics to keep moving to the top/bottom of the article list depending on the sort order. (Using 11:00 a.m. UTC as that should keep the date the same across the majority of time zones.)

Try to get the actual title for GoComics comics.

Also a little code clean up.
This commit is contained in:
JustAMacUser 2019-10-06 16:17:58 -04:00
parent 4e05008aac
commit 8459238f6c
1 changed files with 13 additions and 10 deletions

View File

@ -114,9 +114,6 @@ class Af_Comics extends Plugin {
$tpl->setVariable('FEED_URL', htmlspecialchars($fetch_url), true); $tpl->setVariable('FEED_URL', htmlspecialchars($fetch_url), true);
$tpl->setVariable('SELF_URL', $site_url, true); $tpl->setVariable('SELF_URL', $site_url, true);
$tpl->setVariable('ARTICLE_UPDATED_ATOM', date('c'), true);
$tpl->setVariable('ARTICLE_UPDATED_RFC822', date(DATE_RFC822), true);
if ($body) { if ($body) {
$doc = new DOMDocument(); $doc = new DOMDocument();
@ -126,13 +123,22 @@ class Af_Comics extends Plugin {
$node = $xpath->query('//picture[contains(@class, "item-comic-image")]/img')->item(0); $node = $xpath->query('//picture[contains(@class, "item-comic-image")]/img')->item(0);
if ($node) { if ($node) {
$node->removeAttribute("width"); $title = $xpath->query('//h1')->item(0);
$node->removeAttribute("data-srcset");
$node->removeAttribute("srcset"); if ($title) {
$title = clean(trim($title->nodeValue));
} else {
$title = date('l, F d, Y');
}
foreach (['srcset', 'sizes', 'data-srcset', 'width'] as $attr ) {
$node->removeAttribute($attr);
}
$tpl->setVariable('ARTICLE_ID', $article_link, true); $tpl->setVariable('ARTICLE_ID', $article_link, true);
$tpl->setVariable('ARTICLE_LINK', $article_link, true); $tpl->setVariable('ARTICLE_LINK', $article_link, true);
$tpl->setVariable('ARTICLE_TITLE', date('l, F d, Y'), true); $tpl->setVariable('ARTICLE_UPDATED_ATOM', date('c', mktime(11, 0, 0)), true);
$tpl->setVariable('ARTICLE_TITLE', htmlspecialchars($title), true);
$tpl->setVariable('ARTICLE_EXCERPT', '', true); $tpl->setVariable('ARTICLE_EXCERPT', '', true);
$tpl->setVariable('ARTICLE_CONTENT', $doc->saveHTML($node), true); $tpl->setVariable('ARTICLE_CONTENT', $doc->saveHTML($node), true);
@ -141,15 +147,12 @@ class Af_Comics extends Plugin {
$tpl->setVariable('ARTICLE_SOURCE_TITLE', $feed_title, true); $tpl->setVariable('ARTICLE_SOURCE_TITLE', $feed_title, true);
$tpl->addBlock('entry'); $tpl->addBlock('entry');
} }
} }
} }
$tpl->addBlock('feed'); $tpl->addBlock('feed');
$tmp_data = '';
if ($tpl->generateOutputToString($tmp_data)) if ($tpl->generateOutputToString($tmp_data))
$feed_data = $tmp_data; $feed_data = $tmp_data;
} }