servers/ttrss
1
0
Fork 0
mirror of https://tt-rss.org/git/tt-rss.git synced 2024-06-29 12:20:51 +02:00
Code Issues Releases Wiki Activity

Revert 7ed4fa4c1d and use @var instead.

Browse Source 
PHPStan had trouble recognizing that ['items'] might have elements added.
This commit is contained in:
wn_ 2023-03-05 16:29:51 +00:00
parent 42b287e964
commit 029cb8f442
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
classes/pref/feeds.php
View File

@ -241,7 +241,12 @@ class Pref_Feeds extends Handler_Protected {
//$root['param'] += count($cat['items']); //$root['param'] += count($cat['items']);
} }
/* Uncategorized is a special case */ /**
* Uncategorized is a special case.
*
* Define a minimal array shape to help PHPStan with the type of $cat['items']
* @var array{items: array<int, array<string, mixed>>} $cat
*/
$cat = [ $cat = [
'id' => 'CAT:0', 'id' => 'CAT:0',
'bare_id' => 0, 'bare_id' => 0,
@ -267,7 +272,7 @@ class Pref_Feeds extends Handler_Protected {
} }
foreach ($feeds_obj->find_many() as $feed) { foreach ($feeds_obj->find_many() as $feed) {
$cat['items'][] = [ array_push($cat['items'], [
'id' => 'FEED:' . $feed->id, 'id' => 'FEED:' . $feed->id,
'bare_id' => (int) $feed->id, 'bare_id' => (int) $feed->id,
'auxcounter' => -1, 'auxcounter' => -1,
@ -279,7 +284,7 @@ class Pref_Feeds extends Handler_Protected {
'unread' => -1, 'unread' => -1,
'type' => 'feed', 'type' => 'feed',
'updates_disabled' => (int)($feed->update_interval < 0), 'updates_disabled' => (int)($feed->update_interval < 0),
]; ]);
} }
$cat['param'] = sprintf(_ngettext('(%d feed)', '(%d feeds)', count($cat['items'])), count($cat['items'])); $cat['param'] = sprintf(_ngettext('(%d feed)', '(%d feeds)', count($cat['items'])), count($cat['items']));