From 1d9a709444f9bc56f0c2ce0fafed87b7ca61341b Mon Sep 17 00:00:00 2001 From: Pierre Rudloff Date: Thu, 14 May 2020 00:21:25 +0200 Subject: [PATCH] Remove obsolete phpstan rule --- classes/streams/PlaylistArchiveStream.php | 3 +++ grumphp.yml | 1 - phpstan.neon | 4 ---- 3 files changed, 3 insertions(+), 5 deletions(-) delete mode 100644 phpstan.neon diff --git a/classes/streams/PlaylistArchiveStream.php b/classes/streams/PlaylistArchiveStream.php index 9792cef..e7a6724 100644 --- a/classes/streams/PlaylistArchiveStream.php +++ b/classes/streams/PlaylistArchiveStream.php @@ -50,7 +50,10 @@ class PlaylistArchiveStream extends ZipArchive implements StreamInterface /** * PlaylistArchiveStream constructor. * + * We don't call the parent constructor because it messes up the output buffering. + * * @param Video $video Video/playlist to download + * @noinspection PhpMissingParentConstructorInspection */ public function __construct(Video $video) { diff --git a/grumphp.yml b/grumphp.yml index 7425276..8454537 100644 --- a/grumphp.yml +++ b/grumphp.yml @@ -12,6 +12,5 @@ parameters: - RoboFile.php phpstan: level: max - configuration: phpstan.neon ignore_patterns: - RoboFile.php diff --git a/phpstan.neon b/phpstan.neon deleted file mode 100644 index 5b7e4e6..0000000 --- a/phpstan.neon +++ /dev/null @@ -1,4 +0,0 @@ -parameters: - ignoreErrors: - # The Archive constructor messes up the output buffering. - - '#Alltube\\Stream\\PlaylistArchiveStream::__construct\(\) does not call parent constructor from Barracuda\\ArchiveStream\\ZipArchive\.#'