From cd9fe46fdbbc2b0890a156b8b36d61d9114c34fd Mon Sep 17 00:00:00 2001 From: antelle Date: Sun, 29 Nov 2020 18:06:56 +0100 Subject: [PATCH] fixed jumping title in Safari --- app/styles/areas/_details.scss | 11 +++++++---- release-notes.md | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/styles/areas/_details.scss b/app/styles/areas/_details.scss index ec500f6f..956c69ad 100644 --- a/app/styles/areas/_details.scss +++ b/app/styles/areas/_details.scss @@ -42,8 +42,10 @@ text-overflow: ellipsis; border-radius: var(--input-border-radius); border: 1px solid transparent; - height: 1.4em; - line-height: 1.4em; + // why px and not em? it's like this to prevent jumping in different browsers + // when switching from a div to an input and vice versa + height: 42px; + line-height: 40px; white-space: nowrap; &:hover { transition: border-color $base-duration $base-timing; @@ -54,8 +56,9 @@ } } input.details__header-title-input { - height: calc(1.4em + 6px); - line-height: 1.4em; + // see the comment about px above + height: 48px; + line-height: 40px; user-select: text; flex: 1; margin: 0 6px; diff --git a/release-notes.md b/release-notes.md index e96abaa9..30decf5e 100644 --- a/release-notes.md +++ b/release-notes.md @@ -2,6 +2,7 @@ Release notes ------------- ##### v1.16.1 (TBD) `-` fix #1637: git commit in the About box +`-` fixed some design glitches ##### v1.16.0 (2020-11-29) `+` updated icons and visual design