diff --git a/app/scripts/comp/launcher-electron.js b/app/scripts/comp/launcher-electron.js index 3d40b2ec..34b3f312 100644 --- a/app/scripts/comp/launcher-electron.js +++ b/app/scripts/comp/launcher-electron.js @@ -221,7 +221,7 @@ const Launcher = { spawn(config) { const ts = logger.ts(); let complete = config.complete; - const ps = this.remReq('child_process').spawn(config.cmd, config.args); + const ps = this.req('child_process').spawn(config.cmd, config.args); [ps.stdin, ps.stdout, ps.stderr].forEach(s => s.setEncoding('utf-8')); let stderr = ''; let stdout = ''; @@ -254,12 +254,17 @@ const Launcher = { }); if (config.data) { try { - ps.stdin.write(config.data); - ps.stdin.end(); + ps.stdin.end(config.data); } catch (e) { logger.error('spawn write error', e); } } + process.nextTick(() => { + // it should work without destroy, but a process doesn't get launched + // xubuntu-desktop 19.04 / xfce + // see https://github.com/keeweb/keeweb/issues/1234 + ps.stdin.destroy(); + }); return ps; }, getCookies(callback) { diff --git a/release-notes.md b/release-notes.md index ce8f9dad..66c75750 100644 --- a/release-notes.md +++ b/release-notes.md @@ -1,7 +1,8 @@ Release notes ------------- -##### v1.9.1 (2019-08-20) +##### v1.9.1 (2019-08-22) `-` fix #1235: custom themes loading +`-` fix #1234 auto-type issues in xubuntu/xfce ##### v1.9.1 (2019-08-19) `-` fix #1231: tooltip arrow positioning