fix #1290: generator popup positioning in custom themes

This commit is contained in:
antelle 2019-10-13 13:16:57 +02:00
parent 517134c95b
commit 99bcbc288c
5 changed files with 5 additions and 4 deletions

View File

@ -17,7 +17,7 @@ class FieldViewAutocomplete extends FieldViewText {
startEdit() {
super.startEdit();
const fieldRect = this.input[0].getBoundingClientRect();
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread'));
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0;
this.autocomplete = $('<div class="details__field-autocomplete"></div>').appendTo('body');
this.autocomplete.css({
top: fieldRect.bottom + shadowSpread,

View File

@ -42,7 +42,7 @@ class FieldViewDate extends FieldViewText {
adjustPickerPosition(...args) {
window.Pikaday = Pikaday;
Pikaday.prototype.adjustPosition.apply(this.picker, args);
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread'));
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0;
if (shadowSpread) {
const isOnTop = this.picker.el.classList.contains('top-aligned');
const offset = isOnTop ? -shadowSpread : shadowSpread;

View File

@ -41,7 +41,7 @@ class FieldViewTags extends FieldViewText {
startEdit() {
super.startEdit();
const fieldRect = this.input[0].getBoundingClientRect();
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread'));
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0;
this.tagsAutocomplete = $('<div class="details__field-autocomplete"></div>').appendTo(
'body'
);

View File

@ -102,7 +102,7 @@ class FieldViewText extends FieldView {
this.hideGenerator();
} else {
const fieldRect = this.input[0].getBoundingClientRect();
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread'));
const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0;
this.gen = new GeneratorView({
pos: { left: fieldRect.left, top: fieldRect.bottom + shadowSpread },
password: this.value

View File

@ -2,6 +2,7 @@ Release notes
-------------
##### v1.11.9 (TBD)
`-` fix #1300: selecting auto-type sequence items issues
`-` fix #1290: generator popup positioning in custom themes
##### v1.11.8 (2019-10-11)
`-` fix #1292: macOS app notarization