From 363ff309e6fb285d76d1c453ea2053f881b838f9 Mon Sep 17 00:00:00 2001 From: Dennis Ploeger Date: Thu, 3 Jan 2019 08:18:13 +0100 Subject: [PATCH] Moved error interpretation to storage provider --- app/scripts/storage/storage-file.js | 3 +++ app/scripts/views/settings/settings-file-view.js | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/scripts/storage/storage-file.js b/app/scripts/storage/storage-file.js index 5788dcd5..355a24dc 100644 --- a/app/scripts/storage/storage-file.js +++ b/app/scripts/storage/storage-file.js @@ -63,6 +63,9 @@ const StorageFile = StorageBase.extend({ const ts = this.logger.ts(); const onError = e => { + if (e.hasOwnProperty('code') && e.code === 'EISDIR') { + e.isDir = true; + } this.logger.error('Error writing local file', path, e); if (callback) { callback(e); diff --git a/app/scripts/views/settings/settings-file-view.js b/app/scripts/views/settings/settings-file-view.js index f667a620..bf8e6237 100644 --- a/app/scripts/views/settings/settings-file-view.js +++ b/app/scripts/views/settings/settings-file-view.js @@ -514,7 +514,7 @@ const SettingsFileView = Backbone.View.extend({ if (err) { let title = ''; let description = ''; - if (err.hasOwnProperty('code') && err.code === 'EISDIR') { + if (err.isDir) { title = Locale.setFileBackupErrorIsDir; description = Locale.setFileBackupErrorIsDirDescription; } else {