From 517134c95bb769db3fcef47d6f066ea9b5dd5600 Mon Sep 17 00:00:00 2001 From: antelle Date: Sat, 12 Oct 2019 18:56:33 +0200 Subject: [PATCH 1/4] fix #1300: selecting auto-type sequence items issues --- app/scripts/views/auto-type/auto-type-hint-view.js | 2 +- release-notes.md | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/scripts/views/auto-type/auto-type-hint-view.js b/app/scripts/views/auto-type/auto-type-hint-view.js index 5401072d..9aa31a2e 100644 --- a/app/scripts/views/auto-type/auto-type-hint-view.js +++ b/app/scripts/views/auto-type/auto-type-hint-view.js @@ -77,7 +77,7 @@ class AutoTypeHintView extends View { const pos = this.input.selectionEnd || this.input.value.length; this.input.value = this.input.value.substr(0, pos) + text + this.input.value.substr(pos); this.input.selectionStart = this.input.selectionEnd = pos + text.length; - this.input.dispatchEvent(new Event('input')); + this.input.dispatchEvent(new Event('input', { bubbles: true })); } } diff --git a/release-notes.md b/release-notes.md index a42e5467..a539b1be 100644 --- a/release-notes.md +++ b/release-notes.md @@ -1,5 +1,8 @@ Release notes ------------- +##### v1.11.9 (TBD) +`-` fix #1300: selecting auto-type sequence items issues + ##### v1.11.8 (2019-10-11) `-` fix #1292: macOS app notarization `-` fix #1296: search in auto-type From 99bcbc288cb1423f11689e0a2d7b6aa4a2a6305b Mon Sep 17 00:00:00 2001 From: antelle Date: Sun, 13 Oct 2019 13:16:57 +0200 Subject: [PATCH 2/4] fix #1290: generator popup positioning in custom themes --- app/scripts/views/fields/field-view-autocomplete.js | 2 +- app/scripts/views/fields/field-view-date.js | 2 +- app/scripts/views/fields/field-view-tags.js | 2 +- app/scripts/views/fields/field-view-text.js | 2 +- release-notes.md | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/scripts/views/fields/field-view-autocomplete.js b/app/scripts/views/fields/field-view-autocomplete.js index 94d391ba..df95b0fc 100644 --- a/app/scripts/views/fields/field-view-autocomplete.js +++ b/app/scripts/views/fields/field-view-autocomplete.js @@ -17,7 +17,7 @@ class FieldViewAutocomplete extends FieldViewText { startEdit() { super.startEdit(); const fieldRect = this.input[0].getBoundingClientRect(); - const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')); + const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0; this.autocomplete = $('
').appendTo('body'); this.autocomplete.css({ top: fieldRect.bottom + shadowSpread, diff --git a/app/scripts/views/fields/field-view-date.js b/app/scripts/views/fields/field-view-date.js index 1eb9feb3..bd636f87 100644 --- a/app/scripts/views/fields/field-view-date.js +++ b/app/scripts/views/fields/field-view-date.js @@ -42,7 +42,7 @@ class FieldViewDate extends FieldViewText { adjustPickerPosition(...args) { window.Pikaday = Pikaday; Pikaday.prototype.adjustPosition.apply(this.picker, args); - const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')); + const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0; if (shadowSpread) { const isOnTop = this.picker.el.classList.contains('top-aligned'); const offset = isOnTop ? -shadowSpread : shadowSpread; diff --git a/app/scripts/views/fields/field-view-tags.js b/app/scripts/views/fields/field-view-tags.js index eade2980..f6fb4b48 100644 --- a/app/scripts/views/fields/field-view-tags.js +++ b/app/scripts/views/fields/field-view-tags.js @@ -41,7 +41,7 @@ class FieldViewTags extends FieldViewText { startEdit() { super.startEdit(); const fieldRect = this.input[0].getBoundingClientRect(); - const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')); + const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0; this.tagsAutocomplete = $('
').appendTo( 'body' ); diff --git a/app/scripts/views/fields/field-view-text.js b/app/scripts/views/fields/field-view-text.js index 55b8b25d..7c622bfb 100644 --- a/app/scripts/views/fields/field-view-text.js +++ b/app/scripts/views/fields/field-view-text.js @@ -102,7 +102,7 @@ class FieldViewText extends FieldView { this.hideGenerator(); } else { const fieldRect = this.input[0].getBoundingClientRect(); - const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')); + const shadowSpread = parseInt(this.input.css('--focus-shadow-spread')) || 0; this.gen = new GeneratorView({ pos: { left: fieldRect.left, top: fieldRect.bottom + shadowSpread }, password: this.value diff --git a/release-notes.md b/release-notes.md index a539b1be..1b062909 100644 --- a/release-notes.md +++ b/release-notes.md @@ -2,6 +2,7 @@ Release notes ------------- ##### v1.11.9 (TBD) `-` fix #1300: selecting auto-type sequence items issues +`-` fix #1290: generator popup positioning in custom themes ##### v1.11.8 (2019-10-11) `-` fix #1292: macOS app notarization From ce55ca1e0d89c12802e165f21b63a5c93678f1be Mon Sep 17 00:00:00 2001 From: antelle Date: Sun, 13 Oct 2019 23:09:46 +0200 Subject: [PATCH 3/4] release date --- release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-notes.md b/release-notes.md index 1b062909..b04cb24e 100644 --- a/release-notes.md +++ b/release-notes.md @@ -1,6 +1,6 @@ Release notes ------------- -##### v1.11.9 (TBD) +##### v1.11.9 (2019-10-13) `-` fix #1300: selecting auto-type sequence items issues `-` fix #1290: generator popup positioning in custom themes From bc4dbc7de249bd75094873b7be05d475bfc27ad0 Mon Sep 17 00:00:00 2001 From: antelle Date: Sun, 13 Oct 2019 23:10:05 +0200 Subject: [PATCH 4/4] bump version --- desktop/package-lock.json | 2 +- desktop/package.json | 2 +- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/desktop/package-lock.json b/desktop/package-lock.json index ddcdfcf5..3f3b555c 100644 --- a/desktop/package-lock.json +++ b/desktop/package-lock.json @@ -1,6 +1,6 @@ { "name": "KeeWeb", - "version": "1.11.8", + "version": "1.11.9", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/desktop/package.json b/desktop/package.json index a4546624..79f5e584 100644 --- a/desktop/package.json +++ b/desktop/package.json @@ -1,6 +1,6 @@ { "name": "KeeWeb", - "version": "1.11.8", + "version": "1.11.9", "description": "Free cross-platform password manager compatible with KeePass", "main": "main.js", "homepage": "https://keeweb.info", diff --git a/package-lock.json b/package-lock.json index 57ea4d9a..bc98600e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "keeweb", - "version": "1.11.8", + "version": "1.11.9", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 81e35692..ca839fb8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "keeweb", - "version": "1.11.8", + "version": "1.11.9", "description": "Free cross-platform password manager compatible with KeePass", "main": "Gruntfile.js", "private": true,