code changes per @antelle's review

This commit is contained in:
lawrencium 2017-04-09 01:31:05 -07:00
parent b0288b8815
commit 1ffdf2b438
3 changed files with 8 additions and 6 deletions

View File

@ -62,6 +62,10 @@ const AutoType = {
});
}
});
if (AppSettingsModel.instance.get('lockOnAutoType')) {
Backbone.trigger('lock-workspace');
}
},
run(entry, callback) {
@ -144,10 +148,6 @@ const AutoType = {
} else {
callback();
}
if (AppSettingsModel.instance.get('lockOnAutoType')) {
Backbone.trigger('lock-workspace');
}
},
getActiveWindowTitle(callback) {

View File

@ -13,6 +13,7 @@ const Storage = require('../../storage');
const FeatureDetector = require('../../util/feature-detector');
const Locale = require('../../util/locale');
const Links = require('../../const/links');
const AutoType = require('../../auto-type');
const SettingsGeneralView = Backbone.View.extend({
template: require('templates/settings/settings-general.hbs'),
@ -77,6 +78,7 @@ const SettingsGeneralView = Backbone.View.extend({
canAutoUpdate: Updater.enabled,
canMinimize: Launcher && Launcher.canMinimize(),
canDetectMinimize: !!Launcher,
canAutoType: AutoType.enabled,
lockOnMinimize: Launcher && AppSettingsModel.instance.get('lockOnMinimize'),
lockOnCopy: AppSettingsModel.instance.get('lockOnCopy'),
lockOnAutoType: AppSettingsModel.instance.get('lockOnAutoType'),

View File

@ -146,13 +146,13 @@
{{#if lockOnCopy}}checked{{/if}} />
<label for="settings__general-lock-on-copy">{{res 'setGenLockCopy'}}</label>
</div>
{{#if canAutoType}}
<div>
<input type="checkbox" class="settings__input input-base settings__general-lock-on-auto-type" id="settings__general-lock-on-auto-type"
{{#if lockOnAutoType}}checked{{/if}} />
<label for="settings__general-lock-on-auto-type">{{res 'setGenLockAutoType'}}</label>
</div>
{{/if}}
<h2>{{res 'setGenStorage'}}</h2>
{{#each storageProviders as |prv|}}
<h4 class="settings__general-storage-header"><input