From 79ef6fe87a63f1108a4f0a001a9edbb8c957a0a1 Mon Sep 17 00:00:00 2001
From: "Dirk-Jan C. Binnema" <djcb@djcbsoftware.nl>
Date: Wed, 13 Jan 2010 22:35:16 +0200
Subject: [PATCH] * mu_query_combine: refactor, reduce complexity

---
 src/mu-query-xapian.cc | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/mu-query-xapian.cc b/src/mu-query-xapian.cc
index cc9b5f49..cf332c60 100644
--- a/src/mu-query-xapian.cc
+++ b/src/mu-query-xapian.cc
@@ -197,6 +197,22 @@ mu_query_xapian_as_string  (MuQueryXapian *self, const char* searchexpr)
 }
 
 
+static gboolean
+_needs_quotes (const char* str)
+{
+	int i;
+	const char *keywords[] = {
+		"ANO", "OR", "NOT", "NEAR", "ADJ"
+	};
+
+	for (i = 0; i != G_N_ELEMENTS(keywords); ++i)
+		if (g_strcasecmp (str, keywords[i]) == 0)
+			return TRUE;
+
+	return FALSE;
+}
+
+
 char*
 mu_query_xapian_combine (const gchar **params, gboolean connect_or)
 {
@@ -219,11 +235,8 @@ mu_query_xapian_combine (const gchar **params, gboolean connect_or)
 		
 		if (params[i + 1])
 			cnx = connect_or ? " OR " : " AND ";
-
-		do_quote = (strcasecmp (elm, "OR") == 0  ||
-			    strcasecmp (elm, "AND") == 0 ||
-			    strcasecmp (elm, "NOT") == 0);
 		
+		do_quote = _needs_quotes (elm);
 		g_string_append_printf (str, "%s%s%s%s",
 					do_quote ? "\"" : "",
 					elm,