emacs
/
evil-collection
mirror of https://github.com/jojojames/evil-collection.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Put notmuch-common-keymap last 

Since all the other maps in `evil-collection-notmuch-maps`
have notmuch-common-keymap as parent
https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-hello.el;h=fa31694ff0f79a7f2781849394390a673f75aade;hb=HEAD#l651

When `evil-collection-setup-hook` runs, if it changes keymaps
using a `dolist` over `evil-collection-notmuch-maps`, then a binding might
see 2 changes at once.

See discussion here https://github.com/hlissner/doom-emacs/pull/4403#issuecomment-750907188
This commit is contained in:
Gerry Agbobada 2020-12-24 17:47:20 +01:00 committed by Pierre Neidhardt
parent 92c8002214
commit 16e14ea9c5
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
modes/notmuch/evil-collection-notmuch.el
View File

@ -36,13 +36,20 @@
(declare-function notmuch-search-tag "notmuch")
(declare-function notmuch-tree-tag "notmuch-tree")
(defconst evil-collection-notmuch-maps '(notmuch-common-keymap
notmuch-hello-mode-map
;; Since all the other maps in `evil-collection-notmuch-maps`
;; have notmuch-common-keymap as parent
;; https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-hello.el;h=fa31694ff0f79a7f2781849394390a673f75aade;hb=HEAD#l651
;;
;; When `evil-collection-setup-hook` runs, if it changes keymaps
;; using a `dolist` over `evil-collection-notmuch-maps`, then a binding might
;; see 2 changes at once. To avoid that, notmuch-common-keymap is last
(defconst evil-collection-notmuch-maps '(notmuch-hello-mode-map
notmuch-show-mode-map
notmuch-show-part-map
notmuch-tree-mode-map
notmuch-search-mode-map
notmuch-search-stash-map))
notmuch-search-stash-map
notmuch-common-keymap))
(defun evil-collection-notmuch-toggle-tag (tag mode &optional next-function)
"Toggle TAG tag for message in MODE."