diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index dc837b6..748fcae 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,12 @@ https://github.com/your/awesome_package +Assume you're working on `mpc` mode: + - [ ] byte-compiles cleanly -- [ ] `M-x checkdoc` is happy +- [ ] `M-x checkdoc` is happy. Don't manually write `(provide 'evil-collection-mpc)`, `M-x checkdoc` can do it automatically for you +- [ ] define `evil-collection-mpc-setup` with `defun` +- [ ] define `evil-collection-mpc-mode-maps` with `defconst` +- [ ] All functions should start with `evil-collection-mpc-` diff --git a/modes/mpc/evil-collection-mpc.el b/modes/mpc/evil-collection-mpc.el index ec5fdcf..9c29d28 100644 --- a/modes/mpc/evil-collection-mpc.el +++ b/modes/mpc/evil-collection-mpc.el @@ -31,13 +31,15 @@ (defconst evil-collection-mpc-mode-maps '(mpc-mode-map)) -(defun evil-collection-move-mpc-down () +(defun evil-collection-mpc-move-down () "Move the cursor down along with selecting the element." + (interactive) (evil-next-visual-line) (mpc-select)) -(defun evil-collection-move-mpc-up () +(defun evil-collection-mpc-move-up () "Move the cursor up along with selecting the element." + (interactive) (evil-previous-visual-line) (mpc-select)) @@ -45,8 +47,8 @@ (defun evil-collection-mpc-setup () "Setup up 'evil' bindings for 'mpc-mode'." (evil-collection-define-key 'normal 'mpc-mode-map - "C-j" 'evil-collection-move-mpc-down - "C-k" 'evil-collection-move-mpc-up + "C-j" 'evil-collection-mpc-move-down + "C-k" 'evil-collection-mpc-move-up "t" 'mpc-toggle-play "r" 'mpc-toggle-repeat "s" 'mpc-toggle-shuffle