From 429a1d685df7fdce10a157b9bc783153b19d4923 Mon Sep 17 00:00:00 2001 From: Adam Hill Date: Sat, 5 Nov 2016 13:14:39 -0500 Subject: [PATCH] Update README.md Clarified readme updgrade instructions to address #60 --- README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 1f5b546..a68b589 100644 --- a/README.md +++ b/README.md @@ -90,12 +90,13 @@ The standard pi-hole customization abilities apply to this docker, but with dock **If you try to use `pi-hole -up` it will fail.** For those unfamilar, the docker way to ugprade is: -* Throw away your container: `docker rm -f pihole` +1. Download the latest version of the image: `docker pull diginc/pi-hole` +2. Throw away your container: `docker rm -f pihole` + * **Warning** When removing your pihole container you may be stuck without DNS until step 3 - **docker pull** before you **docker rm -f** to avoid DNS inturruption or always have a fallback DNS server configured in DHCP configured to avoid this problem all together. * If you care about your data (logs/customizations), make sure you have it volume mapped or it will be deleted in this step -* Download the latest version of the image: `docker pull diginc/pi-hole` -* Start your container with the newer base image: `docker run ... diginc/pi-hole` (whatever your original run command was) +3. Start your container with the newer base image: `docker run ... diginc/pi-hole` (whatever your original run command was) -Why is this style of upgrading good? A couple reasons: Everyone is starting from the same base image which has been tested to know it works. No worrying about upgrading from A to B, B to C, or A to C is required when rolling out updates, reducing complexity. +Why is this style of upgrading good? A couple reasons: Everyone is starting from the same base image which has been tested to know it works. No worrying about upgrading from A to B, B to C, or A to C is required when rolling out updates, it reducing complexity, and simply allows a 'fresh start' every time while preserving customizations with volumes. ### Volumes customizations