1
0
mirror of https://github.com/tomav/docker-mailserver.git synced 2024-06-26 19:25:53 +02:00
docker-mailserver/test
Brennan Kinney 47f8d50beb
fix: Ensure configs are sanitized for parsing (#3819)
* chore: Detect missing final newline in configs read

These lines will be not be processed by `read`, emit a warning to raise awareness.

* fix: Ensure parsed config has final newline appended (when possible)

This functionality was handled in `accounts.sh` via a similar sed command (that the linked references also offer).

`printf` is better for this, no shellcheck comment required either.

We additionally don't attempt to modify files that are read-only.

* fix: Ensure parsed configs have CRLF to LF corrected (where possible)

Likewise, this runtime fix was only covering two config files. It now applies to all callers of this method.

* fix: Sanitize `postfix-master.cf` via helper

This feature should have been using the helper to avoid user error from their config updates accidentally introducing subtle breakage implicitly (due to CRLF or missing final newline).

* tests: Add test cases for new helpers

* tests:  `rm` is redundant when using `BATS_TEST_TMPDIR`

This temporary directory is created and removed implicitly. Even after a test failure.

* chore: Remove old `postfix-virtual.cf` migration logic

This was introduced in 2018, there should be no one needing to rely on this anymore?

* tests: Remove comment on sed failure concern

* chore: Add entry to `CHANGELOG.md`

* Apply suggestions from code review

Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

---------

Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-01-26 10:28:26 +13:00
..
bats@e8c840b58f update BATS & helper + minor updates to BATS variables (#2988) 2023-01-09 08:54:04 +01:00
config fix: Correctly support multiple Dovecot PassDBs (#3812) 2024-01-23 19:11:05 +01:00
files fix: Correctly support multiple Dovecot PassDBs (#3812) 2024-01-23 19:11:05 +01:00
helper fix: Ensure configs are sanitized for parsing (#3819) 2024-01-26 10:28:26 +13:00
linting ci: Linter EC should use /check as the mount path (#3655) 2023-11-25 12:34:00 +00:00
test_helper Change 'until' style (#3366) 2023-05-26 07:42:03 +02:00
tests fix: Ensure configs are sanitized for parsing (#3819) 2024-01-26 10:28:26 +13:00