1
0
mirror of https://github.com/tomav/docker-mailserver.git synced 2024-06-30 21:21:31 +02:00
docker-mailserver/target/scripts/startup/setup.d
Brennan Kinney 47f8d50beb
fix: Ensure configs are sanitized for parsing (#3819)
* chore: Detect missing final newline in configs read

These lines will be not be processed by `read`, emit a warning to raise awareness.

* fix: Ensure parsed config has final newline appended (when possible)

This functionality was handled in `accounts.sh` via a similar sed command (that the linked references also offer).

`printf` is better for this, no shellcheck comment required either.

We additionally don't attempt to modify files that are read-only.

* fix: Ensure parsed configs have CRLF to LF corrected (where possible)

Likewise, this runtime fix was only covering two config files. It now applies to all callers of this method.

* fix: Sanitize `postfix-master.cf` via helper

This feature should have been using the helper to avoid user error from their config updates accidentally introducing subtle breakage implicitly (due to CRLF or missing final newline).

* tests: Add test cases for new helpers

* tests:  `rm` is redundant when using `BATS_TEST_TMPDIR`

This temporary directory is created and removed implicitly. Even after a test failure.

* chore: Remove old `postfix-virtual.cf` migration logic

This was introduced in 2018, there should be no one needing to rely on this anymore?

* tests: Remove comment on sed failure concern

* chore: Add entry to `CHANGELOG.md`

* Apply suggestions from code review

Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

---------

Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-01-26 10:28:26 +13:00
..
security general: update base image to Debian 12 ("Bookworm") (#3403) 2024-01-24 17:05:55 +01:00
dmarc_dkim_spf.sh scripts: add wrapper to update Postfix configuration safely (#3484) 2023-08-22 08:03:41 +00:00
dovecot.sh Remove sed statement (#3715) 2023-12-20 13:43:32 +13:00
fetchmail.sh Change 'for' style (#3368) 2023-05-26 14:00:40 +02:00
getmail.sh Change 'for' style (#3368) 2023-05-26 14:00:40 +02:00
ldap.sh chore: LDAP config improvements (#3522) 2023-09-02 22:07:02 +12:00
log.sh refactor: logrotate setup + rspamd log path + tests log helper fallback path (#3576) 2023-10-14 17:14:10 +02:00
mail_state.sh feat: Add MTA-STS support for outbound mail (#3592) 2024-01-13 21:37:20 +13:00
mta-sts.sh feat: Add MTA-STS support for outbound mail (#3592) 2024-01-13 21:37:20 +13:00
networking.sh Change 'for' style (#3368) 2023-05-26 14:00:40 +02:00
oauth2.sh feat: Auth - OAuth2 (Dovecot PassDB) (#3480) 2024-01-13 09:45:14 +13:00
postfix.sh fix: Ensure configs are sanitized for parsing (#3819) 2024-01-26 10:28:26 +13:00
saslauthd.sh chore: LDAP config improvements (#3522) 2023-09-02 22:07:02 +12:00
vmail-id.sh feat: Allow changing the Dovecot vmail UID/GID via ENV (#3550) 2023-10-01 00:20:03 +13:00