From e1fc455079f37b27e162d4fcab666da0caa5bc6e Mon Sep 17 00:00:00 2001 From: Sjoerd Simons Date: Sun, 18 Dec 2016 23:20:08 +0100 Subject: [PATCH] Avoid duplicate backup paths Target directories from the from-files argument get added to the command line args, after which all command line args were appended to the same variable again causing duplicates. Split the used variables to avoid this. Signed-off-by: Sjoerd Simons --- src/cmds/restic/cmd_backup.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cmds/restic/cmd_backup.go b/src/cmds/restic/cmd_backup.go index aa3f3ccb7..c8e3933eb 100644 --- a/src/cmds/restic/cmd_backup.go +++ b/src/cmds/restic/cmd_backup.go @@ -289,7 +289,7 @@ func readLinesFromFile(filename string) ([]string, error) { } func runBackup(opts BackupOptions, gopts GlobalOptions, args []string) error { - target, err := readLinesFromFile(opts.FilesFrom) + fromfile, err := readLinesFromFile(opts.FilesFrom) if err != nil { return err } @@ -297,11 +297,12 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, args []string) error { // merge files from files-from into normal args so we can reuse the normal // args checks and have the ability to use both files-from and args at the // same time - args = append(args, target...) + args = append(args, fromfile...) if len(args) == 0 { return errors.Fatalf("wrong number of parameters") } + target := make([]string, 0, len(args)) for _, d := range args { if a, err := filepath.Abs(d); err == nil { d = a