Check for ip-addresses before iterating over them

This commit is contained in:
johnpc35 2020-08-08 02:25:10 -04:00
parent 01dd5bc270
commit d9d990bd34
1 changed files with 18 additions and 17 deletions

View File

@ -208,25 +208,26 @@ class ProxmoxAPI(object):
if type(networks) is dict:
for network in networks:
for ip_address in ['ip-address']:
try:
# IP address validation
if socket.inet_aton(ip_address):
# Ignore localhost
if ip_address != '127.0.0.1':
return ip_address
except socket.error:
pass
try:
# IP address validation
if socket.inet_aton(ip_address):
# Ignore localhost
if ip_address != '127.0.0.1':
return ip_address
except socket.error:
pass
elif type(networks) is list:
for network in networks:
for ip_address in network['ip-addresses']:
try:
# IP address validation
if socket.inet_aton(ip_address['ip-address']):
# Ignore localhost
if ip_address['ip-address'] != '127.0.0.1':
return ip_address['ip-address']
except socket.error:
pass
if 'ip-addresses' in network:
for ip_address in network['ip-addresses']:
try:
# IP address validation
if socket.inet_aton(ip_address['ip-address']):
# Ignore localhost
if ip_address['ip-address'] != '127.0.0.1':
return ip_address['ip-address']
except socket.error:
pass
return None
def openvz_ip_address(self, node, vm):